From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 932F329D27E for ; Wed, 26 Nov 2025 07:36:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764142585; cv=none; b=F02+OsQVHROrauFpSSrlS+kpZbVa72uQK23/8JLLA9DaFHjN0p3gBpIVyN9u0Qmvq18EZSLmhKXo2udsLv4/0h1Q6BKYI4STBw2y1veQ6+O4n7hsJ9VJEo3ytPQB2b1IBy7UU0VlrDYeXwwzeSt/4hTplN8UXNnphbWJBWPBK7o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764142585; c=relaxed/simple; bh=+NYZTcPMfQw8EVvM4OhMcZhhk3laGmdMxWTa5PItr74=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=cxYW8OUTE3beRuXoH7/88XHcB0G56A3TAT2Kh1Ic0Giuwm3G8SM0QN3YOK0E6yGdhr30w4Gs5jsjMId5e0qQ/OGJW0bcUVV9/+9nwb2HRmXn5mX8eK0Rlip1p1t/V9iR5DtUr0MT4ZVD2eBsWHZqhD2PwG1u/iKFglMWG/iDSvw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=nFyvzeeW; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="nFyvzeeW" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-42b3108f41fso3837453f8f.3 for ; Tue, 25 Nov 2025 23:36:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1764142581; x=1764747381; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=uwb4gEZQsVssNNQKKaHnFD1mEjqfKdCKrDRZhkYlGCU=; b=nFyvzeeWb9JDcvgVDAYupEKe6ZHkm4uagrSkxVy2oqcywFoW45d+53JI8Nr5+qYYk5 E//hPD8GXgnK0x3i/VMddEYgSaHT3RVgkIU99oOD27WsgW2yYMqTfzD5ZCSoPEChDHqx bGqRS9VW0ZbCXoIB3PShKO1uljkgYEPFZyVglhtvpNYP6YDL2/oYOL26xBnBB1zeQMk7 toOfRW7KauApdiCrw7EGdjcPufAEEJvL+bg3gExLqk8LlS+0NgPcDpByO2u3L93zgjhD M6qx7s1XLLnoV6Z4k9Nk1LD/mNWQX0EDxBfESv0dTGZ8AkTjN41+5c+GKID4dkZOAFzN 1r1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764142581; x=1764747381; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=uwb4gEZQsVssNNQKKaHnFD1mEjqfKdCKrDRZhkYlGCU=; b=jnubLo9NfRVBOBU2K516pUsZLYD8EtoJEstj//WSAqsCoLQncnYihC81+cK6zSOSw9 NcAd5O0LuskpLtRIAXtHLHPwDRD9LGxEdO5s02B4nYrvtfEB6eMU1OisIE+vHcS2snt5 cqvXfL6uDh6x1TBhWccyxrdCt7Rmq6E9wwjb+BuGySzPlilXhLebGoSPa5crAvIQuCQY HZGUAf4zLMSmE1gzp1Q9Xe8R9PEfbQ+ryWZoe6gbz+Mr2XKsS5ejChgxQP1TbDdk3xmC h/B6Pa7D7hYsi2+AUaFTY3dFudOM5TIhC6D3KBtRr4GmAVcCDf5zNo6++/NVb6HsILs3 tkeg== X-Gm-Message-State: AOJu0Yy0fDV9DsALIdY3Mo5ZZ/rjDAwbvkYCcD8yYW7vycI0TPR4sRmY I3Xawd8vBpq8DlzRXQEQmpe2N1rEaUvCxxMEhtfWpTb7vmEyZAT9kF7SMlyIsn1i2NA= X-Gm-Gg: ASbGncshHuygjJpcprs8Jx+uslcO+/eB6NqUZUz493r0m3wJ3oqCPlt40ukluwQX4p4 Xg9JQXTKATpte73br6EirH2UBXzn7UFE8+lC7V8FlT87lnNHO+URIF6olyV9qAMjqc4ASSToKN2 vJ8cafJrgFiWSnrYOrEsgnogaaQFRNQL6SfOa04YuXI1qkoU93prwfQTNrqnUdP9SzrD6iX6+1i sp9u2q+Luk9Kkt0OM7b4ekVZgsn3SFwq4pU2lpBIRUyDMIIoHmXoVc24rQp7c1YTu4jDV9N1U7R JUGy7yfnXVSezFPRwHciq9CXopUNab5ahkMVximdCh6IPxcGHhSEBsD4J49Ghb236natOrN3e4/ qjj+Cf3Bm1s42tZh8GtG9uuVm4LbLr8IvKwTRy9RlrVKq4oJBU0FFiiHRh1Trb3Q4jujfLYdy8X YE+N8X2fqVnX6wixQM X-Google-Smtp-Source: AGHT+IEkJIVmft0K1+fBvK9APlqevDyQqqLhuiwQwAv9PNhWzAVjw6Cn97feu3xnWTKXQ+ps5Ed2JA== X-Received: by 2002:a5d:5f91:0:b0:42b:3bc4:16e9 with SMTP id ffacd0b85a97d-42cc1abdf6amr18484142f8f.4.1764142580820; Tue, 25 Nov 2025 23:36:20 -0800 (PST) Received: from draszik.lan ([212.129.87.89]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42cb7fb919bsm38547158f8f.34.2025.11.25.23.36.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Nov 2025 23:36:20 -0800 (PST) Message-ID: <1fafb9117a9faa32222a55efc77794156635d105.camel@linaro.org> Subject: Re: [PATCH 4/6] mfd: max77759: modify irq configs From: =?ISO-8859-1?Q?Andr=E9?= Draszik To: Amit Sunil Dhamne , Sebastian Reichel , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Lee Jones , Greg Kroah-Hartman , Badhri Jagan Sridharan , Heikki Krogerus , Peter Griffin , Tudor Ambarus , Alim Akhtar Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, RD Babiera , Kyle Tso Date: Wed, 26 Nov 2025 07:36:35 +0000 In-Reply-To: References: <20251123-max77759-charger-v1-0-6b2e4b8f7f54@google.com> <20251123-max77759-charger-v1-4-6b2e4b8f7f54@google.com> <5c901a6c831775a04924880cc9f783814f75b6aa.camel@linaro.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.2-2+build3 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Wed, 2025-11-26 at 06:44 +0000, Andr=C3=A9 Draszik wrote: > Hi Amit, >=20 > On Tue, 2025-11-25 at 17:10 -0800, Amit Sunil Dhamne wrote: > > Hi Andr=C3=A9, > >=20 > > On 11/23/25 10:21 PM, Andr=C3=A9 Draszik wrote: > > > Hi Amit, > > >=20 > > > Thanks for your patches to enable the charger! > >=20 > > Ack! > >=20 > >=20 > > > > From: Amit Sunil Dhamne > > > >=20 > > > > Define specific bit-level masks for charger's registers and modify = the > > > > irq mask for charger irq_chip. Also, configure the max77759 interru= pt > > > > lines as active low to all interrupt registrations to ensure the > > > > interrupt controllers are configured with the correct trigger type. > > > >=20 > > > > Signed-off-by: Amit Sunil Dhamne > > > > --- > > > > =C2=A0=C2=A0drivers/mfd/max77759.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0 | 24 +++++++++++++++++------- > > > > =C2=A0=C2=A0include/linux/mfd/max77759.h |=C2=A0 9 +++++++++ > > > > =C2=A0=C2=A02 files changed, 26 insertions(+), 7 deletions(-) > > > >=20 > > > > diff --git a/drivers/mfd/max77759.c b/drivers/mfd/max77759.c > > > > index 6cf6306c4a3b..5fe22884f362 100644 > > > > --- a/drivers/mfd/max77759.c > > > > +++ b/drivers/mfd/max77759.c > > > > @@ -256,8 +256,17 @@ static const struct regmap_irq max77759_topsys= _irqs[] =3D { > > > > =C2=A0=C2=A0}; > > > > =C2=A0=20 > > > > =C2=A0=C2=A0static const struct regmap_irq max77759_chgr_irqs[] =3D= { > > > > - REGMAP_IRQ_REG(MAX77759_CHARGER_INT_1, 0, GENMASK(7, 0)), > > > > - REGMAP_IRQ_REG(MAX77759_CHARGER_INT_2, 1, GENMASK(7, 0)), > > > > + REGMAP_IRQ_REG(MAX77759_CHARGER_INT_1, 0, > > > > + =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 MAX77759_CHGR_REG_CHG_INT_A= ICL | > > > > + =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 MAX77759_CHGR_REG_CHG_INT_C= HGIN | > > > > + =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 MAX77759_CHGR_REG_CHG_INT_C= HG | > > > > + =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 MAX77759_CHGR_REG_CHG_INT_I= NLIM), > > > > + REGMAP_IRQ_REG(MAX77759_CHARGER_INT_2, 1, > > > > + =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 MAX77759_CHGR_REG_CHG_INT2_= BAT_OILO | > > > > + =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 MAX77759_CHGR_REG_CHG_INT2_= CHG_STA_CC | > > > > + =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 MAX77759_CHGR_REG_CHG_INT2_= CHG_STA_CV | > > > > + =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 MAX77759_CHGR_REG_CHG_INT2_= CHG_STA_TO | > > > > + =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 MAX77759_CHGR_REG_CHG_INT2_= CHG_STA_DONE), > > > > =C2=A0=C2=A0}; >=20 > You should also add the remaining bits in each register here, so that the > regulator-irq can mask them when no user exists. It will only touch the ^^^^^^^^^^^^^ regmap-irq A.