From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3150C433E9 for ; Sat, 6 Mar 2021 17:23:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A532D6501D for ; Sat, 6 Mar 2021 17:23:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231203AbhCFRXN (ORCPT ); Sat, 6 Mar 2021 12:23:13 -0500 Received: from smtp07.smtpout.orange.fr ([80.12.242.129]:39500 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230426AbhCFRW4 (ORCPT ); Sat, 6 Mar 2021 12:22:56 -0500 Received: from [192.168.1.18] ([90.126.17.6]) by mwinf5d66 with ME id d5No2400U07rLVE035NpjZ; Sat, 06 Mar 2021 18:22:53 +0100 X-ME-Helo: [192.168.1.18] X-ME-Auth: Y2hyaXN0b3BoZS5qYWlsbGV0QHdhbmFkb28uZnI= X-ME-Date: Sat, 06 Mar 2021 18:22:53 +0100 X-ME-IP: 90.126.17.6 Subject: Re: [PATCH 2/2 v2] usb: gadget: s3c: Fix the error handling path in 's3c2410_udc_probe()' To: Krzysztof Kozlowski , balbi@kernel.org, gregkh@linuxfoundation.org, nathan@kernel.org, gustavoars@kernel.org, arnd@arndb.de, ben-linux@fluff.org Cc: linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org References: <20210306142145.3490-1-christophe.jaillet@wanadoo.fr> <64c3ca58-639f-95af-35e1-7d5ba240a7c9@canonical.com> From: Christophe JAILLET Message-ID: <1fb088c0-c94c-908e-e607-796f834f45f3@wanadoo.fr> Date: Sat, 6 Mar 2021 18:22:48 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <64c3ca58-639f-95af-35e1-7d5ba240a7c9@canonical.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 06/03/2021 à 17:16, Krzysztof Kozlowski a écrit : > On 06/03/2021 15:21, Christophe JAILLET wrote: >> Some 'clk_prepare_enable()' and 'clk_get()' must be undone in the error >> handling path of the probe function, as already done in the remove >> function. >> >> Fixes: 3fc154b6b813 ("USB Gadget driver for Samsung s3c2410 ARM SoC") >> Signed-off-by: Christophe JAILLET >> --- >> v2: Fix a stupid error in the hash in Fixes: >> --- >> drivers/usb/gadget/udc/s3c2410_udc.c | 16 ++++++++++++---- >> 1 file changed, 12 insertions(+), 4 deletions(-) >> > > Do not ignore received tags but add them before sending a new version of patch. > https://lore.kernel.org/linux-samsung-soc/36ef897b-aedc-fcc3-89c8-c602d9733a9b@canonical.com/T/#t > > Also somehow your 2nd patch is not in-reply to first one. Don't change > the settings of sending patches. git format-patch and > git send-email default settings are correct. Look here: > https://lore.kernel.org/linux-samsung-soc/ > Only your patches are not threaded. > > Best regards, > Krzysztof > Hi, sorry for missing the typo in the first patch. For your other comments above, however, I use standard settings only. My patches are generated by commands like: git format-patch -2 I use cover letter only if it looks useful. In such a case, I use: git format-patch --thread --cover-letter -2 I've never seen that threading series was the rule and/or that cover letters were a must have. If I'm wrong, sorry, I was not aware of that. I'll also add the "Reviewed-by:" tag. Thx for the review and explanations. CJ