From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 70922353A7D for ; Tue, 11 Aug 2026 21:56:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786485397; cv=none; b=rLuYWhyysBji9pmdgLNMf2rTTOxh+YA6d7ybcgQDTSRuojp9muS1l0ZUuY+1iu8wPmLga0Nt31UryoQOhgOg9qj2X12bOLoz2mHGKIZp/FIqpAajxK6kk9U3mvoAMDwW/9dB61TrhUktZVvOy6eJPgC5Vx2rKdIW3MCiGWczwes= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786485397; c=relaxed/simple; bh=UfO5GTjXHvoFpUxirelLBunZxdJGiurIwuNIlIkF25U=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=BLMpk5nsnKNUQXSHKDP4okWb5cDp9N2Xr03olGTGzqn0ijJwP4UouKoWDw2eO/+r68bmt0dvzdzFsN3eqG9O0BkEq9nioJALuEXDnKPygM53dgxYM2Vf86cm8mFcUAYT7LoQfj8+8JD1+BNPyvVTtx2I4MkxtTvSpVTzcCB5PT4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=KipLW5yI; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=KIygu+4g; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="KipLW5yI"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="KIygu+4g" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1786485395; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UfO5GTjXHvoFpUxirelLBunZxdJGiurIwuNIlIkF25U=; b=KipLW5yIOCV7RV4mbfGpSkzkLA8LlY3tHBhUBGuHerNiMQwI6pHUwVnu7YDn5w1cJ0Wls2 WtWLOU2Fb5bxSAXUarPjm8nCKWRDZWRsf2IajeG1oIHBkmn3hdWoVppHpJ12dmHWrFBv1M nmpKJZSnAYpQv1C2Rf27qgz+a6rvSug= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-347-X5v0J3oGMwaR-3YU4ZJCKQ-1; Tue, 11 Aug 2026 17:56:28 -0400 X-MC-Unique: X5v0J3oGMwaR-3YU4ZJCKQ-1 X-Mimecast-MFC-AGG-ID: X5v0J3oGMwaR-3YU4ZJCKQ_1786485388 Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-90a60102d6eso2191086d6.3 for ; Tue, 11 Aug 2026 14:56:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1786485388; x=1787090188; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:content-type :references:in-reply-to:date:cc:to:from:subject:message-id:from:to :cc:subject:date:message-id:reply-to:content-type; bh=UfO5GTjXHvoFpUxirelLBunZxdJGiurIwuNIlIkF25U=; b=KIygu+4gfbHJnGx/e1z8qA1GG4DwpOJA16Zo9Pdm8ePcnU292zz9duMX2bM/LHhJ8Q bW/xWUxt5e5yCsMUdgepBmGh0GKW31y5Wm0B2upHVXK9Ovb9jNZ6ZaSHVZmT0Jljlr2N Yi6xd/QSIKQiLH+EJa3CJt7d+B0A44G3lCwjL2VlYb66LaMa4VfktN9DsowOqnhmf0VV mii7D0wXMoRaDOCFPtjvgrcZGjHYUSoIvofWPnpWUyGxc/elcRT7mm35tGbA8GhfKLAg TwAY7ccPJ07WyInKCkT5dZWnxpCerKgFQYD6UU4TF203XCr70fztg3BvRFMoe3jh/wz3 K94w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786485388; x=1787090188; h=mime-version:user-agent:content-transfer-encoding:content-type :references:in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=UfO5GTjXHvoFpUxirelLBunZxdJGiurIwuNIlIkF25U=; b=V2G2zcNgMfAXNjprz2sDAMoIicH+indWCpvAWE0s5wwIfGOUtQalu75J+7J1bRTaPf mVSAVlVp5LIs+1jq+UWONFFxXAOsylnpF9fjireG8DvxzcgoMPDavrOw0MlIDecCrsux xqZ6CeVLP7C+Rp0ERy4MO2Ip6U/CtJoTTjQZULFYsXqdHPbuBUeufbxZsHAL/X9WAnhn 8md6RVpFyV6tH5I4zR3u3ECpeSm7uxNZK9mZ0pJ7CacGChUY04FzFQ7UAPZ0W1LhEukC pJiDeOY5g6n2eP2HLibEFVAGEtOl5wJlDDBGKWeDruj2xRt3GQKiZH3gKALyn/JczwNm 7ezw== X-Forwarded-Encrypted: i=1; AHgh+RpDFZR1lEWw9A9XmSjV9yYq44/tPwZQ9xtqWjMFnFj3LZQBWeL3b0sJrAg5gOuyiGfG+Lnbucl4Mn8vtc8=@vger.kernel.org X-Gm-Message-State: AOJu0Yw2aiEzsVFuSAgLO8fSnAfAgFOPF2Q/tNhaGjrL+fauxMvkvE9w G4lSDPGXh9KYS1CeY/B0mKKkCCuS6oPq0KLxCxGEzBMyY2WUHTAIw+pjSylm8j6P5bq5Vr7ZC91 kOlmujsGs6XnzjJC5uEtA05QpOcF7s1Nu8nppaYhEMPnG62YzqJztWQFE0Lu5AWsnDw== X-Gm-Gg: AR+sD12xpNpdKdPlQw7wrPVT4h2dsBURw2RQeD///zJYTF+TUX3smOcs2zSJcTNimFG /NKEtDRj+0D5p8FfA2c1UznCRL0i7XQYjK4HteILg8K3SX+UGtg9QBO13Txs0Ss2TcxuPM9AfBs j0xkn9AogXZf9B8yQWU16GBO+kj8TcHS/Fj4COtnZqYgx1Ogs4VLMro6ugLFWZOlGaygoRTZg2c eXmfjGQdTArgl1b3Zgtk72b0LjVdduAsJ22gsNEuAoqkn/eiQI87dMgp/5c95y7x1RwrCBUIJuB MM8I0LmuUyYJBFnCi50HC7lVsjQml0VrMd8vBGznSjxpb/pcMfkmQQDR6nyRVwvvieKeJorb X-Received: by 2002:a05:6214:44a1:b0:907:5150:a2dd with SMTP id 6a1803df08f44-90a6ff95966mr2475486d6.14.1786485388251; Tue, 11 Aug 2026 14:56:28 -0700 (PDT) X-Received: by 2002:a05:6214:44a1:b0:907:5150:a2dd with SMTP id 6a1803df08f44-90a6ff95966mr2475246d6.14.1786485387868; Tue, 11 Aug 2026 14:56:27 -0700 (PDT) Received: from [192.168.8.4] ([100.0.180.93]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-90a6c26d83fsm8495466d6.4.2026.08.11.14.56.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Aug 2026 14:56:27 -0700 (PDT) Message-ID: <1fb27dc24b3d01c9a6318b0dabc0e7571adb7cda.camel@redhat.com> Subject: Re: [PATCH v2 0/3] drm/nouveau/uvmm: fix VM_BIND submit/unwind error-path bugs From: lyude@redhat.com To: Zhenhao Wan , Danilo Krummrich , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Dave Airlie Cc: dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-kernel@vger.kernel.org, Yuhao Jiang , stable@vger.kernel.org Date: Tue, 11 Aug 2026 17:56:26 -0400 In-Reply-To: <20260811-nouveau-uvmm-vmbind-fixes-v2-0-aaee4b395d04@gmail.com> References: <20260811-nouveau-uvmm-vmbind-fixes-v2-0-aaee4b395d04@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.3 (3.58.3-1.fc43) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This patch series is: Reviewed-by: Lyude Paul On Tue, 2026-08-11 at 16:46 +0800, Zhenhao Wan wrote: > Three bugs on the nouveau VM_BIND submit/unwind/cleanup error path, > all > introduced by the original VM_BIND uAPI (Fixes: b88baab82871) and all > reachable by an unprivileged render-node client: >=20 > =C2=A0 1/3 NULL deref when the unwind loop frees a never-populated > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 OP_MAP_SPARSE op's ops list. > =C2=A0 2/3 premature free of a region on a failed OP_UNMAP_SPARSE, becaus= e > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 op->reg is left set on the failure paths. > =C2=A0 3/3 a sparse region left permanently marked dirty after unwind, > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 wedging later binds over that range. >=20 > Each fix is minimal and self-contained; all are Cc: stable. >=20 > Signed-off-by: Zhenhao Wan > --- > Changes in v2: > - Add an Assisted-by: trailer to each patch; no code changes. > - Link to v1: > https://patch.msgid.link/20260811-nouveau-uvmm-vmbind-fixes-v1-0-40df1c04= 6b49@gmail.com >=20 > --- > Zhenhao Wan (3): > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 drm/nouveau/uvmm: fix NULL deref unwinding= an OP_MAP_SPARSE op > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 drm/nouveau/uvmm: fix premature region fre= e on failed > OP_UNMAP_SPARSE > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 drm/nouveau/uvmm: clear the dirty flag whe= n unwinding an > OP_UNMAP_SPARSE >=20 > =C2=A0drivers/gpu/drm/nouveau/nouveau_uvmm.c | 6 +++++- > =C2=A01 file changed, 5 insertions(+), 1 deletion(-) > --- > base-commit: ba3e43a9e601636f5edb54e259a74f96ca3b8fd8 > change-id: 20260811-nouveau-uvmm-vmbind-fixes-c2dfab359df2 >=20 > Best regards, > --=C2=A0=20 > Zhenhao Wan