From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752439AbdDCKss (ORCPT ); Mon, 3 Apr 2017 06:48:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59982 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751441AbdDCKsr (ORCPT ); Mon, 3 Apr 2017 06:48:47 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 61D18C056790 Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=hdegoede@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 61D18C056790 Subject: Re: [PATCH v2 2/2] mfd: axp20c-i2c: Select designware i2c-bus driver on x86 To: Lee Jones References: <20170329185751.25389-1-hdegoede@redhat.com> <20170329185751.25389-2-hdegoede@redhat.com> <20170403102742.xioeqirz73dqbxvm@dell> Cc: linux-kernel@vger.kernel.org From: Hans de Goede Message-ID: <1fb37842-18e1-f896-88d5-4aceacd4016d@redhat.com> Date: Mon, 3 Apr 2017 12:48:29 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170403102742.xioeqirz73dqbxvm@dell> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Mon, 03 Apr 2017 10:48:47 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 03-04-17 12:27, Lee Jones wrote: > On Wed, 29 Mar 2017, Hans de Goede wrote: > >> On x86 the axp288 PMIC provides an ACPI OPRegion handler, which must be >> available before other drivers using it are loaded, which can only be >> ensured if the mfd, opregion driver and i2c-bus drivers are built in. >> >> The opregion driver is a bool depending on MFD_AXP20X_I2C ensuring that >> it will be builtin if the opregion driver is to be enabled, add a >> select for the designware-options to ensure those get built in too. >> >> This fixes errors like these during boot: >> >> mmc0: SDHCI controller on ACPI [80860F14:00] using ADMA >> ACPI Error: No handler for Region [REGS] (ffff93543b0cc3a8) [UserDefinedRegion] >> ACPI Error: Region UserDefinedRegion (ID=143) has no handler (20170119/exfldio-2 >> ACPI Error: Method parse/execution failed [\_SB.PCI0.I2C7.PMI5.GET] (Node ffff93 >> ACPI Error: Method parse/execution failed [\_SB.PCI0.SHC1._PS0] (Node ffff93543b >> acpi 80860F14:02: Failed to change power state to D0 >> >> Signed-off-by: Hans de Goede >> --- >> Changes in v2: >> -Fix Kconfig depends and selects to fix warning reported by kbuild test robot > > Looks like there is still an issue. Yes I noticed the new kbuild test mails I will take a look at this and do a v3 as time permits. Regards, Hans > >> -Improve commit msg (add example of ACPI errors this avoids) >> --- >> drivers/mfd/Kconfig | 13 ++++++++++++- >> 1 file changed, 12 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig >> index 4eb044e..ed2616c 100644 >> --- a/drivers/mfd/Kconfig >> +++ b/drivers/mfd/Kconfig >> @@ -148,7 +148,14 @@ config MFD_AXP20X_I2C >> tristate "X-Powers AXP series PMICs with I2C" >> select MFD_AXP20X >> select REGMAP_I2C >> - depends on I2C >> + # In order for the ACPI Opregion this provides on x86 to be available >> + # the i2c-adapter driver must be builtin too, select it and its deps >> + depends on X86=n || (ACPI && HAS_IOMEM) >> + select I2C >> + select IOSF_MBI if X86 >> + select COMMON_CLK if X86 >> + select I2C_DESIGNWARE_PLATFORM if X86 >> + select I2C_DESIGNWARE_BAYTRAIL if X86 >> help >> If you say Y here you get support for the X-Powers AXP series power >> management ICs (PMICs) controlled with I2C. >> @@ -156,6 +163,10 @@ config MFD_AXP20X_I2C >> components like regulators or the PEK (Power Enable Key) under the >> corresponding menus. >> >> + Note on x86 this provides an ACPI Opregion, so this must be 'y' >> + (builtin) and not a module, as the OPregion must be available as >> + soon as possible. >> + >> config MFD_AXP20X_RSB >> tristate "X-Powers AXP series PMICs with RSB" >> select MFD_AXP20X >