From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752157AbdI3Pzf (ORCPT ); Sat, 30 Sep 2017 11:55:35 -0400 Received: from mail-dm3nam03on0052.outbound.protection.outlook.com ([104.47.41.52]:36412 "EHLO NAM03-DM3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751398AbdI3Pzc (ORCPT ); Sat, 30 Sep 2017 11:55:32 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=brijesh.singh@amd.com; Cc: brijesh.singh@amd.com, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Paolo Bonzini , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Herbert Xu , Gary Hook , Tom Lendacky , linux-crypto@vger.kernel.org Subject: Re: [Part2 PATCH v4 05/29] crypto: ccp: Add Platform Security Processor (PSP) device support To: Borislav Petkov References: <20170919204627.3875-1-brijesh.singh@amd.com> <20170919204627.3875-6-brijesh.singh@amd.com> <20170929151607.zn4lmdkyn25sczfg@pd.tnic> From: Brijesh Singh Message-ID: <1fc76eee-f25b-cd38-cc8d-0404ec94cf79@amd.com> Date: Sat, 30 Sep 2017 10:55:25 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20170929151607.zn4lmdkyn25sczfg@pd.tnic> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [70.112.153.56] X-ClientProxiedBy: DM5PR12CA0052.namprd12.prod.outlook.com (10.175.83.142) To CY1PR12MB0151.namprd12.prod.outlook.com (10.161.173.21) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 823e29a2-1017-4056-f74f-08d5081bad12 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254152)(48565401081)(2017052603199)(201703131423075)(201703031133081)(201702281549075);SRVR:CY1PR12MB0151; X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0151;3:MpygFn08n4CB1LNuyEkfWTdp0bk7euIZwsMciMo1w7YCWBRDwL1KfjJC9QoE0sXCsSXaVwdw+RZi6fZZJykpaOja2yTXBO5G0lbvun5YR6BFtbIiTgdtUqC2bbV3K4mRC3nZrDA+AJc3nQ30bB+/sCCSSQ+tm9g04TS4MA7nz9ueXKRbWSrvk5Kpxd+qViSeWM0ByymDEisclQlIaBG96pPpi9xWSMANW/wTX6u3fDb5qvnX3OomPLNdb4XRhjta;25:Sp1bzgKlC+QJjAWrkoRqIC6PQMkzrwrfuZBePyjHCIi5L2KRI655gdL49hE4se/IHXi6OsrwNJ249N8+eQTzNEYby1xeuL1/R/oeShrw/PNmQJJLIt2cou7lc9zEgbus9+VeWRRA2mEIWB+AsmPt5bi3FNAPFcHq3xCAWBrT1f9wzipEIHk0PGV+4YsAu8MK8IkGaXtRZZYc2OP3udOU6cAuoV3AZtFPdZMg0OKoTBopdtUMTv2IpQCG0YeUoxWk1cakdubdwRC6fC1JL9z1LPe5cn6jPIDL8hXQ9d9ro63331k3ayFM5ZGFpUZPmxUSesFRLBCGYStDcst3ElOMmA==;31:lf8oOn1Fy5797kINIQSPUD9yFFnt9mx2a8/CVrdcylDytpkh/hNERweseFAJggR4KcbBZs1GgCj0iXcvBFJVBapQGCx2S75DxoGgL04IEvKOxSEau3Es8PmJh3AChJMFDvyGBq1s8zl2e5SbLLdkHdVq4cevfe1rmmmlrftZ/mhnBE/c6kJz41w/w3dd0WNO1W5zXh2qXzLL0PNb1115I3/koznvFAT2E7UkT+hu2jU= X-MS-TrafficTypeDiagnostic: CY1PR12MB0151: X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0151;20:6uooyEfch0ueWE7eAsKremmFkxYtvEfKCWBC8kbM82C2q34DJmYYPD45GavuoybvSpAhuJCdjTDYjuHollFY+yZM5+rvDUzH20vaaUf6AVKY5kNYWs9NftN8OhxVe8JZ2oiwupvjQKOdVc8N+haOoMs5twsJmXYhrEd0nAFjHPXvlq37VCdz9jAp50NVp6JFdeIOsXBEl96QRPVjxjfNzhOslMpirntcbRl3TX3ASxFcYa6qwQ+YIGPEYNkM84eG7TOzSRAto5chYG3ueUVeOusVeztmI2zoby6WJX3VeldTLNpXVkYpuOIE9DLUykz9oyumGpHQfwN9rPqHbWer8Fam8xXK+zu1pxPskWwwhd/yPO4nXdI6goQHEKH9sSyCInu083xzsxWbRkV1gOdZmYDeifmfiYaUT5NMDUdBzbfwsuPkPNHJqiFcJL+XvfTDhbhxtgF2bkDmfwzNmFhEc/CfkrghNHu+PpqLqNVq7knASKgAr+Pqb42nJh1wvysB;4:5/Mqtfy1LTjnlgcTCe9GpqB/5w5/VO1KbhROo+ck1KDPPnV5aTcCIFuDNjC0Q8SVxpY2A1YgiV0YJ6m3CfPqrIi9Vwkqnljjtt9QqTUjm9Hgf6fX3VQ9hUpS9LK82gxbsbubMsGYFhdMEMT46nIafpjMajGoRvhqwTIj/nXSdNNCw9/zKFm8fB+teNw8bYIwrUpk3AshhpRH+Ng5tjhe1Po0LBmQJurxIPt9+AUf4//6tVfhBQGyb7TkqMFpFzth0h9OGt381/fOpg/kPwyFaEnWT/b061dJdc8xUKwOOt4= X-Exchange-Antispam-Report-Test: UriScan:(192374486261705); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(100000703101)(100105400095)(10201501046)(93006095)(93001095)(3002001)(6055026)(6041248)(20161123558100)(20161123560025)(20161123562025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:CY1PR12MB0151;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:CY1PR12MB0151; X-Forefront-PRVS: 0446F0FCE1 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(346002)(376002)(39860400002)(199003)(24454002)(377454003)(189002)(64126003)(58126008)(316002)(4326008)(25786009)(6246003)(478600001)(16526017)(6116002)(31696002)(83506001)(2906002)(54356999)(68736007)(76176999)(105586002)(23676002)(33646002)(229853002)(50466002)(106356001)(50986999)(189998001)(97736004)(54906003)(65826007)(6666003)(81156014)(6512007)(5660300001)(36756003)(6486002)(101416001)(31686004)(305945005)(7736002)(81166006)(15650500001)(66066001)(53936002)(6506006)(65956001)(53546010)(65806001)(47776003)(8936002)(6916009)(3846002)(8676002)(230700001)(86362001)(2950100002);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1PR12MB0151;H:Brijeshs-MacBook-Pro.local;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTFQUjEyTUIwMTUxOzIzOjFuR0lxSkl4SjUydHpKTlhoSkJjMlRvR0U4?= =?utf-8?B?OEkxeFFQOGtITlZKWjdDUEtXeXpscmpwOFpRYzZ3WENXcTlaWlMycjFuTm5s?= =?utf-8?B?ek5ITmZyQXFOWjk5TEIrVWtETGtnM3ZDNVFSS1BMM0VRNDNnWHpWdDY0Y0FB?= =?utf-8?B?NHR0ekw2OEc2cHV3VEFpUTE4alNYU0pGc1QzTGgvMVVrWWpCNTFWc09jMmc2?= =?utf-8?B?TXFPcUZFSVJUais5SXcwckdRK0xlSkppQzc5SFpnMzRLenNkdy9kVlozcGJx?= =?utf-8?B?M1dlbjJ0VUlwcUZRTno5bWtGYzFtdnN6anptcjJhU05hUHFIaWx3dFRodEMr?= =?utf-8?B?V0d4c2FsYXM5WHdGZzVOUk5lL0V1SncyU0tTY1hqRjhGM1VQTzYrc2ZZN3hS?= =?utf-8?B?eHgxa1FOTVBJcmc0S2V2dU1uUVdlZ1hnZmNyYVpFZWdOV2dHWFpqNVlYMzgw?= =?utf-8?B?cEgvYktVVlh4UHN1MjM4K1NyYWFtQUNvNUc2c3pWaitTMVlNT2pXR21WQkpY?= =?utf-8?B?NWl3Z3ZGSmlXaWZQNWFQSG15SHFvMG5Wam9Tb1FXbHR2ODNFcnAxdXh2aHF5?= =?utf-8?B?Uk5EelVJNnUvRkNTcFBRQ2ZVZXFScEdOSmgzWDZnTmpSTTA2eDJFb3JHSmdm?= =?utf-8?B?M2g5aEo3T2pUMC8xYnZnbnNqVjhKbWFHNzVQSmVjWm9DR1VzRTFQd1ZJZFk2?= =?utf-8?B?VStpMmgyWEtFRDk3SHFxVVo0cFNoSk5DNWNjSzNWVzQybDQzdWR0ZzFaQ1Fp?= =?utf-8?B?MVdpSVZ4YTg5U0gzckhyYTZ6WlFzK0NnYm42bWxWK1JiVlZUUERqNTBOdTNX?= =?utf-8?B?Z2RIR1FDZE1iYk9LY0FlM2NDWjYrb0srN2tBbVJYeDdDaVZXUlJadmZCOTVj?= =?utf-8?B?eWJZTm1kdDEwSGdMOEJpRGxrWGV5QUZnUStIT0pYY2h0YmM5eFkzV25Jd2lq?= =?utf-8?B?K05IWHJjSjJNdGx3cWJBV1BlM1o2S0dvNktGWW9VbUFVTGhCYzBWNWtybmtj?= =?utf-8?B?TGVja2FBRUhhNWRSaDVkL0phR3I3cTNNM0hLbU54NUQ1ZWtUS29PNTY3K0wx?= =?utf-8?B?a0UyUjZURXB0L0o0NzIyR2ZTQnA1YXlkNXYxSTc5eSs1amxIenVKSXN2MHll?= =?utf-8?B?L0xLQU5XbU5oVUR3VXkxbmpIOEpteTZJcHc4VGoraG9kWS9WZlg4ZHBIK3RE?= =?utf-8?B?a2xOd291N2NibUhxQjZldHdKQng1TDFUaW5yVDk3eWNOMllsYkY2UnJZWGxL?= =?utf-8?B?dnNudFBwazJzd2RzWVJCUGllWjUrL3FIVWZXdy9FdFBjdnM2MHNXRWhTeUpN?= =?utf-8?B?TzF5V0RCa2wvYnJ6TUF5Ui9RdVREL1BrK0F1Q3ZRKzhLdkdnSzd2Wjc1bmdl?= =?utf-8?B?Q3N5OE9tS255Q3d2bVMzMHA3MEtvRVMxZk5HdHdXYldRZWEwOWk3R2FkdnVm?= =?utf-8?B?ajZZcG9qQW1NYmJRTFZ5c2s4MTNpWDNRaUs1V1FlMHdxOElKT2RJanJQSjR1?= =?utf-8?B?T2JwWHRJNGIwMDZVVUVmeFUvZUR2VTJJMjN0b0ZGMGZZNncvdGpBTGI1MlpE?= =?utf-8?B?cER0eHQ5SkhWRUNxS3JlRW9XSEU1K1UvU21rbmI5ZGpuVDQwQ0p4SkNPM1gx?= =?utf-8?B?N3NzTkt4QUptYmsyWmxPN3NoZ3FKbmxuOEdWSkpySXpCUzExaEE1cGJ2ODFu?= =?utf-8?B?SGoxS1RzNXlZNi9NSC9NYUZ0QzlLUkZxbURSM01UVnZYdVhjZzZVbDh5SGc1?= =?utf-8?B?ajU1ZzJpYW9EWG16TDdGaEh1dzlqdFVEMUNzbjZQRjBWdmZVMTJhMWRjQUMy?= =?utf-8?B?bnFDWG1vWjJ2dFNoeEl3MEZKUDJsWS9TT204dVI1RS9CQmJJeGwzTU1wUHl1?= =?utf-8?Q?jT7K8q0ReYj/2n+8QacVoEEqw/EUfNYs?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0151;6:e11VDOyX2bt6pwnRVk0g58+k3YFEDvZV/gTCWMPXM93w188fBOH+z7sgVTA4qqrwLxAkoDgCgmbHQyhCfEMeVzqXkfVk5rn3cPr4l3DZRLE88cBuxFezj136XLlDq9bxuUC0zzlx9UVBFBeALgg+eiItpG2T4qanvjAMgBXEkRBTcSHx7tuIQ+fy3mmIOu1dhT8i4Eb0w6rgA1Er0Xb/lzR4qdZvSRyEHm0QBFX9sObaY72fdG9am9saqphZ2yfu9I5ET8SiX6lQnPHJdmKCO+IkYfrzTVs1PGIOFyn8+Mam/zVbIVWeS4jYhPLhJHMtPJi4HWPNmIkfFlzNzqHD2A==;5:GUOLmb5pyiWnmH3LzAG4KfOJhV1DFaHo25wnAJuM2vZri/CyQ9aYE58sv9GWzG2l3BTsFh1k4iTGHaVIv2ug2zCC5Vkbt9G/fWjeeF9QUzmg3HrbCMKSl++WCaRXTbkkB+qpmI54nNznCOoxdJH7b7gQrIQjvWBh3lm+3qWzSCU=;24:6WV8I2FnSzH/uXPFjFN3tHaC3lEDIAtImlpSl6oqwLkPAjZUihRCAXjvsmcFolPMncv+cQXOZzLa/Fio41kMU47mtt9w66O6AcCKRMTbKCo=;7:9AKI6p0zYqYAx702bdBu4nd2/Q4D3VvWiFM+isCqLJqPU6j/m2CiPvYgo1AIHRTA5A72qBqD+6lgBwNdcKBCogWEn0HER0mcRCku06jrkmsvEk56SJnSydeJj+7Zj5EaItvS0679RX2uyw2XFr1T20+7c199/OIwiQyTMNVmPN5oW6zEDZI+8M/nTT/wiZ42EHbOdehedTKvSKOA8t1alcLbuSRTtysGMmK0e4I5r8c= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0151;20:n+rbKKuJKU1VkiO+IPTgHcBeeUtF9p5cm1jC4jN3PzKSDql9mgeODZxah+eDiHNDT2iGejDj79HkXyVZu6XR/PNe2K1cKadzRbrzO+M/UiQmBQ8P6itKKLqToT2rWgv9KTQ9qcPi+Zczi890TL75NG4nmp/moiC3U6P6BWBJYQbEaVUmmrS79w4Gxlu/QyxgmCSdeSmIDaG1BQN7hJyq3a3IpsVAesJaCdOZluv2Xhl5gG6DxHMUDUl0RgvxAeuJ X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Sep 2017 15:55:29.5196 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR12MB0151 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/29/17 10:16 AM, Borislav Petkov wrote: ... > + >> +config CRYPTO_DEV_SP_PSP >> + bool "Platform Security Processor (PSP) device" >> + default y >> + depends on CRYPTO_DEV_CCP_DD > So this last symbol CRYPTO_DEV_CCP_DD is default m and it doesn't depend > on anything. And I'm pretty sure it should depend on CPU_SUP_AMD as this > is AMD-specific hw. You can add that dependency in a prepatch. CRYPTO_DEV_CCP_DD is supported on aarch64 and x86. Whereas the PSP interface I am adding is available on x86 only hence its safe to add add depend on CPU_SUP_AMD for CRYPTO_DEV_SP_PSP. > And what happened to adding dependencies on CONFIG_KVM_AMD? Or can you > use the PSP without virtualization in any sensible way? Yes its very much possible. The SEV FW provides two sets of commands 1) platform certificate management and 2) guest management The platform certificate management commands is used outside the CONFIG_KVM_AMD. -Brijesh