From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB1C5352C49 for ; Fri, 9 Jan 2026 08:52:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767948746; cv=none; b=bDihtPoYRrokGHVY3IDklyc5h6SDMWepkGrQ/aZ9udWrwSBZZb/xyOH1ijtV8XnOnR3IrCSre3y7Gzmff3A88ygZzxEjRhtWtLkXBaM3PoPH4bVlw00VHBjealoCStSchBvcmc5j+0qkw9wVw3NE5b0rIFOU547gOe+qdWyy4Ro= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767948746; c=relaxed/simple; bh=E3NMqM+A8CEVRBGBT/M+cmeErAmFmkV5CGQbz1hlnlY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=XFEi2l6wCcgBeZvc4naPfQ4Lfa97f0BDgXRg3z20b0Wwrjb4nOwK7EstVdQeSs21eoa5bIb1j5B0njujKCcVoRjd04xl9u/SG/MEaqBGpcb8TMDs+0YVbZ1BUU3y8A/Yb6/ekujpfErIIYMTMDbNrnKkqUZ9Pxy8OUQ0mu90t9w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=cn43pDkx; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=on/i7mri; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="cn43pDkx"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="on/i7mri" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1767948739; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qd3TxPrGEwbS4GVg26E8iOv4W5rh/N/xdaEX+6CIF7k=; b=cn43pDkx/+5Vom4wBYO5Dd2FsQsuSMs4s84XTHK6Ezp/gKGjDodgb4JN/XaiD5SNWAt5PQ uJD9b4rcHemVw9G+SvAkLLA5ag08c2LrueszAzTZa3mtkyGSO5OtjgHxQzFWC2yi1DlN3u wKOeTzv8+g1LXx10VXs7ELkL3HEhZOM= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-628-xKb1qsOMNnq2yyyy2NJObg-1; Fri, 09 Jan 2026 03:52:16 -0500 X-MC-Unique: xKb1qsOMNnq2yyyy2NJObg-1 X-Mimecast-MFC-AGG-ID: xKb1qsOMNnq2yyyy2NJObg_1767948735 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-47d28e7960fso43787485e9.0 for ; Fri, 09 Jan 2026 00:52:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1767948735; x=1768553535; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=qd3TxPrGEwbS4GVg26E8iOv4W5rh/N/xdaEX+6CIF7k=; b=on/i7mriqFGTWZYVvAc0CbJ+AJCpYNvEpDYWPKqMHf6E+JfLX9Zn2X2Dv9xm+6ogoL u2aRDzNbOVnnr2NvkAmwiCT547u1qgSdAmBo+3n6z8VsDyuh3LOdlW9TN2zHN0dp78FU cK316FDu6EBtIDkiO+abtBB6ePZc2yCG+bdD78+V206MV5nkZFa7rhBK8GUat36aopxr Jqi0huRQwX9XZ3Ylosl4CKjLpDwK1URIEap0RmtGMBU0iDEzWhg6E7YcNh8clE2j+l0Y iSAUsatvaJS87FLez3LCS3C/vme+SfjOKL6IKa2c1W5mzKxJtvcebzpCYsy1gAbNoM44 +pLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767948735; x=1768553535; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=qd3TxPrGEwbS4GVg26E8iOv4W5rh/N/xdaEX+6CIF7k=; b=QxZ0ZSRliFPbFDK28jC/8IVe1qPcEFQwtFcK1ju0IqXrxwcyXdyPg4XXo2OHTnzUtk 6RL8jRudxk9A676/CtBCE95RTPZ1alIWD9SDqePon6nk16o6WInQGYVQjVfpKo6l1iVE aXj+aklD8cv8J3okitqSEWCaIEBzWiKcysVnyC73Pa+rjP+8OMHPkRQOHn0i3MJpQlei RXt83r1PTT2ApBTmIvkc+Odfv8ulN+YkJBvZCIynLbG1TBYwTTrUyzRR0U3Pwk9/RJSW 8XZTvCcC9wJiSBLa22c659EXswPWyzAJNyilq4RM200SoQIctDVlEk9xejDLHxBXvOEt xl2A== X-Forwarded-Encrypted: i=1; AJvYcCVY3usZCulUR3KFjp+G3fU+dAxd6qvabEAO8aS9eDmESPnJROnt55hwwhYBTJ67ifc7yCoLTyW+7J9sGu0=@vger.kernel.org X-Gm-Message-State: AOJu0YzYeMw1YPoLDlajyKlxpajlc8cXaQPLPtImAX9i96RM0tJUgaZ9 3/JS5/B3LJbJYFRIpG42RUwS8r2G1PQbZjfKW3bIIf4dxlQo35mcHg5voObXdxdjwyfCd9S6dc8 lZUFuVrtug1ZHg/pKV9Zr9qYynbKsyGgfM0W9F2mpuRusRxR8GEJcw701dCcD/ZkP X-Gm-Gg: AY/fxX6tIqJjoldy8kTpYGKdyfHORJLCAVKg6QyMZ8XuV5y3HBQbAmAvV1X2Ir88v8P ZLbZJTKYKeKJWznh9iF+iHphZTClRcygNyKiLX4+1IxatIuwYs0ZVDPAD1NVcuuie3PJforaj1+ FcSoKjO2+CZAB9bo2SfHRkRnitLvVnK1YSwZj735ruiDiuljrOCubiHPDrPO0T5kJeYyd8wyxCI ngO3WwZN7KGnNB8J99g7DXzr88oKzfpmoE3i5I1iQZYFGJDYuFLY5Hj7Y4KkpiumwMbTGkdDOQT eTFwrTYrv88Y84CENK42eL4o0zmaSFsmQ/fi9pRRqpd7EZJSSTYxNXT8DNuJYevzsvld6bwczy3 pW+3whSsH4bAmiJ1h8cac8WYWrh4O6QIdteE0mW2tMy7r X-Received: by 2002:a05:600c:4ed4:b0:471:d2f:7987 with SMTP id 5b1f17b1804b1-47d84b40ae5mr105450685e9.26.1767948734930; Fri, 09 Jan 2026 00:52:14 -0800 (PST) X-Google-Smtp-Source: AGHT+IH+OFAHyxfPesOUruCB2DRAXrjgnW+eYi4VghBgkUB+GFBY8GQZwQg5dZXLwXvSMhkSZcxTww== X-Received: by 2002:a05:600c:4ed4:b0:471:d2f:7987 with SMTP id 5b1f17b1804b1-47d84b40ae5mr105448925e9.26.1767948734236; Fri, 09 Jan 2026 00:52:14 -0800 (PST) Received: from [192.168.0.135] (185-219-167-205-static.vivo.cz. [185.219.167.205]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47d871a1e11sm55516855e9.19.2026.01.09.00.52.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Jan 2026 00:52:13 -0800 (PST) Message-ID: <1fd29f17-a0e9-4032-8349-a85c9659a5f2@redhat.com> Date: Fri, 9 Jan 2026 09:52:12 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH bpf-next v4 0/4] Use correct destructor kfunc types To: Sami Tolvanen Cc: Vadim Fedorenko , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Eduard Zingerman , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Jamal Hadi Salim , Cong Wang , Jiri Pirko , Network Development , LKML , bpf , Alexei Starovoitov References: <20251126221724.897221-6-samitolvanen@google.com> <6482b711-4def-427a-a416-f59fe08e61d0@redhat.com> From: Viktor Malik Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 1/5/26 17:16, Alexei Starovoitov wrote: > On Mon, Jan 5, 2026 at 5:56 AM Viktor Malik wrote: >> >> On 11/26/25 23:17, Sami Tolvanen wrote: >>> Hi folks, >>> >>> While running BPF self-tests with CONFIG_CFI (Control Flow >>> Integrity) enabled, I ran into a couple of failures in >>> bpf_obj_free_fields() caused by type mismatches between the >>> btf_dtor_kfunc_t function pointer type and the registered >>> destructor functions. >>> >>> It looks like we can't change the argument type for these >>> functions to match btf_dtor_kfunc_t because the verifier doesn't >>> like void pointer arguments for functions used in BPF programs, >>> so this series fixes the issue by adding stubs with correct types >>> to use as destructors for each instance of this I found in the >>> kernel tree. >>> >>> The last patch changes btf_check_dtor_kfuncs() to enforce the >>> function type when CFI is enabled, so we don't end up registering >>> destructors that panic the kernel. >> >> Hi, >> >> this seems to have slipped through the cracks so I'm bumping the thread. >> It would be nice if we could merge this. > > It did. Please rebase, resend. @Sami, could you please rebase and resend? Thanks! >