From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.4 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A684FC64E7C for ; Tue, 27 Oct 2020 15:16:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6D9B92225C for ; Tue, 27 Oct 2020 15:16:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1795981AbgJ0PPe (ORCPT ); Tue, 27 Oct 2020 11:15:34 -0400 Received: from gecko.sbs.de ([194.138.37.40]:46295 "EHLO gecko.sbs.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2508584AbgJ0PMz (ORCPT ); Tue, 27 Oct 2020 11:12:55 -0400 Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by gecko.sbs.de (8.15.2/8.15.2) with ESMTPS id 09RFCk7M000972 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 27 Oct 2020 16:12:46 +0100 Received: from [139.25.68.37] ([139.25.68.37]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id 09RFCkiQ015696; Tue, 27 Oct 2020 16:12:46 +0100 Subject: Re: [PATCH 0/7] gpio: exar: refactor the driver To: Andy Shevchenko , Bartosz Golaszewski Cc: Sudip Mukherjee , Linus Walleij , "open list:GPIO SUBSYSTEM" , Linux Kernel Mailing List , Bartosz Golaszewski References: <20201026141839.28536-1-brgl@bgdev.pl> From: Jan Kiszka Message-ID: <1fd4d69b-4d64-05e5-45a3-b2182fb2d207@siemens.com> Date: Tue, 27 Oct 2020 16:12:46 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 26.10.20 15:46, Andy Shevchenko wrote: > On Mon, Oct 26, 2020 at 4:22 PM Bartosz Golaszewski wrote: >> >> From: Bartosz Golaszewski >> >> I just wanted to convert the driver to using simpler IDA API but ended up >> quickly converting it to using regmap. Unfortunately I don't have the HW >> to test it so marking the patches that introduce functional change as RFT >> and Cc'ing the original author. > > +Cc: Jan, AFAIR their devices are using Exar UART. > Thanks for CC'ing. I cannot promise testing this soon, but I will try my best. Jan >> Bartosz Golaszewski (7): >> gpio: exar: add a newline after the copyright notice >> gpio: exar: include idr.h >> gpio: exar: switch to a simpler IDA interface >> gpio: exar: use a helper variable for &pdev->dev >> gpio: exar: unduplicate address and offset computation >> gpio: exar: switch to using regmap >> gpio: exar: use devm action for freeing the IDA and drop remove() >> >> drivers/gpio/Kconfig | 1 + >> drivers/gpio/gpio-exar.c | 155 +++++++++++++++++++-------------------- >> 2 files changed, 77 insertions(+), 79 deletions(-) >> >> -- >> 2.29.1 >> > -- Siemens AG, T RDA IOT Corporate Competence Center Embedded Linux