From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75D55EB64D9 for ; Mon, 19 Jun 2023 19:50:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230317AbjFSTuU (ORCPT ); Mon, 19 Jun 2023 15:50:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50252 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229682AbjFSTuS (ORCPT ); Mon, 19 Jun 2023 15:50:18 -0400 Received: from lelv0143.ext.ti.com (lelv0143.ext.ti.com [198.47.23.248]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9F8E711B; Mon, 19 Jun 2023 12:50:10 -0700 (PDT) Received: from fllv0035.itg.ti.com ([10.64.41.0]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 35JJnfgk030920; Mon, 19 Jun 2023 14:49:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1687204181; bh=PoKOvK7usjm1ob7WNxMkDZSniex+haYHBcVoexZNQpY=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=gkVuW8nroY/jLzBkPeso8rv0zNpCv2WKc0KePPKsMJc0nOqosns8qhV3s3tINiQWp 1Nf85Abw/kxC3pWvbqeedeLXbgGBN6pHKNADNRjQ7nkk/YS4FHTwkcfBoPCIzEcFIs F4MW/K3klMmOJxz+V9v5HlbVcLzT7wa2Eq1HR8lY= Received: from DFLE106.ent.ti.com (dfle106.ent.ti.com [10.64.6.27]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 35JJnfLo053840 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 19 Jun 2023 14:49:41 -0500 Received: from DFLE101.ent.ti.com (10.64.6.22) by DFLE106.ent.ti.com (10.64.6.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Mon, 19 Jun 2023 14:49:40 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DFLE101.ent.ti.com (10.64.6.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Mon, 19 Jun 2023 14:49:40 -0500 Received: from [10.247.25.76] (ileaxei01-snat2.itg.ti.com [10.180.69.6]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 35JJne4A031011; Mon, 19 Jun 2023 14:49:40 -0500 Message-ID: <1fd76d67-0839-1b82-5b6a-d3fc75a240f8@ti.com> Date: Mon, 19 Jun 2023 14:49:40 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH net v1] Revert "net: phy: dp83867: perform soft reset and retain established link" Content-Language: en-US To: Andrew Lunn , Francesco Dolcini , Siddharth Vadapalli CC: Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , , Francesco Dolcini , Geet Modi , References: <20230619154435.355485-1-francesco@dolcini.it> <5563611e-5354-42fc-b33f-b1b4945e71de@lunn.ch> From: "Bajjuri, Praneeth" In-Reply-To: <5563611e-5354-42fc-b33f-b1b4945e71de@lunn.ch> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/19/2023 11:30 AM, Andrew Lunn wrote: > On Mon, Jun 19, 2023 at 05:44:35PM +0200, Francesco Dolcini wrote: >> From: Francesco Dolcini >> >> This reverts commit da9ef50f545f86ffe6ff786174d26500c4db737a. >> >> This fixes a regression in which the link would come up, but no >> communication was possible. >> >> The reverted commit was also removing a comment about >> DP83867_PHYCR_FORCE_LINK_GOOD, this is not added back in this commits >> since it seems that this is unrelated to the original code change. >> >> Cc: Praneeth Bajjuri >> Closes: https://lore.kernel.org/all/ZGuDJos8D7N0J6Z2@francesco-nb.int.toradex.com/ >> Fixes: da9ef50f545f ("net: phy: dp83867: perform soft reset and retain established link") >> Signed-off-by: Francesco Dolcini > > There has been plenty of time given for somebody to investigate this > regression, and nothing has happened. So i agree, lets revert it. > > Reviewed-by: Andrew Lunn Agreed to revert. Reviewed-by: Praneeth Bajjuri > > Andrew