From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f181.google.com (mail-dy1-f181.google.com [74.125.82.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 738AF3FF8A2 for ; Fri, 1 May 2026 16:28:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777652934; cv=none; b=kZc1+UGQ4lF19YA3h3Bka8GHAn3IjiwbWOw/K7eDNXbjPJaIkVwcwUZFD1OLoUiAbpfSNm39rbxfL1MKavFVpToKgOIm7IBFvVxzogbfQZIYGaRL1p6W6ZkROmBi9kVQMbkTi2VkGb9gT3QKklqt7tRp3IEjK+hOBpKb1z3VELA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777652934; c=relaxed/simple; bh=hB419DZqwfY2q35KZGxZWsJnMWCpetjqbhyF8YbS8rc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=sYDFjqF8TrSo06+sYr788CBruIovzU6OU6zLwE/xGxqBn9qwPdCC+y/ok9IhJd11Wk14KXFqZrRdqr+/r4J07zHf25GqV5n12pwT2I/iwVXKxPEvvslnCVcO1PrNiJAh0ZPd29kt4ZCjGUK4jFVDDRsttSFt/tl6MZ0/cthG6SA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=sGbCOsk1; arc=none smtp.client-ip=74.125.82.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="sGbCOsk1" Received: by mail-dy1-f181.google.com with SMTP id 5a478bee46e88-2e221a71e19so2815231eec.0 for ; Fri, 01 May 2026 09:28:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777652923; x=1778257723; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:from:to:cc:subject:date:message-id:reply-to; bh=fer6cYUwO7XAK+aFDpBnPHY14BNIPlazBoLp2o7Ghzw=; b=sGbCOsk1JzpV3o/edhjn5kYQb3ICFEiL4+b7UL7woxR60kCgajsKokTQwvepkJiBcb KQTbBckvmFdZ7cmuBNQkfUpoiQDCs+MqpK81bIt6CmYfEwaJUS+MpqUArlv/M6zUZHEU 70IKByyhmmo+AqSdLrkJWqJPuCqzj7Htd7q93kg2PEMMATTynYJFn5P79lyX1fAHV3Ku scwFeE4w0iFB5AuUxtJoCo9WDPvKimeCfGcRNYk1rrqvc0efVPZzMEnZu6kmf2lbuaKV Viud5j+pUJ0ykfSQ/QFssaK4+ZG0s7HCbrG3tq884LUjulelrR0JIBuc6VJ3dRtKrRx/ Tv7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777652923; x=1778257723; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fer6cYUwO7XAK+aFDpBnPHY14BNIPlazBoLp2o7Ghzw=; b=BN6hFc0oH1duH56VrXX035FTfp7VZIRot4zmRO3IO17QqZu1HtFQ1OURafWaTpum0u TCTZP92rbbfC8xqRDB4NHHb3SUXAYA5uQP5fPn4G2X6IaAO4R0doEHKGCQjBvR6sL3wk U7VmuTV4R8XAAB+Bp6I8JqO6skCz7s6aH2O2Pc59Kza83Q9uB0Ryn7s0pCLAWX5PJl/X blLpEhvCl31Jf25PDoJTJ3YO5Zq7G3quWO7U5VyA0PyBr4T6JfBC+NzBJrDYjlQCj9sZ IgsY2UhdbuIw3xxBDWv0CO25OagZplfkaswLard3PVDQoYviYgRepb5MHWZSxPkbA39l iRcg== X-Forwarded-Encrypted: i=1; AFNElJ+/cR3vIG7AKoBUdKke9+egS1MnqJ8dUXXIMtDE+v99IVn5IrHtSkZB8YdDZN4P+gD6EF61cjJc6rW6W/A=@vger.kernel.org X-Gm-Message-State: AOJu0YzINiGaa1etTE90jBdhdATEM98LclUdFBT+E3k0sEeUA6tIBKhQ EQmpAw7jUNPofVBxFP+M8Z4jqYmks2gdM1T1loKYGsIu0oJM8GSW+KyP X-Gm-Gg: AeBDietLkM6118tJdAlyGuiHEyQLluXKDb1yRV/wUPc4Z5vI9Y/dSsYrSVFBhx4Orbm YgkytNl1KL68ed0GsMv1p99qvptQw9A3V+B7oQ6M40/t9hVayY5/gIc14mCHkm0bnhA+3KJL9Sr eSHQJ1jOPLuzcpQ9kI91o+MHkJE8Img6Yvukb3E/Uxws1h5hQr7CZ1hshjmu6fzfyLNNjiHggY6 ZONzP8WvvIrw322K3wQ/DkE8suUlHuEvW9oXj6bZ5jhFcLBVJ2b5BNU93GWQOQ+67F5GecypEOE 6xv3qK1F+ovsDaRacK7PSCBVYtF2mzM5V02RDI/+iGBoe1G+AxI3R7SWmEAB7eejtJMVftkqtVA Onqe2xZE3TuWJDhgQdv4QEMhu0SqNpwxrMml4upKhkIkXbnSoqjA+rkkIEaCSy3SgY4+KezfJbt qbHZCaK0E7Voo4sDlvXvCyPkd51mBy1/q3CTZO7vcFcBLsEYR3wtXMbBfcOgaFV1TVSDMZDLrif UnNgCNNjVGYRt0x8fcz+g== X-Received: by 2002:a05:7301:38a8:b0:2e2:d94d:6186 with SMTP id 5a478bee46e88-2efb94ab893mr32369eec.11.1777652922758; Fri, 01 May 2026 09:28:42 -0700 (PDT) Received: from ?IPV6:2600:1700:e321:62f0:da43:aeff:fecc:bfd5? ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2ee3537d300sm6511627eec.0.2026.05.01.09.28.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 01 May 2026 09:28:41 -0700 (PDT) Sender: Guenter Roeck Message-ID: <1fdad9e4-8a6e-4d17-912a-44e12f33c7eb@roeck-us.net> Date: Fri, 1 May 2026 09:28:40 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 1/3] hwmon: (ads7871) Fix endianness bug in 16-bit register reads To: David Laight , Tabrez Ahmed Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org, shuah@kernel.org, me@brighamcampbell.com, Sashiko References: <20260501023530.31160-1-tabreztalks@gmail.com> <20260501023530.31160-2-tabreztalks@gmail.com> <20260501094902.05ce6d37@pumpkin> Content-Language: en-US From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAmgrMyQFCSbODQkACgkQyx8mb86fmYGcWRAA oRwrk7V8fULqnGGpBIjp7pvR187Yzx+lhMGUHuM5H56TFEqeVwCMLWB2x1YRolYbY4MEFlQg VUFcfeW0OknSr1s6wtrtQm0gdkolM8OcCL9ptTHOg1mmXa4YpW8QJiL0AVtbpE9BroeWGl9v 2TGILPm9mVp+GmMQgkNeCS7Jonq5f5pDUGumAMguWzMFEg+Imt9wr2YA7aGen7KPSqJeQPpj onPKhu7O/KJKkuC50ylxizHzmGx+IUSmOZxN950pZUFvVZH9CwhAAl+NYUtcF5ry/uSYG2U7 DCvpzqOryJRemKN63qt1bjF6cltsXwxjKOw6CvdjJYA3n6xCWLuJ6yk6CAy1Ukh545NhgBAs rGGVkl6TUBi0ixL3EF3RWLa9IMDcHN32r7OBhw6vbul8HqyTFZWY2ksTvlTl+qG3zV6AJuzT WdXmbcKN+TdhO5XlxVlbZoCm7ViBj1+PvIFQZCnLAhqSd/DJlhaq8fFXx1dCUPgQDcD+wo65 qulV/NijfU8bzFfEPgYP/3LP+BSAyFs33y/mdP8kbMxSCjnLEhimQMrSSo/To1Gxp5C97fw5 3m1CaMILGKCmfI1B8iA8zd8ib7t1Rg0qCwcAnvsM36SkrID32GfFbv873bNskJCHAISK3Xkz qo7IYZmjk/IJGbsiGzxUhvicwkgKE9r7a1rOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAmgrMyQFCSbODQkACgkQyx8mb86fmYHlgg/9 H5JeDmB4jsreE9Bn621wZk7NMzxy9STxiVKSh8Mq4pb+IDu1RU2iLyetCY1TiJlcxnE362kj njrfAdqyPteHM+LU59NtEbGwrfcXdQoh4XdMuPA5ADetPLma3YiRa3VsVkLwpnR7ilgwQw6u dycEaOxQ7LUXCs0JaGVVP25Z2hMkHBwx6BlW6EZLNgzGI2rswSZ7SKcsBd1IRHVf0miwIFYy j/UEfAFNW+tbtKPNn3xZTLs3quQN7GdYLh+J0XxITpBZaFOpwEKV+VS36pSLnNl0T5wm0E/y scPJ0OVY7ly5Vm1nnoH4licaU5Y1nSkFR/j2douI5P7Cj687WuNMC6CcFd6j72kRfxklOqXw zvy+2NEcXyziiLXp84130yxAKXfluax9sZhhrhKT6VrD45S6N3HxJpXQ/RY/EX35neH2/F7B RgSloce2+zWfpELyS1qRkCUTt1tlGV2p+y2BPfXzrHn2vxvbhEn1QpQ6t+85FKN8YEhJEygJ F0WaMvQMNrk9UAUziVcUkLU52NS9SXqpVg8vgrO0JKx97IXFPcNh0DWsSj/0Y8HO/RDkGXYn FDMj7fZSPKyPQPmEHg+W/KzxSSfdgWIHF2QaQ0b2q1wOSec4Rti52ohmNSY+KNIW/zODhugJ np3900V20aS7eD9K8GTU0TGC1pyz6IVJwIE= In-Reply-To: <20260501094902.05ce6d37@pumpkin> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 5/1/26 01:49, David Laight wrote: > On Fri, 1 May 2026 08:05:28 +0530 > Tabrez Ahmed wrote: > >> The ads7871_read_reg16() function relies on spi_w8r16() to read the >> 16-bit sensor output. The ADS7871 device transmits the Least Significant >> Byte (LSB) first. >> >> On Little-Endian architectures, spi_w8r16() correctly reconstructs the >> 16-bit value. However, on Big-Endian architectures, the byte swapping >> causes the first received byte (LSB) to be placed in the most significant >> byte of the u16, resulting in corrupted voltage readings. >> >> Replace spi_w8r16() with a manual spi_write_then_read() into a byte array, >> and safely reconstruct the integer using get_unaligned_le16() to ensure >> correct behavior across all architectures. Additionally, use a u8 >> variable for the command byte to ensure the correct instruction is >> transmitted on Big-Endian systems. >> >> Reported-by: Sashiko >> Closes: https://sashiko.dev/#/patchset/20260418034601.90226-1-tabreztalks@gmail.com >> Signed-off-by: Tabrez Ahmed >> --- >> drivers/hwmon/ads7871.c | 14 +++++++++++--- >> 1 file changed, 11 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/hwmon/ads7871.c b/drivers/hwmon/ads7871.c >> index 9bfdf9e6bcd77..d77eff430935b 100644 >> --- a/drivers/hwmon/ads7871.c >> +++ b/drivers/hwmon/ads7871.c >> @@ -59,9 +59,9 @@ >> #include >> #include >> #include >> +#include >> >> #define DEVICE_NAME "ads7871" >> - >> struct ads7871_data { >> struct spi_device *spi; >> }; >> @@ -77,9 +77,17 @@ static int ads7871_read_reg8(struct spi_device *spi, int reg) >> static int ads7871_read_reg16(struct spi_device *spi, int reg) >> { >> int ret; >> + u8 tx_cmd; >> + u8 rx_buf[2]; >> + >> reg = reg | INST_READ_BM | INST_16BIT_BM; >> - ret = spi_w8r16(spi, reg); >> - return ret; > > Isn't it enough to just byteswap the result? so: > return le16toh(ret); > The whole thing can be: > return le16toh(spi_w8r16(spi, reg | INST_READ_BM | INST_16BIT_BM)); This would convert error codes to some random value. Guenter