mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Igor Russkikh <irusskikh@marvell.com>
To: Colin King <colin.king@canonical.com>,
	Egor Pomozov <epomozov@marvell.com>,
	Igor Russkikh <Igor.Russkikh@aquantia.com>,
	"David S . Miller" <davem@davemloft.net>,
	Dmitry Bezrukov <Dmitry.Bezrukov@aquantia.com>,
	Sergey Samoilenko <Sergey.Samoilenko@aquantia.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Cc: "kernel-janitors@vger.kernel.org"
	<kernel-janitors@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [EXT] [PATCH][next] net: aquantia: fix unintention integer overflow on left shift
Date: Mon, 28 Oct 2019 09:45:32 +0000	[thread overview]
Message-ID: <1fe5fdc0-ea7a-6a4a-6453-4115adf6e2ba@marvell.com> (raw)
In-Reply-To: <20191025115811.20433-1-colin.king@canonical.com>


> From: Colin Ian King <colin.king@canonical.com>
> 
> Shifting the integer value 1 is evaluated using 32-bit
> arithmetic and then used in an expression that expects a 64-bit
> value, so there is potentially an integer overflow. Fix this
> by using the BIT_ULL macro to perform the shift and avoid the
> overflow.
> 
> Addresses-Coverity: ("Unintentional integer overflow")
> Fixes: 04a1839950d9 ("net: aquantia: implement data PTP datapath")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Reviewed-by: Igor Russkikh <irusskikh@marvell.com>


  reply	other threads:[~2019-10-28  9:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-25 11:58 Colin King
2019-10-28  9:45 ` Igor Russkikh [this message]
2019-10-29 17:48 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1fe5fdc0-ea7a-6a4a-6453-4115adf6e2ba@marvell.com \
    --to=irusskikh@marvell.com \
    --cc=Dmitry.Bezrukov@aquantia.com \
    --cc=Igor.Russkikh@aquantia.com \
    --cc=Sergey.Samoilenko@aquantia.com \
    --cc=colin.king@canonical.com \
    --cc=davem@davemloft.net \
    --cc=epomozov@marvell.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®