From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1764279AbdJQUrj (ORCPT ); Tue, 17 Oct 2017 16:47:39 -0400 Received: from mail-vk0-f65.google.com ([209.85.213.65]:51688 "EHLO mail-vk0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759254AbdJQUri (ORCPT ); Tue, 17 Oct 2017 16:47:38 -0400 X-Google-Smtp-Source: ABhQp+RfTA76h7YW0GL8iZsKe4H5h0RUqsgXUsPRfPMawY8l+GHsNJW2xdEsFD18BmWw5kAF3Kbspw== Reply-To: minyard@acm.org Subject: Re: [PATCH][ipmi-next] ipmi_si: fix memory leak on new_smi To: Colin King , openipmi-developer@lists.sourceforge.net Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org References: <20171017155452.24807-1-colin.king@canonical.com> From: Corey Minyard Message-ID: <1fe921ca-73d9-6ccf-d7dc-8174340369ae@acm.org> Date: Tue, 17 Oct 2017 15:47:34 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171017155452.24807-1-colin.king@canonical.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/17/2017 10:54 AM, Colin King wrote: > From: Colin Ian King > > The error exit path omits kfree'ing the allocated new_smi, causing a memory > leak. Fix this by kfree'ing new_smi. Thanks, queued for the next release. -corey > Detected by CoverityScan, CID#14582571 ("Resource Leak") > > Fixes: 7e030d6dff71 ("ipmi: Prefer ACPI system interfaces over SMBIOS ones") > Signed-off-by: Colin Ian King > --- > drivers/char/ipmi/ipmi_si_intf.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c > index 55e0c42bee4d..4c16af64f73a 100644 > --- a/drivers/char/ipmi/ipmi_si_intf.c > +++ b/drivers/char/ipmi/ipmi_si_intf.c > @@ -2004,6 +2004,7 @@ int ipmi_si_add_smi(struct si_sm_io *io) > ipmi_addr_src_to_str(new_smi->io.addr_source), > si_to_str[new_smi->io.si_type]); > rv = -EBUSY; > + kfree(new_smi); > goto out_err; > } > }