From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1757457AbcJGPp6 (ORCPT <rfc822;w@1wt.eu>);
        Fri, 7 Oct 2016 11:45:58 -0400
Received: from mail-io0-f181.google.com ([209.85.223.181]:36170 "EHLO
        mail-io0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1756822AbcJGPpt (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 7 Oct 2016 11:45:49 -0400
Subject: Re: CONFIG_DEBUG_TEST_DRIVER_REMOVE needs a warning
To: Rob Herring <robh@kernel.org>
References: <120f00f2-94b6-aead-7bb4-9917bc338660@redhat.com>
 <CAL_Jsq+30GuEJqEF5mnDtSBej3kKSVsGBKwm6bNGGzDxDHThVA@mail.gmail.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
From: Laura Abbott <labbott@redhat.com>
Message-ID: <1fea0fcb-c25c-407b-d3b4-5a9296ed3828@redhat.com>
Date: Fri, 7 Oct 2016 08:45:45 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.3.0
MIME-Version: 1.0
In-Reply-To: <CAL_Jsq+30GuEJqEF5mnDtSBej3kKSVsGBKwm6bNGGzDxDHThVA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 10/06/2016 09:06 PM, Rob Herring wrote:
> On Thu, Oct 6, 2016 at 6:53 PM, Laura Abbott <labbott@redhat.com> wrote:
>> On a whim, I decided to turn on CONFIG_DEBUG_TEST_DRIVER_REMOVE on
>> Fedora rawhide since it sounded harmless enough. It spewed warnings
>> and panicked some systems. Clearly it's  doing its job
>> well of finding drivers that can't handle remove properly and I
>> underestimated it. I was expecting to maybe find a driver or two.
>> Can we get stronger Kconfig text indicating that this shouldn't be
>> turned on lightly? I'll be turning the option off in Fedora but sending
>> out reports from what was found.
>
> It hides behind CONFIG_DEBUG already. Is there a better option that
> distros won't turn on?

For Fedora rawhide, we tend to turn on debug options that don't have
a significant performance impact to hopefully make the kernel better
for Fedora stable releases. Apart from a more explicit Kconfig text,
you could hide it behind CONFIG_EXPERT which Fedora doesn't turn on
and is more of a hint that this should only be used in specific
circumstances.

>
> Rob
>

Thanks,
Laura