From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1503FC11F6B for ; Fri, 2 Jul 2021 09:05:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EBEA46141E for ; Fri, 2 Jul 2021 09:04:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230496AbhGBJHa (ORCPT ); Fri, 2 Jul 2021 05:07:30 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:39712 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231126AbhGBJH2 (ORCPT ); Fri, 2 Jul 2021 05:07:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1625216696; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LHpZpXtlGl518WPRuaRQL8rygDnIJqXUI6Y0K5b7NoM=; b=C2MPXsb9uThj0xEOJJMBus+zB9wAUEnMYws2hix0Q0ZTaM4T5e4OoLINP5TPcRfU2BeWrz eekefz+Tm2PWkWqr0A8VEiBffdInbJhmZDXULIWulTM67wQ12359Swvksk8APy4lx5XXFf V8Yo14lH5yAQyrzeB4q8A4PBvda1ecc= Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-276-Cl6PfO76OiGt__onYIhWBg-1; Fri, 02 Jul 2021 05:04:55 -0400 X-MC-Unique: Cl6PfO76OiGt__onYIhWBg-1 Received: by mail-pj1-f70.google.com with SMTP id q9-20020a17090a0649b029016ffc6b9665so7615406pje.1 for ; Fri, 02 Jul 2021 02:04:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=LHpZpXtlGl518WPRuaRQL8rygDnIJqXUI6Y0K5b7NoM=; b=TTGQrEniJqabLK2C3kpXs01Pez7wrwLAWFmLu20SAUWzP6SHvwdjfupLi522TVuJde J8E58Gr303wn/MOWU7WEwrcWdHJQQGhaST8jDiT7Zw6wuTUOvZnEzdZhMn6jWCbRzeW0 THrZIf5WKrptbVyeHZcpgKZxiug5g5hRr3S15AQ1jn4SxKhkitmxsAWUFOnY1QzTDqWO mdqqHrcmN0DkV/igm24lStRXNkJb3dIajbpJzwkfm0SN62rIKSS+gEO+Rukw6ATLIhFo 5K+p7JtIcDfJG1ZnuSJhm2+V1KPhO+NKS/vgPQd9+Bw6LyB71Bh52eHdOCke0TUDbiJr IEuw== X-Gm-Message-State: AOAM530tGNKM6Qjw0IwdHTouTIwqnRMznG8GfUyKS4sqLhabMCG5xs8Y J5roliSY+xoL7gP5dk/wjHTc2qb9IQBfCQB+6uRNinwfqw+njEoDitZnLM3kC8nVoRlkRtY9LbK 7FthGytvXc4Y2RD+zBHUGgdi7 X-Received: by 2002:a17:90a:2d8c:: with SMTP id p12mr1783pjd.58.1625216694357; Fri, 02 Jul 2021 02:04:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJygD2gvYgD+pPILx3MnRJPirTM5Snc+03W7nqAMCUlL8Ysoglr4DEs8YGR/7CD07hbBIX51nA== X-Received: by 2002:a17:90a:2d8c:: with SMTP id p12mr1748pjd.58.1625216694098; Fri, 02 Jul 2021 02:04:54 -0700 (PDT) Received: from wangxiaodeMacBook-Air.local ([209.132.188.80]) by smtp.gmail.com with ESMTPSA id ft21sm2023663pjb.53.2021.07.02.02.04.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 02 Jul 2021 02:04:53 -0700 (PDT) Subject: Re: [PATCH net-next v3 1/3] selftests/ptr_ring: add benchmark application for ptr_ring To: Yunsheng Lin , "Michael S. Tsirkin" Cc: davem@davemloft.net, kuba@kernel.org, brouer@redhat.com, paulmck@kernel.org, peterz@infradead.org, will@kernel.org, shuah@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-kselftest@vger.kernel.org, linuxarm@openeuler.org References: <1625142402-64945-1-git-send-email-linyunsheng@huawei.com> <1625142402-64945-2-git-send-email-linyunsheng@huawei.com> <91bcade8-f034-4bc7-f329-d5e1849867e7@huawei.com> <20210702042838-mutt-send-email-mst@kernel.org> <661a84bc-e7c5-bc21-25ac-75a68efa79ca@huawei.com> From: Jason Wang Message-ID: <1fed53f1-f882-ca67-8876-ca6702dcd9cd@redhat.com> Date: Fri, 2 Jul 2021 17:04:44 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <661a84bc-e7c5-bc21-25ac-75a68efa79ca@huawei.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2021/7/2 下午4:46, Yunsheng Lin 写道: > On 2021/7/2 16:30, Michael S. Tsirkin wrote: >> On Fri, Jul 02, 2021 at 04:17:17PM +0800, Yunsheng Lin wrote: >>>> Let's reuse ptr_ring.c in tools/virtio/ringtest. Nothing virt specific there. >>> It *does* have some virtio specific at the end of ptr_ring.c. They are just wrappers to make ptr ring works like a virtio ring. We can split them out into another file if necessary. >>> It can be argued that the ptr_ring.c in tools/virtio/ringtest >>> could be refactored to remove the function related to virtio. >>> >>> But as mentioned in the previous disscusion [1], the tools/virtio/ >>> seems to have compile error in the latest kernel, it does not seems >>> right to reuse that. >>> And most of testcase in tools/virtio/ seems >>> better be in tools/virtio/ringtest instead，so until the testcase >>> in tools/virtio/ is compile-error-free and moved to tools/testing/ >>> selftests/, it seems better not to reuse it for now. >> >> That's a great reason to reuse - so tools/virtio/ stays working. >> Please just fix that. +1 > I understand that you guys like to see a working testcase of virtio. > I would love to do that if I have the time and knowledge of virtio, > But I do not think I have the time and I am familiar enough with > virtio to fix that now. So ringtest is used for bench-marking the ring performance for different format. Virtio is only one of the supported ring format, ptr ring is another. Wrappers were used to reuse the same test logic. Though you may see host/guest in the test, it's in fact done via two processes. We need figure out: 1) why the current ringtest.c does not fit for your requirement (it has SPSC test) 2) why can't we tweak the ptr_ring.c to be used by both ring_test and your benchmark If neither of the above work, we can invent new ptr_ring infrastructure under tests/ Thanks > >