From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 852D31F8691 for ; Fri, 19 Dec 2025 22:11:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766182278; cv=none; b=ZbaomT58x4sxi75/0l11Nvy02WAoz1Z7g1gofPO9ShTT7tT5PgwsOr3AjslxE9dIBRSjgEx3CjRsQiqSwOCYvUU5oenJTZU2/7mdDQAoz64qjbJTlXx9XOESL/zF+v8bZhFWHZ8i/Fy08BKmzFG6tv6ZmKMetWYGAD3cPxPLeeI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766182278; c=relaxed/simple; bh=gE/rWpEyZuj6aBP8kAbZ89X4GhrK6PXey60Z6sw3UKM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Vy+Mj1rBcYtTmBrxOfc2FOlX1as6PzF4G18RWAt7UwoIvG5u/LQHHo1Arl9vNoNfPT7wZB8xZeWzDC+WMlYrTKoURb76uSISc3bIA4qoi/RS7KApZXqEXPGy+cjFE5P+fzwr5zTDLixucloQQIIkvwh8lCeT49oyrcCcHsgnO3w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=QS3XMMwh; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=nyx4U+6S; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="QS3XMMwh"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="nyx4U+6S" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1766182275; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xeq1/IF7ERfBMCtWHAumuoI2dJyv3hwKaBPQOg1Zfc0=; b=QS3XMMwhz1fMPWtob5I5UBUg/cG/gIGSNXYTY0dRe04wNxlP3oop3O2pBb48ZSHeWQEj7i xSG5Z6k56TEj4NjHqCAl2cJ+JvKIFy45mwS+4Bp1tyqLXHZYLCrkHfQr1jRbX5Y6D6DX/M hEYzsBxRrSLNdiEhSDK2UnDLyeZUz3k= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-307-D1Kpy4oaOVGCyZTQh4BgHQ-1; Fri, 19 Dec 2025 17:11:14 -0500 X-MC-Unique: D1Kpy4oaOVGCyZTQh4BgHQ-1 X-Mimecast-MFC-AGG-ID: D1Kpy4oaOVGCyZTQh4BgHQ_1766182273 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-430f4609e80so1024959f8f.3 for ; Fri, 19 Dec 2025 14:11:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1766182273; x=1766787073; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=xeq1/IF7ERfBMCtWHAumuoI2dJyv3hwKaBPQOg1Zfc0=; b=nyx4U+6ShZh733ShxegKDVSKcq+zCgYdmVJt2NcahD+TpfjtRP04EdAZJJiaOerVVy QcALFiAPsCo19k3D2EOwMjV3n6VI7GpFP0epSbcc0NXCsk6YwekxFicV67nzYO499Epv qoZswJ/2cQMLlJKFnRS75yvD0O4gfTXHUNDvFY9ivlEJijGiKqdijJEh1koPpCw3s8Bg yp5WjdUVEGRZfAXoc0gjcdGW9qqLBjAstCJgXqFl/qjgDWMTqpghCIkedUxFY8W+ffKc FJB4SU+mOdzQCVlPdIJySDekfXclTDgr5LjasjtTxpt4ll5+uOVL4l1n9195CL5Y/Dos rKzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766182273; x=1766787073; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=xeq1/IF7ERfBMCtWHAumuoI2dJyv3hwKaBPQOg1Zfc0=; b=BedRLE/48xYX6lY750s0ItwydXKDW6OFL6neR0k8s8w2gQ18nbjkTZDfHjPOvtuHy/ ZWlYdTlNK2ih/S8+sl1AiKhnvTEtFTt6Ovf/srpwWtRdB9VI7V7icQYe8xf4SDnVK5SY gLIolGtAS6M8DPYoHFKrIBsj0dTUHa0RZbLvPAoFbUWhVUXn7+EVUfWeXj2pH3ROJ2XE gsmsRHboryIL3STyMoAS8oo3sVosIPXstbgqbOaAYPRyQi6Uren5t9eDYEyGtnMDaAio 52PRoh5qU0CBNQw2RHNedQn46bghZzZreKprrMqUmL8QAF3NIMzKz2fSWS/kBSpWxSH+ YyjA== X-Forwarded-Encrypted: i=1; AJvYcCVPKKs7jSsEvTmrI/84RIE4uhtZANlzERXbVJ1SO7VLyk+w6UZsICrM1d/9WVhVy6bvQ5+bicaEPd4Bjlk=@vger.kernel.org X-Gm-Message-State: AOJu0YxyfWhhMQ5YW66tTubnP3dp8UukdpJcB2Vr2CxpckqSmHu3mrvz u6hPFlk8UksYxmAu40fy5yOm4FfgVM+jH3QDi18SkA40WRmEDrhkRCIPx2awwRkemzKbN4UY9D8 R/OWOAuEDk14pfcMl/ol4MHsQRuFnkMeKjJCVOzvCkX/9FA/HAO8YEX9B/JZTAvB8ag== X-Gm-Gg: AY/fxX57bdsSmFVslGU0a/QS8WeNf4Q7X2b0gp/rta0yF0swdsPKAa+bPWUjQ6+p1O2 qUnnJdPUflKLkzZr0aLEbEVTxit2Y3MlyjVtPelmxW8fRLoCWneOskbilv9DUEnzc4HKjeOAlbO 0J1qUSalcIuIHIJQSzJRq0WWYJriPdYjZj9kVlie/DZPefQK8fJ/LtD5+Phg7XZ3dicg3sTTrPE ivxHKo/PH6ofnQDag72E2BykfHbA07gxV1txEGv36bx/yH3T532yhZMiEw7RUoEY10/tE29UGL4 0EtpZvJvs8Gpdw0NuE8JnCS0oXOCy/Kc0ELCbgpht9lUfS/mmSpQV2kmzR46FuNiwqzbbVoOQ3s pZZV7gDUqNzAz6nZc7DqtR2+nwoJ4W4/nlbUFWDq14ASJgOGdiA== X-Received: by 2002:a05:6000:4008:b0:431:2cb:d335 with SMTP id ffacd0b85a97d-4324e4fab82mr4094404f8f.34.1766182272902; Fri, 19 Dec 2025 14:11:12 -0800 (PST) X-Google-Smtp-Source: AGHT+IG8wPlMCZ5iSNXRyZ4+dTA5mKREk3z7NwuNUYWvqt0zk7xcaGVDV/7ijCAKo11FDwT1cbFJVQ== X-Received: by 2002:a05:6000:4008:b0:431:2cb:d335 with SMTP id ffacd0b85a97d-4324e4fab82mr4094389f8f.34.1766182272491; Fri, 19 Dec 2025 14:11:12 -0800 (PST) Received: from ?IPV6:2a01:e0a:c:37e0:8998:e0cf:68cc:1b62? ([2a01:e0a:c:37e0:8998:e0cf:68cc:1b62]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4324ea830fesm7158642f8f.20.2025.12.19.14.11.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 Dec 2025 14:11:12 -0800 (PST) Message-ID: <1ff8c562-2d1a-4e77-85d6-62d9f85a4a31@redhat.com> Date: Fri, 19 Dec 2025 23:11:10 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 0/3] drm/draw: add check API to avoid spurious WARN To: Francesco Valla , Javier Martinez Canillas , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20251217-drm_draw_conv_check-v3-0-15b6f8bc1cbc@valla.it> Content-Language: en-US, fr From: Jocelyn Falempe In-Reply-To: <20251217-drm_draw_conv_check-v3-0-15b6f8bc1cbc@valla.it> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 17/12/2025 09:06, Francesco Valla wrote: > When using the DRM draw support, the only way to check if a color can be > converted from XRGB8888 to a target format is currently to attempt an > actual conversion using drm_draw_color_from_xrgb8888(). This function > however will print a WARN the first time a conversion cannot be > performed, leading to two potential issues: > > - a WARN is emitted without a real reason if the caller is only > attempting a conversion to check if a format can be supported (which > is the case for two of the current user of this API); > - a failing call following the first one is not emitting a WARN, but a > "valid" color value (0x00000000) is returned nevertheless. > > The first issue was observed while using drm_log on a Beagleplay, which > lists AR12 as the first format for its HDMI modesets. > > The target of this patch set is to improve this situation; the first > patch introduces a new API devoted only to check if a conversion from > XRGB8888 to the specified format can be performed, while the other two > substitute drm_draw_color_from_xrgb8888() with this new API in the > current users (drm_panic and drm_log) where relevant. I just pushed it to drm-misc/drm-misc-next Thanks for your contribution. -- Jocelyn > > Signed-off-by: Francesco Valla > --- > Changes in v3: > - Collected R-b tags from Jocelyn (thank you!) > - Link to v2: https://lore.kernel.org/r/20251014-drm_draw_conv_check-v2-0-05bef3eb06fb@valla.it > > Changes in v2: > - Moved to dedicated switch cases in separate functions instead of > single one inside common function. > - Fix copy-paste error in commit message. > > Link to v1: https://lore.kernel.org/r/20251005-drm_draw_conv_check-v1-0-9c814d9362f6@valla.it > > --- > Francesco Valla (3): > drm/draw: add drm_draw_can_convert_from_xrgb8888 > drm/log: avoid WARN when searching for usable format > drm/panic: avoid WARN when checking format support > > drivers/gpu/drm/clients/drm_log.c | 2 +- > drivers/gpu/drm/drm_draw.c | 29 +++++++++++++++++++++++++++++ > drivers/gpu/drm/drm_draw_internal.h | 2 ++ > drivers/gpu/drm/drm_panic.c | 2 +- > 4 files changed, 33 insertions(+), 2 deletions(-) > --- > base-commit: ea1013c1539270e372fc99854bc6e4d94eaeff66 > change-id: 20251003-drm_draw_conv_check-9cc3050ebd57 > > Best regards,