From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5E18C64990 for ; Thu, 25 Aug 2022 14:44:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242718AbiHYOoU (ORCPT ); Thu, 25 Aug 2022 10:44:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47086 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242561AbiHYOns (ORCPT ); Thu, 25 Aug 2022 10:43:48 -0400 Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com [IPv6:2a00:1450:4864:20::12c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E4DD5B56D3 for ; Thu, 25 Aug 2022 07:43:14 -0700 (PDT) Received: by mail-lf1-x12c.google.com with SMTP id z6so28522035lfu.9 for ; Thu, 25 Aug 2022 07:43:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=QezGck2Rnt9aXrRomj4tCk+MjHbkRY5eeAf7b3CgndQ=; b=VMcrbXFG2tzap8vdSh9E6djrYwmTahWltw0gYbaq4/0anFEQMdSXsLofME6bs35t5y BGdJJOpYHqDHXk3gkCPHxnQUJqWu9BDdOLc9tNo5bgakhRoTZHJ7Pd/wml9weNBrO2F4 bkz7DnE/rH8Hylbkgv60V3wkinVk9dsCKKN9Z1K503v66HzU41lXebf3+d+19Fj+s06Q USNXqChq35jKliC8fQqADqAVyJSzjp6Bb/IxCoAYaaKpLhgE46FpbVH1VdEfOzBFONdu tURKnw5E7Vo83TTc9C0kRFUcWDoIfRMzQwx6LZ/1JCQRF6xd4j5YYCeM8sC4mZOvvwXH rXkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=QezGck2Rnt9aXrRomj4tCk+MjHbkRY5eeAf7b3CgndQ=; b=236Wm/Waypbjjk5nvv3KyQG7WWxFO/6xynVGYSOU7iEd9Joksnb1Ur9qm0WOKg/JVh kLZC1A3qrYPI3jKg36jr16FDFqhUJoqrVZFEWYuLfa/F+PQ4bYItOWLOi21SPfvVbY9d DAvjhC6hjEWq68ZXegPt0q6rYSV8czDgD1F2yyH45ckRX18ouNZGlFHWMZKcNPuET1Zz 8vidc3OTiaRjaT5MaoXOXtJ1iQ29lVkRHzXsv5muO1AKiKBF5Dr86nd1tmU/7qkMeuxW 81qPfATmGPcakUsSUK4LpeXj+WcyEDNvni1/XVhSD0uz9c21za8qAn74hE9Lgh1ZMcac X8QA== X-Gm-Message-State: ACgBeo0Jh04DB3GuUn7LLCxxLpGWNvaqZAeaMCXTL5vyAuAmk4txuyVF Rzm1lmwASjXEznZ3LmeBpKCuFw== X-Google-Smtp-Source: AA6agR7lt6cQDb/JenKwqvFlrkshRUfjJ/CgGHNtlopSR4xN9kuquWmQ6UX8k806tVa5ooIw9b/7ew== X-Received: by 2002:a05:6512:1045:b0:492:c1f8:898e with SMTP id c5-20020a056512104500b00492c1f8898emr1386233lfb.619.1661438593317; Thu, 25 Aug 2022 07:43:13 -0700 (PDT) Received: from [192.168.0.71] (82.131.98.15.cable.starman.ee. [82.131.98.15]) by smtp.gmail.com with ESMTPSA id z4-20020a05651c11c400b0025dfd2f66d6sm601026ljo.95.2022.08.25.07.43.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 25 Aug 2022 07:43:12 -0700 (PDT) Message-ID: <1ff8ca51-cd20-8066-6ca4-f6359bb89dd8@linaro.org> Date: Thu, 25 Aug 2022 17:43:11 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH v3] hwmon: Add driver for the TEXAS TPS546D24 Buck Converter. Content-Language: en-US To: Duke Du , jdelvare@suse.com, linux@roeck-us.net, corbet@lwn.net, linux-hwmon@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: fran.hsu@quantatw.com, charles.hsu@quantatw.com, george.hung@quantatw.com, duke.du@quantatw.com References: <1660878283-9512-1-git-send-email-Duke.Du@quantatw.com> From: Krzysztof Kozlowski In-Reply-To: <1660878283-9512-1-git-send-email-Duke.Du@quantatw.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19/08/2022 06:04, Duke Du wrote: Thank you for your patch. There is something to discuss/improve. > +static int tps546d24_probe(struct i2c_client *client) > +{ > + return pmbus_do_probe(client, &tps546d24_info); > +} > + > +static const struct i2c_device_id tps546d24_id[] = { > + {"tps546d24", 0}, > + {} > +}; > +MODULE_DEVICE_TABLE(i2c, tps546d24_id); > + > +static const struct of_device_id __maybe_unused tps546d24_of_match[] = { > + {.compatible = "tps546d24"}, Except missing vendor prefix, you need to document the compatible in bindings. > + {} > +}; > + Missing MODULE_DEVICE_TABLE > +MODULE_IMPORT_NS(PMBUS); Best regards, Krzysztof