From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Siddharth Vadapalli <s-vadapalli@ti.com>,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
linux@armlinux.org.uk, pabeni@redhat.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, nsekhar@ti.com,
rogerq@kernel.org
Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, srk@ti.com
Subject: Re: [PATCH net-next v2] dt-bindings: net: ti: k3-am654-cpsw-nuss: Document Serdes PHY
Date: Wed, 8 Mar 2023 09:34:36 +0100 [thread overview]
Message-ID: <1ffed720-322c-fa73-1160-5fd73ce3c7c2@linaro.org> (raw)
In-Reply-To: <20230308051835.276552-1-s-vadapalli@ti.com>
On 08/03/2023 06:18, Siddharth Vadapalli wrote:
> Update bindings to include Serdes PHY as an optional PHY, in addition to
> the existing CPSW MAC's PHY. The CPSW MAC's PHY is required while the
> Serdes PHY is optional. The Serdes PHY handle has to be provided only
> when the Serdes is being configured in a Single-Link protocol. Using the
> name "serdes-phy" to represent the Serdes PHY handle, the am65-cpsw-nuss
> driver can obtain the Serdes PHY and request the Serdes to be
> configured.
>
> Signed-off-by: Siddharth Vadapalli <s-vadapalli@ti.com>
> ---
>
> Hello,
>
> This patch corresponds to the Serdes PHY bindings that were missed out in
> the series at:
> https://lore.kernel.org/r/20230104103432.1126403-1-s-vadapalli@ti.com/
> This was pointed out at:
> https://lore.kernel.org/r/CAMuHMdW5atq-FuLEL3htuE3t2uO86anLL3zeY7n1RqqMP_rH1g@mail.gmail.com/
>
> Changes from v1:
> 1. Describe phys property with minItems, items and description.
> 2. Use minItems and items in phy-names.
> 3. Remove the description in phy-names.
>
> v1:
> https://lore.kernel.org/r/20230306094750.159657-1-s-vadapalli@ti.com/
>
> .../bindings/net/ti,k3-am654-cpsw-nuss.yaml | 14 ++++++++++++--
> 1 file changed, 12 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/net/ti,k3-am654-cpsw-nuss.yaml b/Documentation/devicetree/bindings/net/ti,k3-am654-cpsw-nuss.yaml
> index 900063411a20..0fb48bb6a041 100644
> --- a/Documentation/devicetree/bindings/net/ti,k3-am654-cpsw-nuss.yaml
> +++ b/Documentation/devicetree/bindings/net/ti,k3-am654-cpsw-nuss.yaml
> @@ -126,8 +126,18 @@ properties:
> description: CPSW port number
>
> phys:
> - maxItems: 1
> - description: phandle on phy-gmii-sel PHY
> + minItems: 1
> + items:
> + - description: CPSW MAC's PHY.
> + - description: Serdes PHY. Serdes PHY is required only if
> + the Serdes has to be configured in the
> + Single-Link configuration.
> +
> + phy-names:
> + minItems: 1
> + items:
> + - const: mac-phy
> + - const: serdes-phy
Drop "phy" suffixes.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-03-08 8:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-08 5:18 Siddharth Vadapalli
2023-03-08 8:34 ` Krzysztof Kozlowski [this message]
2023-03-08 8:38 ` Siddharth Vadapalli
2023-03-08 12:34 ` Krzysztof Kozlowski
2023-03-09 4:18 ` Siddharth Vadapalli
2023-03-09 6:21 ` Krzysztof Kozlowski
2023-03-09 7:24 ` Siddharth Vadapalli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ffed720-322c-fa73-1160-5fd73ce3c7c2@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
--cc=rogerq@kernel.org \
--cc=s-vadapalli@ti.com \
--cc=srk@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®