From: Devi Priya <quic_devipriy@quicinc.com>
To: Konrad Dybcio <konrad.dybcio@linaro.org>, <agross@kernel.org>,
<andersson@kernel.org>, <lgirdwood@gmail.com>,
<broonie@kernel.org>, <robh+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>,
<linux-arm-msm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<devicetree@vger.kernel.org>
Cc: <quic_srichara@quicinc.com>, <quic_sjaganat@quicinc.com>,
<quic_kathirav@quicinc.com>, <quic_arajkuma@quicinc.com>,
<quic_anusha@quicinc.com>, <quic_ipkumar@quicinc.com>
Subject: Re: [PATCH V3 5/5] arm64: dts: qcom: ipq9574: Add cpufreq support
Date: Fri, 7 Apr 2023 19:54:22 +0530 [thread overview]
Message-ID: <1ffee0eb-84cc-98b1-77d3-84c6509b0a1a@quicinc.com> (raw)
In-Reply-To: <de8d228f-36b9-e35e-2f08-880c96a39267@linaro.org>
On 4/7/2023 5:29 PM, Konrad Dybcio wrote:
>
>
> On 7.04.2023 06:53, Devi Priya wrote:
>>
>>
>> On 4/7/2023 1:21 AM, Konrad Dybcio wrote:
>>>
>>>
>>> On 6.04.2023 09:00, Devi Priya wrote:
>>>> Add cpu freq nodes in the device tree to bump cpu frequency above 800MHz.
>>>>
>>>> Co-developed-by: Praveenkumar I <quic_ipkumar@quicinc.com>
>>>> Signed-off-by: Praveenkumar I <quic_ipkumar@quicinc.com>
>>>> Signed-off-by: Devi Priya <quic_devipriy@quicinc.com>
>>>> ---
>>>> Changes in V3:
>>>> - No change
>>>>
>>>> arch/arm64/boot/dts/qcom/ipq9574.dtsi | 58 +++++++++++++++++++++++++++
>>>> 1 file changed, 58 insertions(+)
>>>>
>>>> diff --git a/arch/arm64/boot/dts/qcom/ipq9574.dtsi b/arch/arm64/boot/dts/qcom/ipq9574.dtsi
>>>> index 1f9b7529e7ed..cfef87b5fd22 100644
>>>> --- a/arch/arm64/boot/dts/qcom/ipq9574.dtsi
>>>> +++ b/arch/arm64/boot/dts/qcom/ipq9574.dtsi
>>>> @@ -6,6 +6,7 @@
>>>> * Copyright (c) 2023, Qualcomm Innovation Center, Inc. All rights reserved.
>>>> */
>>>> +#include <dt-bindings/clock/qcom,apss-ipq.h>
>>>> #include <dt-bindings/clock/qcom,ipq9574-gcc.h>
>>>> #include <dt-bindings/interrupt-controller/arm-gic.h>
>>>> #include <dt-bindings/reset/qcom,ipq9574-gcc.h>
>>>> @@ -37,6 +38,10 @@
>>>> reg = <0x0>;
>>>> enable-method = "psci";
>>>> next-level-cache = <&L2_0>;
>>>> + clocks = <&apcs_glb APCS_ALIAS0_CORE_CLK>;
>>>> + clock-names = "cpu";
>>>> + operating-points-v2 = <&cpu_opp_table>;
>>>> + cpu-supply = <&ipq9574_s1>;
>>>> };
>>>> CPU1: cpu@1 {
>>>> @@ -45,6 +50,10 @@
>>>> reg = <0x1>;
>>>> enable-method = "psci";
>>>> next-level-cache = <&L2_0>;
>>>> + clocks = <&apcs_glb APCS_ALIAS0_CORE_CLK>;
>>>> + clock-names = "cpu";
>>>> + operating-points-v2 = <&cpu_opp_table>;
>>>> + cpu-supply = <&ipq9574_s1>;
>>>> };
>>>> CPU2: cpu@2 {
>>>> @@ -53,6 +62,10 @@
>>>> reg = <0x2>;
>>>> enable-method = "psci";
>>>> next-level-cache = <&L2_0>;
>>>> + clocks = <&apcs_glb APCS_ALIAS0_CORE_CLK>;
>>>> + clock-names = "cpu";
>>>> + operating-points-v2 = <&cpu_opp_table>;
>>>> + cpu-supply = <&ipq9574_s1>;
>>>> };
>>>> CPU3: cpu@3 {
>>>> @@ -61,6 +74,10 @@
>>>> reg = <0x3>;
>>>> enable-method = "psci";
>>>> next-level-cache = <&L2_0>;
>>>> + clocks = <&apcs_glb APCS_ALIAS0_CORE_CLK>;
>>>> + clock-names = "cpu";
>>>> + operating-points-v2 = <&cpu_opp_table>;
>>>> + cpu-supply = <&ipq9574_s1>;
>>>> };
>>>> L2_0: l2-cache {
>>>> @@ -75,6 +92,47 @@
>>>> reg = <0x0 0x40000000 0x0 0x0>;
>>>> };
>>>> + cpu_opp_table: opp-table-cpu {
>>> This is not sorted properly. It should probably come
>>> after memory alphabetically ('o' > 'm')
>>>
>> Yes, But I see that opp-table-cpu node is already placed after
>> memory@40000000
>
> Oh you're right, the diff doesn't really show that very
> well and I didn't notice..
>
>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Sure, thank you!
>
> Konrad
>>> Konrad
>>>> + compatible = "operating-points-v2";
>>>> + opp-shared;
>>>> +
>>>> + opp-936000000 {
>>>> + opp-hz = /bits/ 64 <936000000>;
>>>> + opp-microvolt = <725000>;
>>>> + clock-latency-ns = <200000>;
>>>> + };
>>>> +
>>>> + opp-1104000000 {
>>>> + opp-hz = /bits/ 64 <1104000000>;
>>>> + opp-microvolt = <787500>;
>>>> + clock-latency-ns = <200000>;
>>>> + };
>>>> +
>>>> + opp-1416000000 {
>>>> + opp-hz = /bits/ 64 <1416000000>;
>>>> + opp-microvolt = <862500>;
>>>> + clock-latency-ns = <200000>;
>>>> + };
>>>> +
>>>> + opp-1488000000 {
>>>> + opp-hz = /bits/ 64 <1488000000>;
>>>> + opp-microvolt = <925000>;
>>>> + clock-latency-ns = <200000>;
>>>> + };
>>>> +
>>>> + opp-1800000000 {
>>>> + opp-hz = /bits/ 64 <1800000000>;
>>>> + opp-microvolt = <987500>;
>>>> + clock-latency-ns = <200000>;
>>>> + };
>>>> +
>>>> + opp-2208000000 {
>>>> + opp-hz = /bits/ 64 <2208000000>;
>>>> + opp-microvolt = <1062500>;
>>>> + clock-latency-ns = <200000>;
>>>> + };
>>>> + };
>>>> +
>>>> firmware {
>>>> scm {
>>>> compatible = "qcom,scm-ipq9574", "qcom,scm";
>> Best Regards,
>> Devi Priya
prev parent reply other threads:[~2023-04-07 14:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-06 7:00 [PATCH V3 0/5] Add regulator support for IPQ9574 SoC Devi Priya
2023-04-06 7:00 ` [PATCH V3 1/5] regulator: qcom_smd: Add s1 sub-node to mp5496 regulator Devi Priya
2023-04-06 7:00 ` [PATCH V3 2/5] regulator: qcom_smd: Add MP5496 S1 regulator Devi Priya
2023-04-06 19:37 ` Konrad Dybcio
2023-04-07 14:59 ` Devi Priya
2023-04-06 7:00 ` [PATCH V3 3/5] arm64: dts: qcom: ipq9574: Add RPM related nodes Devi Priya
2023-04-06 19:37 ` Konrad Dybcio
2023-04-06 7:00 ` [PATCH V3 4/5] arm64: dts: qcom: ipq9574: Add SMPA1 regulator node Devi Priya
2023-04-06 19:47 ` Konrad Dybcio
2023-04-07 4:41 ` Devi Priya
2023-04-06 7:00 ` [PATCH V3 5/5] arm64: dts: qcom: ipq9574: Add cpufreq support Devi Priya
2023-04-06 19:51 ` Konrad Dybcio
2023-04-07 4:53 ` Devi Priya
2023-04-07 11:59 ` Konrad Dybcio
2023-04-07 14:24 ` Devi Priya [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ffee0eb-84cc-98b1-77d3-84c6509b0a1a@quicinc.com \
--to=quic_devipriy@quicinc.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_anusha@quicinc.com \
--cc=quic_arajkuma@quicinc.com \
--cc=quic_ipkumar@quicinc.com \
--cc=quic_kathirav@quicinc.com \
--cc=quic_sjaganat@quicinc.com \
--cc=quic_srichara@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®