From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm2-f13.google.com (mail-wm2-f13.google.com [74.125.225.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 897F74BC006 for ; Thu, 1 Oct 2026 09:44:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.225.141 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790847877; cv=none; b=iCLpWUdjVZ56gjNFLUlHsNTqpBusoaNEHIbI8+7jDY1kyoYpxfvn/OeMI2LlZKyAWoxysqrT6OMrrN0AbuxPv/QmbfYCcgxnPGonEkVfcwLCflxTZXirYx2P8ljhVsl+BwMRMNvtA3cJSrH/NkdA0xxLCStZ9sEo48Q5bDHaJSE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790847877; c=relaxed/simple; bh=uM1dQUiN6LEEGAM42Uvfmozwbcyiv6F9zdNRKF0DmhQ=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=GynR3mx8uGkJWIBnxZozoZw/CX4sBVq05UKAj5Eq6ekCOarsiRK6P3f5gyWm+wUyka7I51fcxqFihaGqP8k1CPPoLwb0eGBbWe4ZJtO8lOv7BgS48jNGANoYusFxF53roQjX/+4owqo2LnqCYy8cU0Tfbvyvw7BswDyUxaw8xzQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=dlIke/1u; arc=none smtp.client-ip=74.125.225.141 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="dlIke/1u" Received: by mail-wm2-f13.google.com with SMTP id 5b1f17b1804b1-49cd5462b69so35175765e9.1 for ; Thu, 01 Oct 2026 02:44:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1790847874; x=1791452674; darn=vger.kernel.org; h=content-type:mime-version:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to :content-type; bh=zH7V34OXWvQCWyssKCnOpja/kvoTZzJKQy/F14al/1M=; b=dlIke/1upn+MP2ZCNDKULlv4Yd9bBxmJs9HWWetjy48nYTCXGx/ERhVS4RqMzyhv0m NhO+3ahojvZW+JIXOJcy97ZswgPKRwmm5XstGvWJGfSPj1gkcVBzgaBa9BQrHk22D348 SD02fIFE4w35/f5ZCYALnBCnNQvitigKXhdR3syx/wNCgDUCyLdka1onLZ9tHl8JUpj3 3S037Bj6PwEOUV3S4hwy8ZqaaJtSorTTA4PklZpFV8Wnt1fN7U85qTu2b8Wcken9WRW6 x0mIYVpk2gdV3ygRnR1Al2Ra7TFmY+IjWpmkcJFZlxzbXWqiv+8sLXb7jPATdlzOCGdZ JgLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790847874; x=1791452674; h=content-type:mime-version:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=zH7V34OXWvQCWyssKCnOpja/kvoTZzJKQy/F14al/1M=; b=0jjhEg882ybE+JLTnQ2DbSXCNwQtlgjXyn1zr4XLgQS5SRGUSzDoW9rVNj6nBvdZDM m/UboMSNB/swsYmL9BqRzRCuBtK8FmC/B2ba0W5UymfY7y0PQqajLDcZ6DzyfpHv5aO3 iZoXBvETZJ4ooFhUchhiItpO3X8awlXOJtWKDZytkb+OgIBIl0SlbhOVk8uwMG+Wlbcc z7nb1alzwQU7PBFQmApMzlUyqHFeGLXZsuiHBtqwO1ntqafmeBS/Jd1kB6Bu8yTfl4Zv 3JFMs7XbJHvUosXafRXdCoq0+/Pz3bn4f6mdVL6r2qBqfEcJUO4zrAlLY4Z+f7nm7eLP V5Ww== X-Forwarded-Encrypted: i=1; AKwUvBymwOBwvewA3i3v48HroTL5cRATeGl/24LknpPzysaIuoKfs36P2iw1RKtkdSkiH/quHaNaTwbud/gf9U0=@vger.kernel.org X-Gm-Message-State: AFuF++msQeTFG/YwVvjlXufmCKa6flna9jfiEeL14v2xBiiGgl27o4Vh Kd1vV+UWSVmCNoRBF5xiI2F//ykUygGgZmlCJzefIVlWvgF9BEfYB1GQ9UWP3LZvFzo= X-Gm-Gg: AYBFou1T7RyTDh/Iz9798nfrGKBVOotd0jAZcm9zlnp8TaxbddQGnIv7D0UxtFWzfTl 5g2BrRszjzTYblzQVp5yUr+5s4ikncc87tRdZzWifDJkB+dxKh8ojkeD7L1b8Rm3MjDLso/lFUU Cv4TUA925KXaRatb7rJt3Xy+wv2wWUAegcGFBSeTolvrQGLmOfXMfKZnIfcwZynX2Cvy4qxrcKk XFKfA1EjR53bocgH0qMsTmXHpnXIldWxcCkgLFK0azk2lrYvXJyzql56kZ5bNvVXqjbMTRLitgR eWaBfacW+VrXZP58Gi2IaQ77LuNIKXyQGLpOqLrCmFOUBjytuMh9lEtL6zX3ZDLw2NqM/OJkTLE ulhrRqymmV2Gn9KC84RgrRGZZnsq6stEcujDnqOc+CQReNK8R58t3IXwrzrgI8zT97Wu4CwUXjZ aS+im1DGq4sEzPrQR1b994OKjcEX9ozPDW+Tjdt6gvC0UUSIAPVbj5KCgJb+KDT7gYpN9R5WCFJ vJuh6nKfkYoPnLnBb7riiQ3D2y9 X-Received: by 2002:a05:600c:a015:b0:4a0:22d5:9087 with SMTP id 5b1f17b1804b1-4a022d591e7mr16229865e9.31.1790847873729; Thu, 01 Oct 2026 02:44:33 -0700 (PDT) Received: from localhost (82-67-6-57.subs.proxad.net. [82.67.6.57]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4a01fa137basm53110945e9.1.2026.10.01.02.44.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Oct 2026 02:44:33 -0700 (PDT) From: Jerome Brunet To: Miquel Raynal , Jacky Huang , Shan-Chun Hung , Michael Turquette , Stephen Boyd , Richard Cochran , Arnd Bergmann , Brian Masney , Jerome Brunet , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Thomas Petazzoni , Steam Lin , linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , devicetree@vger.kernel.org, Miquel Raynal , Jacky Huang , stable@vger.kernel.org Subject: Re: [PATCH v6 05/12] clk: nuvoton: ma35d1: Add missing WDT/WWDT parent clocks In-Reply-To: <20260930-perso-ma35d1-upstream-clk-v6-5-48937ee6c9bb@bootlin.com> References: <20260930-perso-ma35d1-upstream-clk-v6-0-48937ee6c9bb@bootlin.com> <20260930-perso-ma35d1-upstream-clk-v6-5-48937ee6c9bb@bootlin.com> Date: Thu, 01 Oct 2026 11:44:32 +0200 Message-ID: <1j4if53gcf.fsf@starbuckisacylon.baylibre.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On mer. 30 sept. 2026 at 19:24, Miquel Raynal wrote: > The WDT and WWDT muxes list PCLK3/4096 and PCLK4/4096 among their > possible parents, but the driver never registers the corresponding > clocks, so these parents could never be used. > > Add pclk3_div4096 and pclk4_div4096 as fixed factor children of pclk3 > and pclk4 and expose them through the clock provider. > > Reported-by: Jacky Huang > Closes: https://lore.kernel.org/linux-clk/b8a8a65b-e302-4747-bc90-4920fc48795a@gmail.com/ > Suggested-by: Jacky Huang > Fixes: 691521a367cf ("clk: nuvoton: Add clock driver for ma35d1 clock controller") > Cc: stable@vger.kernel.org > Link: https://lore.kernel.org/linux-clk/b8a8a65b-e302-4747-bc90-4920fc48795a@gmail.com/ Is this is a mistake ? We usually add this when applying > Reviewed-by: Jerome Brunet > Signed-off-by: Miquel Raynal > --- > drivers/clk/nuvoton/clk-ma35d1.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/clk/nuvoton/clk-ma35d1.c b/drivers/clk/nuvoton/clk-ma35d1.c > index 6aa42a3e1be3..c914079cee2d 100644 > --- a/drivers/clk/nuvoton/clk-ma35d1.c > +++ b/drivers/clk/nuvoton/clk-ma35d1.c > @@ -17,7 +17,7 @@ > static DEFINE_SPINLOCK(ma35d1_lock); > > #define PLL_MAX_NUM 5 > -#define MA35D1_CLK_COUNT 236 > +#define MA35D1_CLK_COUNT 238 > > /* Clock Control Registers Offset */ > #define REG_CLK_PWRCTL 0x00 > @@ -544,6 +544,8 @@ static int ma35d1_clocks_probe(struct platform_device *pdev) > hws[HCLK3] = ma35d1_clk_fixed_factor(dev, "hclk3", "sysclk1_mux", 1, 2); > hws[PCLK3] = ma35d1_clk_fixed_factor(dev, "pclk3", "sysclk1_mux", 1, 2); > hws[PCLK4] = ma35d1_clk_fixed_factor(dev, "pclk4", "sysclk1_mux", 1, 2); > + hws[PCLK3_DIV4096] = ma35d1_clk_fixed_factor(dev, "pclk3_div4096", "pclk3", 1, 4096); > + hws[PCLK4_DIV4096] = ma35d1_clk_fixed_factor(dev, "pclk4_div4096", "pclk4", 1, 4096); > > hws[USBPHY0] = ma35d1_clk_fixed("usbphy0", 480000000); > hws[USBPHY1] = ma35d1_clk_fixed("usbphy1", 480000000); > > -- > 2.55.0 > -- Jerome