From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 58DDB48424A for ; Thu, 23 Jul 2026 17:04:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784826277; cv=none; b=MIKycxpol5UkA5s9fSzuP1+3g0jweHq9QNJ9A6Kavfe3Z+SdFgyskTZep3dn5NKb3HSnPTwgEW6hYmNSxvK9H4vWmGvcmOGqFHb13ZVmTvwwSDzC2gOzJ6l6AtEhJulmfe/VWMSZcM5CLKunvKfmXAkYzhGAt1JAJphrY+I2NJc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784826277; c=relaxed/simple; bh=o9VVTo6S42mbOL5YNHeNddQl83IMRvNt9iVw7Ax1zcs=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=J9eBrM+EaCE7+mYFIMcAo5bi5nJJliZ6MQz+nHmgnpJKIXhfuDdIF5g0VH3Sbjd8eH9zwzFLgYNE0YWFS3kOCTWtLalyurYzv5G7eAjRH1NLiH3xbGXhfZH+/NXGJF6ebbYekhWQkAf1kPaOY10PAH8BmXdykVOvzlb8yLvMYWU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=BGcn2pm9; arc=none smtp.client-ip=209.85.221.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="BGcn2pm9" Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-47de0093c42so767075f8f.3 for ; Thu, 23 Jul 2026 10:04:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1784826265; x=1785431065; darn=vger.kernel.org; h=content-type:mime-version:message-id:date:user-agent:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to:content-type; bh=jhojDdHC94+BdjAE5gd50YRzJP7qSAXpLrLf8nMSLLo=; b=BGcn2pm9WvAug4PR8l3FANDWOZnBQ4XdbW21YipeI3nJ4ukRiQBaauWySLaXoEROPo KYl4XqRUVJoStP/ov8Y2R4cynD3Uei8U7U/JNr1wxh6PHKu9iPfp+JkqsyRtiimnKIID u94WFQQfdiv8izgm05vPzHzcdo4Vk9kdWiKwzBpidPHKXf02aR/YRfXhapIB5D6i9zKP WecHCnnam4b7nQqsbx9VwAiQrqFyK840l+UkKI084tMkH5P2Ps9pXnEzoplZF157Wy1F bGraUumSEdCftfBBfBiVnH6T0G4KawEtzV9NMJ1YpeeG0ryczMqalGAvviv62T3ZbI9e 2ixA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784826265; x=1785431065; h=content-type:mime-version:message-id:date:user-agent:references :in-reply-to:subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to:content-type; bh=jhojDdHC94+BdjAE5gd50YRzJP7qSAXpLrLf8nMSLLo=; b=hwlnjYLXYKmNYH+TMnGGVMMetzrU0SsyEYke2Fd+xFBiSYBJZmwGIi9cApvxLdAaap NQBMaNbtQSx1jBxlsaXQK4DKg+5kW7CUIZETRswRPiVmsnVIBWHOY5Y0We6l1FvfWoNn lyuUNMI++IJxOzrBC4ybf61KUBy8be1pUHFy9QcPwLuX07oYiilPkxIXhw1KtcWhYhIC MeU6TkBN1fj17VGKpEHtp7Xnngs8StKm7O6jdgVnHP0i4QzWARr3PibMQu32yy0UIFki zzVQb6i5HJ8qoYbePqGklWRZl/asIHKVOf2TNmDug9oX9ztpVim/U7qwJ1SXt+wij92E fc0Q== X-Forwarded-Encrypted: i=1; AHgh+RpWB2jqmUytKOhIblH0gkeQhGc9z6DU5mfbZMSP/yFXrvxbT6ZwnvSHJ7dP6D3qP1EQJB14EsMcU181uPI=@vger.kernel.org X-Gm-Message-State: AOJu0YwzVq0PFT4UXJgUpVC6e0IXDfo2x8YRBM9A4YA4ZwymS3NJD5vU tOgjuYEUwM8ieaXTNbdAunwocAudjnn6ddsKmCGTJ/zzNdFaxihno/QZIcrqGyMKSpY= X-Gm-Gg: AR+sD11nnYR8CrR1Y68+GecveFqPI0PGOfkjSFecGc4Ucy4q4Z3FwZ7bW52RVNgjeS7 ZBytXZ/MWkFOx24A6IOQkm5P7hU6zcbqdNAXTAXMV6j3ysMI8gGFEPp90xn6bw0i0qGNBMU+Tcw Mz5voK8d4J++HZOzTFPzIouCy7sFt1+oZV6NXwMf8WtBabjRp4cL0HNlMBIQNcpMcfZNBui/Rx3 pZPaz8qywHloFQhVmY2n6W6WcxrKhrJditZeivEfe58z27SSclE6KDnRqOyGIrwI7F+IU7+UBzj 9Kkd6Me0kyI3q3fYlvz43nLogKjyF8MbpmkQMOT4+aSppA7ZNiscR8eVfz0XVT8/NEe1a0nBWs7 mfAtP09axQgjE08x90GuAZpX5sZZi6alT0ZH/INXozev1RNiv2I2Ze2RI2hPohFwv1ei+f6OaUP c9 X-Received: by 2002:a05:6000:230a:b0:47f:8aba:8a9a with SMTP id ffacd0b85a97d-47f8d71c7eamr5497660f8f.18.1784826265170; Thu, 23 Jul 2026 10:04:25 -0700 (PDT) Received: from localhost ([2a01:e0a:3c5:5fb1:5f98:8c28:3e2c:1c72]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-47f85c67339sm17937986f8f.31.2026.07.23.10.04.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2026 10:04:22 -0700 (PDT) From: Jerome Brunet To: Brian Masney Cc: Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Michael Turquette , Stephen Boyd , Bjorn Andersson , Geert Uytterhoeven , Heiko Stuebner , Prashant Gaikwad , Thierry Reding , Jonathan Hunter , Tero Kristo , linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-tegra@vger.kernel.org, linux-omap@vger.kernel.org Subject: Re: [PATCH] clk: clean-up simple provider misuse of the consumer API In-Reply-To: (Brian Masney's message of "Thu, 23 Jul 2026 10:33:35 -0400") References: <20260723-clk-provider-simple-clean-v1-1-0c9668240467@baylibre.com> User-Agent: mu4e 1.12.9; emacs 30.1 Date: Thu, 23 Jul 2026 19:04:08 +0200 Message-ID: <1j5x25d4dz.fsf@starbuckisacylon.baylibre.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On jeu. 23 juil. 2026 at 10:33, Brian Masney wrote: > On Thu, Jul 23, 2026 at 03:20:59PM +0200, Jerome Brunet wrote: >> Clock provider should not be using the consumer interface. >> In other words, a provider should not be dealing with struct clk. >> >> This change targets occurrences for which the provider uses the >> consumer interface and corresponding clk_hw interface exist: >> * __clk_get_name() -> clk_hw_get_name() >> * __clk_is_enabled() -> clk_hw_is_enabled() >> * clk_get_rate() -> clk_hw_get_rate() >> >> Signed-off-by: Jerome Brunet >> --- >> The change being very simple, I did not think it was necessary >> to split it into multiple changes. If you prefer it to be split, >> just let me know how. >> --- >> drivers/clk/mvebu/clk-cpu.c | 2 +- >> drivers/clk/qcom/clk-hfpll.c | 4 ++-- >> drivers/clk/qcom/clk-krait.c | 2 +- >> drivers/clk/qcom/clk-rcg.c | 4 ++-- >> drivers/clk/qcom/clk-rcg2.c | 2 +- >> drivers/clk/renesas/r9a06g032-clocks.c | 2 +- >> drivers/clk/rockchip/clk-pll.c | 24 ++++++++++++------------ >> drivers/clk/st/clkgen-pll.c | 20 ++++++++++---------- >> drivers/clk/tegra/clk-tegra210.c | 2 +- >> drivers/clk/ti/clockdomain.c | 2 +- >> 10 files changed, 32 insertions(+), 32 deletions(-) > > This looks good to me however can you split this up by clk subsystem at > the very least so that the various submaintainers can pick up these up? Will do > > With that: > > Reviewed-by: Brian Masney -- Jerome