From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEFB1C64E7A for ; Tue, 1 Dec 2020 08:32:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6BD2020659 for ; Tue, 1 Dec 2020 08:32:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="rqb2bw6e" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728714AbgLAIch (ORCPT ); Tue, 1 Dec 2020 03:32:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46426 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726041AbgLAIch (ORCPT ); Tue, 1 Dec 2020 03:32:37 -0500 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1CA1CC0613D2 for ; Tue, 1 Dec 2020 00:31:51 -0800 (PST) Received: by mail-wm1-x344.google.com with SMTP id h21so3226006wmb.2 for ; Tue, 01 Dec 2020 00:31:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=references:user-agent:from:to:cc:subject:in-reply-to:message-id :date:mime-version; bh=TxYCO6cWwJuHI7h5DWT27KZsbPoNU+/ayiJlqSncKfw=; b=rqb2bw6eKpmf53iOTGKAcD99gWWxxeOsA8KlODalPevcpYj640jondhUuOrOR9OoKm 8dKDV3Yu8hZn/K6RJUnVr4xfPXVIlBxG/P+W9OgHhl8TP/EsO8gBe7hQ/kEvPDwxtxI6 EtrAJW0QwlOjcDkHciPEFope7B46Gmh8rFzVfqcCt+INzGTddWiDP3AD/rvRzb4XyjvS pjKn16q4Yuhkhmg2outK20lnWXFIk08Xe79TbobHlhohxOz79fKCUkgZR5WlGbmom2yE 6IBKVu1/GzRCQGdh29DFyuMZyweI/ClTZ8Lh9gm+ElkUSGyRcYr4U5ik0sMMSufLN6MD IJ6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:message-id:date:mime-version; bh=TxYCO6cWwJuHI7h5DWT27KZsbPoNU+/ayiJlqSncKfw=; b=i8Z2GwdoJ/bAmSd/0RWU14Ep4lytewKPqkIwxhKbUm/o3MkAZW5rhoy9eeeYXZy28N 2tArt8zTf2YikfWKUZBd0DOHZlHlttiiGMDn9K9avDB/EaxIx15pIgMy4SMtmTss34wS VufJvP/Xek7WCIies5Nexj4HNcSdtgKz20bCoV3JjCx5cb7QFK3RMctovc25Vv/p3w6o /O3gQTBZPcLf+/v5xW5c85o5E/qHh6RpFLsVyKANISeHUaNc44qm3QTH0hh28zxc1/b6 Z4U5MxTW+xI6rWy0Cdl5mSXt3xDnnZ2ov88TdGjUSEWXcl96AJOk4iVFPm1ZlUfpO2Pd QRPA== X-Gm-Message-State: AOAM53386uqwMXwBreNnhS4EjgvdN+/Xro6xzUUzIpOZhIJI0M47KoaB 230oR3MbWpHH5RhJ8TbvFMEHJw== X-Google-Smtp-Source: ABdhPJysze0Tk/EFsjvf7saAh4/g3+BzAjZd8SNKiyvNLDFY7ZwWNB2mQsNM5BotMYyX6kOS9bPtzA== X-Received: by 2002:a1c:220a:: with SMTP id i10mr1501475wmi.93.1606811508544; Tue, 01 Dec 2020 00:31:48 -0800 (PST) Received: from localhost (82-65-169-74.subs.proxad.net. [82.65.169.74]) by smtp.gmail.com with ESMTPSA id z19sm1635915wmk.12.2020.12.01.00.31.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Dec 2020 00:31:48 -0800 (PST) References: User-agent: mu4e 1.4.10; emacs 27.1 From: Jerome Brunet To: Stefan Agner , robh+dt@kernel.org, khilman@baylibre.com Cc: narmstrong@baylibre.com, martin.blumenstingl@googlemail.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm64: dts: meson: fix PHY deassert timing requirements In-reply-to: Message-ID: <1j8sai7wr0.fsf@starbuckisacylon.baylibre.com> Date: Tue, 01 Dec 2020 09:31:47 +0100 MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 01 Dec 2020 at 01:25, Stefan Agner wrote: > According to the datasheet (Rev. 1.4, page 30) the RTL8211F requires > at least 50ms "for internal circuits settling time" before accessing > the PHY registers. This fixes an issue where the Ethernet link doesn't > come up when using ip link set down/up: > [ 29.360965] meson8b-dwmac ff3f0000.ethernet eth0: Link is Down > [ 34.569012] meson8b-dwmac ff3f0000.ethernet eth0: PHY [0.0:00] driver [RTL8211F Gigabit Ethernet] (irq=31) > [ 34.676732] meson8b-dwmac ff3f0000.ethernet: Failed to reset the dma > [ 34.678874] meson8b-dwmac ff3f0000.ethernet eth0: stmmac_hw_setup: DMA engine initialization failed > [ 34.687850] meson8b-dwmac ff3f0000.ethernet eth0: stmmac_open: Hw setup failed > > Fixes: 658e4129bb81 ("arm64: dts: meson: g12b: odroid-n2: add the Ethernet PHY reset line") > Signed-off-by: Stefan Agner > --- > arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi > index 6982632ae646..a5652caacb27 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi > +++ b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi > @@ -413,7 +413,7 @@ external_phy: ethernet-phy@0 { > max-speed = <1000>; > > reset-assert-us = <10000>; > - reset-deassert-us = <30000>; > + reset-deassert-us = <50000>; > reset-gpios = <&gpio GPIOZ_15 (GPIO_ACTIVE_LOW | GPIO_OPEN_DRAIN)>; > > interrupt-parent = <&gpio_intc>; Thanks for sharing this is Stefan, The title of your patch should probably be modified to show that it addresses the odroid n2 only, as it stands. I have checked the RTL8211F doc I have, v1.9, and this one mention "72ms at least - not including the 1.0V supply rise time" before accessing the PHY registers :/ ... so 80ms maybe ?