From: Jerome Brunet <jbrunet@baylibre.com>
To: Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org,
Kevin Hilman <khilman@baylibre.com>
Subject: Re: [PATCH 2/2] ASoC: meson: add t9015 internal DAC driver
Date: Wed, 19 Feb 2020 16:27:12 +0100 [thread overview]
Message-ID: <1ja75ey4vj.fsf@starbuckisacylon.baylibre.com> (raw)
In-Reply-To: <20200219145500.GC4488@sirena.org.uk>
On Wed 19 Feb 2020 at 15:55, Mark Brown <broonie@kernel.org> wrote:
>> + /* Channel Src */
>> + SOC_ENUM("Right DAC Source", dacr_in_enum),
>> + SOC_ENUM("Left DAC Source", dacl_in_enum),
>
> Ideally these would be moved into DAPM (using an AIF_IN widget for the
> DAI).
I can (I initially did) but I don't think it is worth it.
I would split Playback into 2 AIF for Left and Right, then add a mux to
select one them if front of both DAC. It will had 4 widgets and 6 routes
but it won't allow turn anything on or off. There is no PM improvement.
Do you still want me to change this ?
next prev parent reply other threads:[~2020-02-19 15:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-19 13:36 [PATCH 0/2] ASoC: meson: add internal DAC support Jerome Brunet
2020-02-19 13:36 ` [PATCH 1/2] ASoC: meson: add t9015 internal codec binding documentation Jerome Brunet
2020-02-19 13:36 ` [PATCH 2/2] ASoC: meson: add t9015 internal DAC driver Jerome Brunet
2020-02-19 14:55 ` Mark Brown
2020-02-19 15:27 ` Jerome Brunet [this message]
2020-02-19 15:44 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ja75ey4vj.fsf@starbuckisacylon.baylibre.com \
--to=jbrunet@baylibre.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=khilman@baylibre.com \
--cc=lgirdwood@gmail.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®