From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AAA82290080 for ; Thu, 10 Jul 2025 08:57:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752137849; cv=none; b=PqasbGqzDAsGJXdM30utMQOKPmZLHISJ8qtCjG0m4xeIplbykuydN5NkPFbxsqsYIYIKUICexD7fGacD/Ed6NK1gZRJD4Rfex9Qb2bmWRIfni029RlCf3JCXOr11R0av7UsycWeDr4dIeQAWevtjFZ8ZItGKVOP+11xYzAfPgrE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752137849; c=relaxed/simple; bh=x2qnWy/jisF+XYZi200qSmXbNr7ZhNRXkIecCvKhBZ4=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=t18Hv+TnHYga6a78z7sgfbciOW2n7qpdlj8rbD1z7NWTXpmKgZDfMfleZ3txSgcdaXsnFAwZlRZ3fYnCiKA2pGCY4RfJd4L2ubqxq1LOOKAvHlc1EFZO1Y/jP9dgKFOuDTUzcgQDEfhHvvuVPZ1Zy0Z0BIMekwN4BArXnLAB2/8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=unmouviC; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="unmouviC" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-454ac069223so9823805e9.1 for ; Thu, 10 Jul 2025 01:57:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1752137845; x=1752742645; darn=vger.kernel.org; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=pEnfT6FkztCf1NEW9XiU9AdGyzA1VPDKN8Lo+OyIA2Q=; b=unmouviCrWPBsjVSvaRbua7ABA6tZ2NpL8OP6R+LfShRvFLMYDV/HqDpf4V8JlrZJc BmzhBcJz/CPbw4CXs1NH7ZQYFrhRX+8HfIxouKBewRBNcgzce6c+YTM4Gaixss8ODlPX SHlBr+y3tnEiFB3lH2T38DaE8f2RTt5Facb7B2ZaADpGPnVqwPqfDAi/m2s/9jy18crm 6arRFDOGIB6YQ3dHnKnp9SMQuAI9SumyBPoMTaUJiNkiAETtuOaMoFms1tthrEA6FCsY uM9yNn/pQilkulDIRMtPRi0uxnIvvV+J/xe/wiETgP7Rm2FhBuyiuN182RdtzrSIO6qM TzRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752137845; x=1752742645; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=pEnfT6FkztCf1NEW9XiU9AdGyzA1VPDKN8Lo+OyIA2Q=; b=aD3ctD6/KJUumw10RxxHgO6t3+5gIjA8i1MnMc4QeZDUyxqZChjhHnwZTnk/u8HXvx 8jrLcA7FL6APj8zrHDoJGm8DdJKIhQThAfVDDEdrZHgIOjK8RfrTDXBRSvEBkQEoz+q/ 7vu1nPyvvJNmF/4pbMuYNijMM7Eunj2WyuHAIF/3L94JmCUCacgtXZVANoM6LqORBO5D uXYSb1kz1ZpM3bcDr9D9b72LgHvtiyar+Mx/jQNN1TZOmGVtjRdSLbYmH7XxNAOS5pxW NJUf40Ejz1DNkiYnNX2RazGuRMAwMPAyo86vyZ9bTVcTMsrXZuWLd7WjySLrZ6QoxXOt k9Aw== X-Forwarded-Encrypted: i=1; AJvYcCUouYPEMaFqbPeml0sL/H++sdkkglT/tBWt36lIWPqRP6uwf2s8g7b/mK0+K8OVDKtMr3hIFnlSel9yCC0=@vger.kernel.org X-Gm-Message-State: AOJu0YxLNTXY+Y+dmV0h7O2ABsLaD88+PaMkc3lWLdtThoIOvFNIcoY6 3hqRlNzWTWmV4p62w+unCNQ2jxoW0TYiU1yuTnobKivBLxenQih4zE4Z+QFPmnp9npw= X-Gm-Gg: ASbGncvjgG0bRIAg4JS483RiyIwqkOJePeT4tKQsvPOxqOhv7ERDB86rlCDAcXxJBle MkHVnGjTI+Q4UX7aK9gBb1vmkNIhtQa5tM+AJN1FqaqvYt02MbB8VhJbxMhiPwbMHsiZjohe9v1 Katpijs5yTzufw9vEhjel4CgXsmsDOExP6ZSIu21no8/JyUqJEG5F/gyCoSehDlxOU4mnEeIa8N ET74fhZafxcqw95Xs+e5RzsuaicY4Do87i/hK06M6WEmkujQByMbmHTSLiZS56XAqbsRv/Qxt7k J+pg73i2KygeaUZExDH6rlSEHz7XCaLSYnZaWKfL+/KiiMIZtEeHKXIrugFPFg== X-Google-Smtp-Source: AGHT+IGWtPkM7wNN2WAZ9ZBqWQxhQQPFiCu8f4+86eF186o2AjTuMIqbAyWP77bRc2dyw5l64yP3Qg== X-Received: by 2002:a05:6000:2087:b0:3a4:f70e:bc25 with SMTP id ffacd0b85a97d-3b5e7f29674mr2434317f8f.27.1752137844837; Thu, 10 Jul 2025 01:57:24 -0700 (PDT) Received: from localhost ([2a01:e0a:3c5:5fb1:9fcc:5953:3d1a:6b41]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-3b5e8e14cfcsm1284032f8f.67.2025.07.10.01.57.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Jul 2025 01:57:24 -0700 (PDT) From: Jerome Brunet To: jiebing chen via B4 Relay Cc: Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jaroslav Kysela , Takashi Iwai , Neil Armstrong , Kevin Hilman , Martin Blumenstingl , Michael Turquette , Stephen Boyd , jiebing.chen@amlogic.com, linux-sound@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org, jian.xu@amlogic.com, shuai.li@amlogic.com, zhe.wang@amlogic.com Subject: Re: [PATCH v5 1/6] dt-bindings: clock: meson: Add audio power domain for s4 soc In-Reply-To: <20250710-audio_drvier-v5-1-d4155f1e7464@amlogic.com> (jiebing chen via's message of "Thu, 10 Jul 2025 11:35:37 +0800") References: <20250710-audio_drvier-v5-0-d4155f1e7464@amlogic.com> <20250710-audio_drvier-v5-1-d4155f1e7464@amlogic.com> User-Agent: mu4e 1.12.9; emacs 30.1 Date: Thu, 10 Jul 2025 10:57:23 +0200 Message-ID: <1jbjpsqv7w.fsf@starbuckisacylon.baylibre.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Thu 10 Jul 2025 at 11:35, jiebing chen via B4 Relay wrote: > From: jiebing chen > > The audio power domain has been detected on S4 device. detected ? > It must be enabled prior to audio operations. > > Signed-off-by: jiebing chen > --- > .../bindings/clock/amlogic,axg-audio-clkc.yaml | 55 +++++++++++++++++++++- > 1 file changed, 54 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/clock/amlogic,axg-audio-clkc.yaml b/Documentation/devicetree/bindings/clock/amlogic,axg-audio-clkc.yaml > index fd7982dd4ceab82389167079c2258a9acff51a76..c3f0bb9b2ff050394828ba339a7be0c9c48e9a76 100644 > --- a/Documentation/devicetree/bindings/clock/amlogic,axg-audio-clkc.yaml > +++ b/Documentation/devicetree/bindings/clock/amlogic,axg-audio-clkc.yaml > @@ -21,6 +21,8 @@ properties: > - amlogic,axg-audio-clkc > - amlogic,g12a-audio-clkc > - amlogic,sm1-audio-clkc > + - amlogic,s4-audio-clkc > + - amlogic,clock-pads-clkc > > '#clock-cells': > const: 1 > @@ -100,13 +102,15 @@ properties: > resets: > description: internal reset line > > + power-domains: > + maxItems: 1 > + > required: > - compatible > - '#clock-cells' > - reg > - clocks > - clock-names > - - resets Not related to the decription ... and fishy ... > > allOf: > - if: > @@ -116,12 +120,37 @@ allOf: > enum: > - amlogic,g12a-audio-clkc > - amlogic,sm1-audio-clkc > + - amlogic,s4-audio-clkc > then: > required: > - '#reset-cells' > else: > properties: > '#reset-cells': false > + - if: > + properties: > + compatible: > + contains: > + enum: > + - amlogic,s4-audio-clkc > + then: > + required: > + - power-domains > + else: > + properties: > + power-domains: false > + - if: > + properties: > + compatible: > + contains: > + enum: > + - amlogic,clock-pads-clkc > + then: > + properties: > + resets: false > + else: > + required: > + - resets > > additionalProperties: false > > @@ -129,6 +158,7 @@ examples: > - | > #include > #include > + #include > apb { > #address-cells = <2>; > #size-cells = <2>; > @@ -198,4 +228,27 @@ examples: > "slv_lrclk9"; > resets = <&reset RESET_AUDIO>; > }; > + clk_pad: clock-controller@330e80 { > + compatible = "amlogic,clock-pads-clkc"; > + reg = <0x0 0x330e80 0x0 0x10>; > + #clock-cells = <1>; > + clocks = <&clkc_periphs CLKID_AUDIO>, > + <&clkc_pll CLKID_MPLL0>, > + <&clkc_pll CLKID_MPLL1>, > + <&clkc_pll CLKID_MPLL2>, > + <&clkc_pll CLKID_MPLL3>, > + <&clkc_pll CLKID_HIFI_PLL>, > + <&clkc_pll CLKID_FCLK_DIV3>, > + <&clkc_pll CLKID_FCLK_DIV4>, > + <&clkc_pll CLKID_FCLK_DIV5>; > + clock-names = "pclk", > + "mst_in0", > + "mst_in1", > + "mst_in2", > + "mst_in3", > + "mst_in4", > + "mst_in5", > + "mst_in6", > + "mst_in7"; > + }; > }; -- Jerome