mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jerome Brunet <jbrunet@baylibre.com>
To: Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,  linux-kernel@vger.kernel.org
Subject: Re: [PATCH] regulator: do not ignore provided init_data
Date: Mon, 23 Sep 2024 18:50:33 +0200	[thread overview]
Message-ID: <1jbk0ez546.fsf@starbuckisacylon.baylibre.com> (raw)
In-Reply-To: <ZvF49CZhRc2rrPQ0@finisterre.sirena.org.uk> (Mark Brown's message of "Mon, 23 Sep 2024 16:19:32 +0200")

On Mon 23 Sep 2024 at 16:19, Mark Brown <broonie@kernel.org> wrote:

> On Fri, Sep 20, 2024 at 07:21:12PM +0200, Jerome Brunet wrote:
>
>> Note that it is probably not problem at the moment since no one complained
>> about ignored data.
>
> I'm fine with tweaking the functionality here but since I don't think
> we're using this at all we should probably warn about systems with both
> forms of constraints specified since they probably need some
> consideration needed and people might not be doing this intentionally.
>
> That probably means checking if regulator_of_get_init_node() can find
> something and warning if that's the case.

We could warn if both init_data and desc->of_match are set ?

Setting desc->of_match is an indication regulator is expected to search
DT, is'nt it ? Having both set be the indicaction of the conflict.

Maybe the warn is enough then. Do you prefer if I keep the change of v1
or drop it ?

-- 
Jerome

  reply	other threads:[~2024-09-23 16:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-20 17:21 Jerome Brunet
2024-09-23 14:19 ` Mark Brown
2024-09-23 16:50   ` Jerome Brunet [this message]
2024-09-24  8:13     ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1jbk0ez546.fsf@starbuckisacylon.baylibre.com \
    --to=jbrunet@baylibre.com \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®