From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 20DDA15E1FE for ; Wed, 24 Apr 2024 13:54:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713966879; cv=none; b=UVqQfJvJWq0BPfIqWg3bsh4X/McxL51Jja7JAtqJme1+7dPi7Vnr+VgETPp3BSWC8PpY5heT6czy5WF2xuw/0cGpOOode0puW2FOLL3puSvf/Bmv9rn+lgQNvGPY1h9he/JwEa1cuCNC4Js8dEQRfnAqeu3vfEl6xNoQQ2xNxwE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713966879; c=relaxed/simple; bh=Mx2OfLd2q5mi0gURFw5TuMXcb1Huqn82HNjl8eR3ylE=; h=References:From:To:Cc:Subject:Date:In-reply-to:Message-ID: MIME-Version:Content-Type; b=uOWN2Rl3wonOIHUhn8j2ApV98PpddkS65yXptWpbXoERKwS34ycgJg4okBNkuCTNxM/BvOcQ4GENjTnSSAQ01X8vNI62tZxXV9xUHV1C9sO+593axoqlCpFr8gS7Ccb48ZNle23NbGP9r8pN/fP8M5k1d/ARocT3NDXfFuUmHN4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=L0ACVveM; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="L0ACVveM" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-34665dd7610so3656171f8f.3 for ; Wed, 24 Apr 2024 06:54:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1713966876; x=1714571676; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:in-reply-to:date :subject:cc:to:from:user-agent:references:from:to:cc:subject:date :message-id:reply-to; bh=nqG6EAw4hfK6YDk87ISdjEyvEY4/LHJcMlZc2x8R9og=; b=L0ACVveMqoyPVa55/eYySBH0vg1cRvHB0FzATMjJfL4L8G/itIj1gx84wFOhHK5fsy 1kIusoUJzOVAjlq8loXdVj+gnHpN/PQ3wePt9A3isf/yQshQgJebG/hqGIIWGf0smfDw rDsjkKnhtqziSJp9TBqYeVKFn+Q8aMKxtT0bgjAw5dQhouNrA4MDO/z5Vw9a/DWMjIsw 0sIlEc/nielh4J7AjcqxmTLfJMzGanK+AwsqnBEOBMaKmHZ4AYg5TOt1ZMmXB/iypt9i BuyGEVzetxj+xkpfzoMkw7oCaL5h5PlO8mZhlx34JrQLQ3KbueGAiC3uGzRf7o5SfKu8 yfSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713966876; x=1714571676; h=content-transfer-encoding:mime-version:message-id:in-reply-to:date :subject:cc:to:from:user-agent:references:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=nqG6EAw4hfK6YDk87ISdjEyvEY4/LHJcMlZc2x8R9og=; b=rA5AJIw5qThtHn+VFzR/irzT/YQYYq2E3e2aa38pOIxMlMxLYNptQoqPhE0w8YJlBk LOQSFaEEle8YITH9rdexuqSe1isu1BZ5ICuMBtmvEIW67SHyECnY6kwnfstGwQ8cOYBg hBBz/aZ7ZKTo3JNSHzh9TARefitUKGF5xNiUdslFPUrO8HZ6G0gCn8bHggCOl7r5FE3c gN4OPb0w2c1FdmSp9khiB3KRNAr0zo8EXH6eFHe9H3esdlT7ryrl+iqDbGIOW6D6qx6o VARKF17x4Bnk/Ph8UhT7PkiTXCfU+Al8lRox+/DaQj98eKabMWYOAT2oM8M9evzLJr0J Xe5A== X-Forwarded-Encrypted: i=1; AJvYcCXCj8vAFnY+GO6wQzI/pG3IUef/fxDUx0/kOww66ra0nZJd5EEriwrlRggzjPNcPkysBVer4EaxqvOhPtVn7MUqP+rpW8BurFQ/joE5 X-Gm-Message-State: AOJu0Yw/fkoO+1l8siLq6JCi9SDFO41b7iFlqfG/zQx5oHYqAdRUWu67 xP6c+z3dULKA+3fPHJqMs9+2hUbWWM0M0oy0v5yQDvtsERqZj78sHvtvWWJIL3M= X-Google-Smtp-Source: AGHT+IEOznvXT2DbTMtec6cIfPbt6cznBYSdTY7urC4yVUpfeeSzluMWHpxbXdtlOl9wyfNYXsAK/A== X-Received: by 2002:a5d:56c2:0:b0:346:251a:396d with SMTP id m2-20020a5d56c2000000b00346251a396dmr1588928wrw.51.1713966876400; Wed, 24 Apr 2024 06:54:36 -0700 (PDT) Received: from localhost ([2a01:e0a:3c5:5fb1:ab48:1b7:631c:952a]) by smtp.gmail.com with ESMTPSA id r14-20020a05600c458e00b00417e5b71188sm23952306wmo.34.2024.04.24.06.54.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Apr 2024 06:54:36 -0700 (PDT) References: <20240424-s4-pwm-v4-0-ee22effd40d0@amlogic.com> <20240424-s4-pwm-v4-1-ee22effd40d0@amlogic.com> <1jil07f3ps.fsf@starbuckisacylon.baylibre.com> User-agent: mu4e 1.10.8; emacs 29.2 From: Jerome Brunet To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Cc: Jerome Brunet , kelvin.zhang@amlogic.com, George Stark , Neil Armstrong , Kevin Hilman , Martin Blumenstingl , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-pwm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Junyi Zhao Subject: Re: [PATCH v4 1/2] pwm: meson: Add support for Amlogic S4 PWM Date: Wed, 24 Apr 2024 15:53:44 +0200 In-reply-to: Message-ID: <1jbk5yg92c.fsf@starbuckisacylon.baylibre.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Wed 24 Apr 2024 at 15:51, Uwe Kleine-K=C3=B6nig wrote: > [[PGP Signed Part:Undecided]] > Hello, > > On Wed, Apr 24, 2024 at 12:32:36PM +0200, Jerome Brunet wrote: >> > +err: >> > + while (--i >=3D 0) { >> > + channel =3D &meson->channels[i]; >> > + clk_put(channel->clk); >>=20 >> Fine on error but leaks on module unload. >>=20 >> Same as George, >>=20 >> Add the devm variant of of_clk_get() if you must. > > There shouldn't be a reason to still use of_clk_get(). I'd expect that > devm_clk_get() should do the job and if not that's a bug. Getting a clock ressource by index instead of by name is a reason. > > Best regards > Uwe --=20 Jerome