From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm2-f13.google.com (mail-wm2-f13.google.com [74.125.225.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 66412475334 for ; Sat, 12 Sep 2026 15:51:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.225.141 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789228265; cv=none; b=j+mxC5JuJxddtQMfFvcpGLgdo+JilarNN3qeObmbvEB2n/8UAKjmelxsIFYbizbLLxm6yAp7IBtTyaynLZppPDURSDfjlWUR5tWVmWuNuiYfctw/d9YCK006E+TNyJSEX/aqGfRl1YodiIdwQ29QiERGDwvdEkeiCkFmkF9OuJY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789228265; c=relaxed/simple; bh=jYjhr9lQehwgsoB55McaT2/qQLnqXw43VwwgAETPBqE=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=ZaGhk7d5FafTnz5SXjsCKdYUEfcN8fGbWIvmCdHSw0CLmh10PUIs3WQ3erEYlLKxLxOnsNA+24oFJkGvves+egTNOxudwifqX+fCh5OmrM6SmEq+FmRdVpESaX9ziFYKvxMHkf97NKfu8LkK0ftwFl0DnH737shBtJJFHkDfutg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=B5Z+lMD3; arc=none smtp.client-ip=74.125.225.141 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="B5Z+lMD3" Received: by mail-wm2-f13.google.com with SMTP id 5b1f17b1804b1-49e71cdb22bso1880065e9.2 for ; Sat, 12 Sep 2026 08:51:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1789228260; x=1789833060; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=WYsEok5/6RpeOa0+UdPPhWNeU1Av3CpfKIsBFwLi6qQ=; b=B5Z+lMD3RMMj7NVb/nfYAe9DpW00iaTkHgayOvY05B8q+8RkWJk6fAJAFkb72iwiyJ O0loOWoDYolpvpWZ5rVs4/SMg/Hz8YlSiFAsBG050eftDr4RIAPy7rizLvbYtovn9VCt bTGVVGCEq9a9FBCXkMQpCMeTXNmsJRuonxg8zcxKzn1lOpAxlhanYHYOks4Edg4VnJ3r lMJ6JlJyjpGetWqBo0FiaciOd3HPSKCLtxZvR6XrXercqClTkajUAvcu/sQRUq8JRPHg 56uZDjTmeeoO38w5PIPxUFX1f+AwvlGvySbq2/PCPeeEJuqXqURiupMHDE6d7SRoV3ff uDkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789228260; x=1789833060; h=content-transfer-encoding:content-type:mime-version:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=WYsEok5/6RpeOa0+UdPPhWNeU1Av3CpfKIsBFwLi6qQ=; b=avU26sQ8CeEWbRa7WTdOsXuHXgzzPOqsTGkjanOaWo7Q8sDx2MGD2cunWRGVAyZmJe 5Vg3b0rjeQXaeIaXHJ/sOiL4xDX1mSpFWd0awK8LJayaSla3nwGr23e0zfxzoqNvv9x2 0fuS08vzIsfm5ufJ6L3l7Ubuo4U9+7PXLNvJCF6WlgRthCv3N/5j/OalVzcRg8nBCa/6 lzOK1Zz5/Bh/Kn0+VOaJbch9lgoG+MiCM5L3hA3aMO0ObQ7jrLt1lVPEas7azLhNOSfP wXwSmClPlY+gxyuprZyFESDNsR9JVEv0aXLTzwfHGu6heRwiScwcJHdhAB2WIiCP0sMy KQmw== X-Forwarded-Encrypted: i=1; AKwUvBxFq3DHrOhZeP+9wGESGn0lM7iLgrUTvr0CfyJCWveOHbHzQ9nhQyaMmXEOmmdQqgrvSznQhooN7923dUM=@vger.kernel.org X-Gm-Message-State: AFuF++lA8pIlvpkGIrL00EREZhNM1dB8s2p0H0F8y9QFdqPkm5hPosHJ 7Oyvlka0JaqyenhjAA5lCivmvsrPcHbYrvgl3wZKpjTGgcrqhbyI750pes/XsPAnmOE= X-Gm-Gg: AYBFou2xtaCm/gSOG7rzBAynufLT1E9CR0xkytatMi+kFSUcq9uwI+7+zcvy6HTVApv BbYxn+PwjOEPVH5tW8iPb30G1lVqdwXg7U/x3uh2miclhfh5AqrQyM8R+4w9HQCRZsectt1350b IjQgHdn8oog9XBqor8DssI6DAgd5OpxvqD8M0pdnhaGwc4OLpD84u3QLOyvzBWppTk6dga4UIhG 9TDblFli7puzoS8QItE3e5jRA8k8+9FLHVz9Kz6EFpVk4/kdB59wZkFf412xWtPW15KQ/Ip1J3k 3AdTV9sbQltDtc4NqSRzB6IU7TP6JeSwNxaOkaBT9LQgbAAvD9ssEOPhzMKddcCYabCKNubpWdI 53G0TFZHCzuLxt3Jm1XPUfEsI583oX/ga7xOEECCNStwo8jRMEFmXQC3XPiarcveSCsQ5lWwl3a l2v7dy7MOsjMZTMkqyYbnF6W1UEujyDRUjyRWaKS4Wbtmu7WnugVeyc4iItHvrqJ2BEdXFifSJH 7G3oiv3xxXWthDJcu4qOEIc28qu X-Received: by 2002:a05:600c:8b8b:b0:49c:fa20:cbfd with SMTP id 5b1f17b1804b1-49e6cbfeee9mr26096875e9.20.1789228260689; Sat, 12 Sep 2026 08:51:00 -0700 (PDT) Received: from localhost (82-67-6-57.subs.proxad.net. [82.67.6.57]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49e636f7fa2sm154001915e9.15.2026.09.12.08.50.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 12 Sep 2026 08:51:00 -0700 (PDT) From: Jerome Brunet To: tanure@linux.com, Brian Masney Cc: Ulf Hansson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Neil Armstrong , Kevin Hilman , Martin Blumenstingl , Stephen Boyd , Brian Masney , Chuan Liu , Jian Hu , Ronald Claveau , linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 4/4] clk: meson: t7: don't mark sys_ampipe_nand as critical In-Reply-To: References: <20260905153234.133217-1-tanure@linux.com> <20260905153234.133217-5-tanure@linux.com> Date: Sat, 12 Sep 2026 17:50:55 +0200 Message-ID: <1jcxui79k0.fsf@starbuckisacylon.baylibre.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On sam. 12 sept. 2026 at 08:50, Lucas Tanure wrote: > On Sat, Sep 12, 2026 at 1:08=E2=80=AFAM Brian Masney = wrote: >> >> Hi Lucas, >> >> On Sat, Sep 05, 2026 at 04:32:34PM +0100, Lucas Tanure wrote: >> > sys_ampipe_nand clocks the pipeline stage inserted in the bus path >> > between the SD/eMMC controllers and the NIC_MATRIX fabric. It does have >> > identifiable consumers - the three MMC controllers - so marking it >> > critical was the wrong tool: the clock should be referenced from the >> > consumer nodes and claimed by the mmc driver instead. >> > >> > Drop the CLK_IS_CRITICAL flag and update the comment accordingly. >> > sys_am2axi0..2 remain critical as they clock the AXI DMA bus itself and >> > have no single identifiable consumer. >> > >> > Assisted-by: Claude:claude-fable-5 >> > Signed-off-by: Lucas Tanure >> > --- >> > This patch depends on the MMC controllers actually referencing the clo= ck: >> > the dt-bindings, mmc driver and t7 DTS changes adding the "pipeline" >> > clock must land before this patch, otherwise the boot hangs and memory >> > corruption this clock caused are reintroduced. >> >> This series should be merged together in one tree? Which tree? I can >> provide an Acked-by if it should go through the mmc tree. >> >> Brian >> > It's definitely best to keep the series together in one tree to avoid > boot regressions, > but I think the clk tree is the better fit since the core changes > revolve around clock logic. > Could you accept it ? No. This applies on top of another change already queued in the amlogic clock tree. It can't go through the MMC tree at the moment. This clock is not critical in mainline right now, so 1) I could merge this and it and in practice there would be no regression. The problem you had would still be there until the MMC change lands 2) Or you can wait for the MMC stuff to land and re-submit this in the next cycle. Your choice. IMO, (1) is fine. > > thanks > lucas --=20 Jerome