From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 814B9198E75 for ; Tue, 7 Jan 2025 16:47:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736268438; cv=none; b=guzbufHOgm8yixuYNX+60995WRayGpx4zu2fC+n8DGFOAeT8YD1tX/NvUFtCDaXngVlloRelQlzPF6IzLGzwRIah5aKA560n3ijb1wwNJ+V5GtAN8QXI8Ddk1TJbNUq8dh+h0LAnLuRaNzv89f1Wwfv5B6Ofd+dNXF0VzJrLgJ4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736268438; c=relaxed/simple; bh=HRjlYMG1WJb0ZEsiF5gdJ18nn1mIHzcbe9qFsUe3MqM=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=KwYC7K/jiOBT7HKXrnl5mxrrEn+VsQj/UuoTzsgCURnETvSNeQ4sd0xjRvSQ+jnMT6aSfL0FbuhowWKdVOTEa3Qi5Pxc3KtR/A8PB1/ftsy5/hANCP0PhTBrMsdEgy/1hUfFThee/yxjIo2zTXI/MnJTEVRbSsBpJRjOKFIfKVU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=y59JBkAI; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="y59JBkAI" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-43635796b48so95511585e9.0 for ; Tue, 07 Jan 2025 08:47:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1736268434; x=1736873234; darn=vger.kernel.org; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=LfIG31bng2HxoyJWuXm1aKqR+Q5i5Ik2oXWCciq8hzg=; b=y59JBkAIV5Ql9i3xDF0NyXT89PlWFs/XEN+aIhUpGpw0DqbU/cl101eeGo7HWvg0Yt 5ufBTc0MWEBLvJKq90DN8rYBfPikxQnuuYc/Js7NVvPPgEHOQAXDLlqshWS/J3zWz+H9 0awYUEcch2Px0+vJXNoJWdkP3AIhCPSZ0kWfhJe9I+0N1xhroqJXzLUUZIKNpqGwCa8l d/n1/L5NpxDx1ipcMo47iooz+UlhTz5kss5S8h5UnELccd1bvMMPCVsI7YGBB/w4SL0c VTbrzPsXytmBEcrcDvfz9wom1vXps/eM1IrxAjr4rxxpJIeLDjz4TT9/Lz7xNKhSqq2B KKBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736268434; x=1736873234; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=LfIG31bng2HxoyJWuXm1aKqR+Q5i5Ik2oXWCciq8hzg=; b=p4TCRaXMM6Ep7a8JkMXP52pjjfqrztTMmt8v2uBr2iwUgu21cZTv75iOAyrr8XHgEk V2/FcO1Qh+C9xuPehLkOlCA7mdTHFxURNSkxrGOy/ZKLK4EALmTo7ypxrlnPBqfywgKs exkeoYgof9rAGBeeID37DLymvMzH8MSXAriLQuvKe/V77B7ExVVP/wyYjDwhM49P11YQ 0BrFN0m/yW6NkBLBJiF0k8ljZe0F9hzcC2hh4iDK6q0h502AeW89NeBxlHkvust+zGy1 jUGjZ7SdJ1ZBFqEuSyUj6zoLtoUWxqvg2p2sOxDe2imzRXhpOYVSdRgl97YPqtglNKio t5WA== X-Forwarded-Encrypted: i=1; AJvYcCUX/4E5NY3FYVtPFUqyloGPaBVMb7y8jNPYk1rTzLQmWQ2TkPCjxmEbTuXYWW9A7pI2fCFJbQPuZ6MkZxI=@vger.kernel.org X-Gm-Message-State: AOJu0Yy2dFrCyIXA8nCoymmpIPN9uHmWvqwREK86bQtaGoAHZm95Ncr6 phkMcx9KBHehJGysi9vGCzGmG2mx41qeU6ar3gope96LeZCkBc9r8187eV1J6fA= X-Gm-Gg: ASbGnculaqgJkSHmm3DcFOGNxAfl55RHYAV/AMY0h+EFTpBqEbnsm5YiiygzV6jD8YD mDOELVxGBoKDOfqNeV/KnoYMmSYzQKDEa8PRYj6HVBYCLR7+bHnWKUHVdVDLq/+bkNfOOa+rIvg 2wqWN2aioO12QPcIFZB7HR7vI95ukjqKbXiPQyPMvOC+EkCXMxHBLOOqWVVt6FI6fMTlSTHPc3v 2/9+MvuVOXeNxaau/I4pnaWB5DLlswHg12532fQBeItNBC1yzIH4cpD X-Google-Smtp-Source: AGHT+IGmQTKGo+jGOC4/fXhjIYb21MrLqy9TVlZ6yFYHitFQZAEUoZmuJBC1Ro0j7d1OAph9GOuU3g== X-Received: by 2002:a05:600c:3494:b0:434:e69c:d338 with SMTP id 5b1f17b1804b1-436dc1dd4b0mr30072175e9.5.1736268433736; Tue, 07 Jan 2025 08:47:13 -0800 (PST) Received: from localhost ([2a01:e0a:3c5:5fb1:834b:735a:a2e8:9e7d]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43656b013e1sm630609295e9.12.2025.01.07.08.47.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jan 2025 08:47:13 -0800 (PST) From: Jerome Brunet To: Xianwei Zhao via B4 Relay Cc: Linus Walleij , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Neil Armstrong , Kevin Hilman , Martin Blumenstingl , Bartosz Golaszewski , xianwei.zhao@amlogic.com, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org Subject: Re: [PATCH v2 2/5] pinctrl: pinconf-generic: Add API for pinmux propertity in DTS file In-Reply-To: <20241226-amlogic-pinctrl-v2-2-cdae42a67b76@amlogic.com> (Xianwei Zhao via's message of "Thu, 26 Dec 2024 15:57:42 +0800") References: <20241226-amlogic-pinctrl-v2-0-cdae42a67b76@amlogic.com> <20241226-amlogic-pinctrl-v2-2-cdae42a67b76@amlogic.com> User-Agent: mu4e 1.12.7; emacs 29.4 Date: Tue, 07 Jan 2025 17:47:12 +0100 Message-ID: <1jed1ea7vz.fsf@starbuckisacylon.baylibre.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Thu 26 Dec 2024 at 15:57, Xianwei Zhao via B4 Relay wrote: > From: Xianwei Zhao > > When describing pin mux func through pinmux propertity, > a standard API is added for support. The pinmux contains pin > identification and mux values, which can include multiple > pins. And groups configuration use other word. DTS such as: > > func-name { > group_alias: group-name{ > pinmux= , > ; This representation does not seem very generic but more tailored to your use-case. > bias-pull-up; > drive-strength-microamp = <4000>; If you want to add pinmux (aka alternate function) selection as a pinconf prop then I think there should be a single pinmux setting per group, and as many groups as you need per function defined. something like func-foo { group-a { groups = "pin_a", "pin_b"; bias-pull-up; alternate-function = <2>; }; group-b { groups = "pin_c""; bias-disable; alternate-function = <5>; }; }; Something similar is already done to handle different pin bias requirement on single function on amlogic platforms: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/amlogic/meson-axg.dtsi?h=v6.13-rc6#n421 > }; > }; > > Signed-off-by: Xianwei Zhao > --- > drivers/pinctrl/pinconf-generic.c | 130 ++++++++++++++++++++++++++++++++ > drivers/pinctrl/pinconf.h | 4 + > include/linux/pinctrl/pinconf-generic.h | 4 + > 3 files changed, 138 insertions(+) > > diff --git a/drivers/pinctrl/pinconf-generic.c b/drivers/pinctrl/pinconf-generic.c > index 0b13d7f17b32..a4d3c12a80c4 100644 > --- a/drivers/pinctrl/pinconf-generic.c > +++ b/drivers/pinctrl/pinconf-generic.c > @@ -233,6 +233,67 @@ static void parse_dt_cfg(struct device_node *np, > } > } > > +/** > + * pinconf_generic_parse_dt_pinmux() > + * parse the pinmux properties into generic pin mux values. > + * @np: node containing the pinmux properties > + * @pctldev: pincontrol device > + * @pid: array with pin identity entries > + * @pmux: array with pin mux value entries > + * @npins: number of pins > + * > + * pinmux propertity: mux value [0,7]bits and pin identity [8,31]bits. > + */ > +int pinconf_generic_parse_dt_pinmux(struct device_node *np, struct device *dev, > + unsigned int **pid, unsigned int **pmux, > + unsigned int *npins) > +{ > + unsigned int *pid_t; > + unsigned int *pmux_t; > + struct property *prop; > + unsigned int npins_t, i; > + u32 value; > + int ret; > + > + prop = of_find_property(np, "pinmux", NULL); > + if (!prop) { > + dev_info(dev, "Missing pinmux property\n"); > + return -ENOENT; > + } > + > + if (!pid || !pmux || !npins) { > + dev_err(dev, "paramers error\n"); > + return -EINVAL; > + } > + > + npins_t = prop->length / sizeof(u32); > + pid_t = devm_kcalloc(dev, npins_t, sizeof(*pid_t), GFP_KERNEL); > + pmux_t = devm_kcalloc(dev, npins_t, sizeof(*pmux_t), GFP_KERNEL); > + if (!pid_t || !pmux_t) { > + dev_err(dev, "kalloc memory fail\n"); > + return -ENOMEM; > + } > + for (i = 0; i < npins_t; i++) { > + ret = of_property_read_u32_index(np, "pinmux", i, &value); > + if (ret) { > + dev_err(dev, "get pinmux value fail\n"); > + goto exit; > + } > + pmux_t[i] = value & 0xff; > + pid_t[i] = (value >> 8) & 0xffffff; > + } > + *pid = pid_t; > + *pmux = pmux_t; > + *npins = npins_t; > + > + return 0; > +exit: > + devm_kfree(dev, pid_t); > + devm_kfree(dev, pmux_t); > + return ret; > +} > +EXPORT_SYMBOL_GPL(pinconf_generic_parse_dt_pinmux); > + > /** > * pinconf_generic_parse_dt_config() > * parse the config properties into generic pinconfig values. > @@ -295,6 +356,75 @@ int pinconf_generic_parse_dt_config(struct device_node *np, > } > EXPORT_SYMBOL_GPL(pinconf_generic_parse_dt_config); > > +int pinconf_generic_dt_node_to_map_pinmux(struct pinctrl_dev *pctldev, > + struct device_node *np, > + struct pinctrl_map **map, > + unsigned int *num_maps) > +{ > + struct device *dev = pctldev->dev; > + struct device_node *pnode; > + unsigned long *configs = NULL; > + unsigned int num_configs = 0; > + struct property *prop; > + unsigned int reserved_maps; > + int reserve; > + int ret; > + > + prop = of_find_property(np, "pinmux", NULL); > + if (!prop) { > + dev_info(dev, "Missing pinmux property\n"); > + return -ENOENT; > + } > + > + pnode = of_get_parent(np); > + if (!pnode) { > + dev_info(dev, "Missing function node\n"); > + return -EINVAL; > + } > + > + reserved_maps = 0; > + *map = NULL; > + *num_maps = 0; > + > + ret = pinconf_generic_parse_dt_config(np, pctldev, &configs, > + &num_configs); > + if (ret < 0) { > + dev_err(dev, "%pOF: could not parse node property\n", np); > + return ret; > + } > + > + reserve = 1; > + if (num_configs) > + reserve++; > + > + ret = pinctrl_utils_reserve_map(pctldev, map, &reserved_maps, > + num_maps, reserve); > + if (ret < 0) > + goto exit; > + > + ret = pinctrl_utils_add_map_mux(pctldev, map, > + &reserved_maps, num_maps, np->name, > + pnode->name); > + if (ret < 0) > + goto exit; > + > + if (num_configs) { > + ret = pinctrl_utils_add_map_configs(pctldev, map, &reserved_maps, > + num_maps, np->name, configs, > + num_configs, PIN_MAP_TYPE_CONFIGS_GROUP); > + if (ret < 0) > + goto exit; > + } > + > +exit: > + kfree(configs); > + if (ret) > + pinctrl_utils_free_map(pctldev, *map, *num_maps); > + > + return ret; > +} > +EXPORT_SYMBOL_GPL(pinconf_generic_dt_node_to_map_pinmux); > + > int pinconf_generic_dt_subnode_to_map(struct pinctrl_dev *pctldev, > struct device_node *np, struct pinctrl_map **map, > unsigned int *reserved_maps, unsigned int *num_maps, > diff --git a/drivers/pinctrl/pinconf.h b/drivers/pinctrl/pinconf.h > index a14c950bc700..a171195b3615 100644 > --- a/drivers/pinctrl/pinconf.h > +++ b/drivers/pinctrl/pinconf.h > @@ -138,4 +138,8 @@ int pinconf_generic_parse_dt_config(struct device_node *np, > struct pinctrl_dev *pctldev, > unsigned long **configs, > unsigned int *nconfigs); > + > +int pinconf_generic_parse_dt_pinmux(struct device_node *np, struct device *dev, > + unsigned int **pid, unsigned int **pmux, > + unsigned int *npins); > #endif > diff --git a/include/linux/pinctrl/pinconf-generic.h b/include/linux/pinctrl/pinconf-generic.h > index 53cfde98433d..1bcf071b860e 100644 > --- a/include/linux/pinctrl/pinconf-generic.h > +++ b/include/linux/pinctrl/pinconf-generic.h > @@ -232,4 +232,8 @@ static inline int pinconf_generic_dt_node_to_map_all(struct pinctrl_dev *pctldev > PIN_MAP_TYPE_INVALID); > } > > +int pinconf_generic_dt_node_to_map_pinmux(struct pinctrl_dev *pctldev, > + struct device_node *np, > + struct pinctrl_map **map, > + unsigned int *num_maps); > #endif /* __LINUX_PINCTRL_PINCONF_GENERIC_H */ -- Jerome