From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19F42C282DD for ; Fri, 10 Jan 2020 15:38:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D54312077C for ; Fri, 10 Jan 2020 15:38:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="kbS9aImG" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728327AbgAJPiY (ORCPT ); Fri, 10 Jan 2020 10:38:24 -0500 Received: from mail-wm1-f67.google.com ([209.85.128.67]:35902 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728244AbgAJPiX (ORCPT ); Fri, 10 Jan 2020 10:38:23 -0500 Received: by mail-wm1-f67.google.com with SMTP id p17so2446412wma.1 for ; Fri, 10 Jan 2020 07:38:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=34XbeAlwdHrevJvFGbhdrWV+D0kkx/rHJo5vYpwKoBQ=; b=kbS9aImG3m2u5H0U3c/eWbWCfJqrq/Pec1tOBQZBfgc2tFWCAwimXoVijdEKZs52bF SGT5GXH58S/xgFhhHE07NMBNbyHilGdhefgA21GbdcvHdi0x6twnzW5LU90c1eSyI3hG gaLBhUU5GNWQMdVNU3+6dUKND9p867ml3MGmMq2RFCfqhAiqf5wK9BWSfjk/YaSFu4rr UmL5uZRMhEPPhISEPWNDDlm+UIZtEodl8CTkg4afT+vh3SPM7NuErNK5SsO+ZD7il0rW qgdZP1iQMWlcqLSgCwuLj2wP7ZqKs9j0JbpBNc6dfENBFk36rS9N8pbuGL7e3i4oSjdY QuBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=34XbeAlwdHrevJvFGbhdrWV+D0kkx/rHJo5vYpwKoBQ=; b=gof67hk1Rqt2hrNvI+T/twQaosmCAc7iClaF1ZMEDM6dK6UyUUJlDn4Fl1LEULMy6D KVRoeJjuPAhBI4ewTjDzQVdS1fvPa700QgEPxwt+B3QJ4TH060zSeCRdD9lueUhyR2He XNvIt8EBGw6zvQrjgUG1vBqGL44xW35SgRUogpKCn2YCA1DESqHnmTPJBRN8XG8aUHL0 P2wJV1az9NZTfu7AjwKeCOn9tMOXIAhVTAzJ1aep0T1JosNR0p/BDRQMPME+Q/hVf2R6 2dc+feviC3O8lzW0oBKGuAbZ5YpQN/lY4u4kIJ/H4PPpvDVY1PmUmGbhgutu7xz5UJCV IovA== X-Gm-Message-State: APjAAAW89xx6E8ixIt82Q6dBfZM6CceI6QrzdK8g3U+A9NfsXR5pl4pQ zfNqYR11lOD8A9d9kvLOEzFDWw== X-Google-Smtp-Source: APXvYqwI+oUzg01a0UlCmxWZEkis3G4cAvpAGOu4jwJ0ytIagqRVTqSl7r4kEuIGR6OB68oiEAIZ3w== X-Received: by 2002:a7b:c4c5:: with SMTP id g5mr5110999wmk.85.1578670701171; Fri, 10 Jan 2020 07:38:21 -0800 (PST) Received: from localhost (laubervilliers-658-1-213-31.w90-63.abo.wanadoo.fr. [90.63.244.31]) by smtp.gmail.com with ESMTPSA id t125sm2645624wmf.17.2020.01.10.07.38.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jan 2020 07:38:20 -0800 (PST) References: <20191227094606.143637-1-jian.hu@amlogic.com> <20191227094606.143637-5-jian.hu@amlogic.com> User-agent: mu4e 1.3.3; emacs 26.3 From: Jerome Brunet To: Jian Hu , Neil Armstrong Cc: Kevin Hilman , "Rob Herring" , Martin Blumenstingl , Michael Turquette , Stephen Boyd , Qiufang Dai , Jianxin Pan , Victor Wan , Chandle Zou , linux-clk@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 4/5] dt-bindings: clock: meson: add A1 peripheral clock controller bindings In-reply-to: <20191227094606.143637-5-jian.hu@amlogic.com> Date: Fri, 10 Jan 2020 16:38:20 +0100 Message-ID: <1jeew7z5hv.fsf@starbuckisacylon.baylibre.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri 27 Dec 2019 at 10:46, Jian Hu wrote: > Add the documentation to support Amlogic A1 peripheral clock driver, > and add A1 peripheral clock controller bindings. > > Signed-off-by: Jian Hu > --- > .../bindings/clock/amlogic,a1-clkc.yaml | 67 +++++++++++++ > include/dt-bindings/clock/a1-clkc.h | 98 +++++++++++++++++++ > 2 files changed, 165 insertions(+) > create mode 100644 Documentation/devicetree/bindings/clock/amlogic,a1-clkc.yaml > create mode 100644 include/dt-bindings/clock/a1-clkc.h > > diff --git a/Documentation/devicetree/bindings/clock/amlogic,a1-clkc.yaml b/Documentation/devicetree/bindings/clock/amlogic,a1-clkc.yaml > new file mode 100644 > index 000000000000..a708e0e016d9 > --- /dev/null > +++ b/Documentation/devicetree/bindings/clock/amlogic,a1-clkc.yaml > @@ -0,0 +1,67 @@ > +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */ > +/* > + * Copyright (c) 2019 Amlogic, Inc. All rights reserved. > + */ Same here ... read the doc and run the tests please. > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/clock/amlogic,a1-clkc.yaml#" > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > + > +title: Amlogic Meson A/C serials Peripheral Clock Control Unit Device Tree Bindings > + > +maintainers: > + - Neil Armstrong > + - Jerome Brunet > + - Jian Hu > + > +properties: > + "#clock-cells": > + const: 1 > + compatible: > + const: amlogic,a1-periphs-clkc > + > + reg: > + maxItems: 1 > + > + clocks: > + maxItems: 6 > + items: > + - description: Input fixed pll div2 > + - description: Input fixed pll div3 > + - description: Input fixed pll div5 > + - description: Input fixed pll div7 > + - description: HIFI PLL Why is this all caps when the rest is not ? > + - description: Input Oscillator (usually at 24MHz) > + > + clock-names: > + maxItems: 6 > + items: > + - const: fclk_div2 > + - const: fclk_div3 > + - const: fclk_div5 > + - const: fclk_div7 > + - const: hifi_pll > + - const: xtal > + > +required: > + - "#clock-cells" > + - compatible > + - reg > + - clocks > + - clock-names > + > +examples: > + - | > + clkc_periphs: periphs-clock-controller { > + compatible = "amlogic,a1-periphs-clkc"; > + reg = <0 0x800 0 0x104>; > + #clock-cells = <1>; > + clocks = <&clkc_pll CLKID_FCLK_DIV2>, > + <&clkc_pll CLKID_FCLK_DIV3>, > + <&clkc_pll CLKID_FCLK_DIV5>, > + <&clkc_pll CLKID_FCLK_DIV7>, > + <&clkc_pll CLKID_HIFI_PLL>, > + <&xtal>; > + clock-names = "fclk_div2", "fclk_div3", "fclk_div5", > + "fclk_div7", "hifi_pll", "xtal"; > + }; > diff --git a/include/dt-bindings/clock/a1-clkc.h b/include/dt-bindings/clock/a1-clkc.h > new file mode 100644 > index 000000000000..9bb36fca86dd > --- /dev/null > +++ b/include/dt-bindings/clock/a1-clkc.h > @@ -0,0 +1,98 @@ > +/* SPDX-License-Identifier: (GPL-2.0+ OR MIT) */ > +/* > + * Copyright (c) 2019 Amlogic, Inc. All rights reserved. > + */ > + > +#ifndef __A1_CLKC_H > +#define __A1_CLKC_H > + > +#define CLKID_XTAL_FIXPLL 1 > +#define CLKID_XTAL_USB_PHY 2 > +#define CLKID_XTAL_USB_CTRL 3 > +#define CLKID_XTAL_HIFIPLL 4 > +#define CLKID_XTAL_SYSPLL 5 > +#define CLKID_XTAL_DDS 6 > +#define CLKID_SYS_CLK 7 > +#define CLKID_CLKTREE 8 > +#define CLKID_RESET_CTRL 9 > +#define CLKID_ANALOG_CTRL 10 > +#define CLKID_PWR_CTRL 11 > +#define CLKID_PAD_CTRL 12 > +#define CLKID_SYS_CTRL 13 > +#define CLKID_TEMP_SENSOR 14 > +#define CLKID_AM2AXI_DIV 15 > +#define CLKID_SPICC_B 16 > +#define CLKID_SPICC_A 17 > +#define CLKID_CLK_MSR 18 > +#define CLKID_AUDIO 19 > +#define CLKID_JTAG_CTRL 20 > +#define CLKID_SARADC 21 > +#define CLKID_PWM_EF 22 > +#define CLKID_PWM_CD 23 > +#define CLKID_PWM_AB 24 > +#define CLKID_CEC 25 > +#define CLKID_I2C_S 26 > +#define CLKID_IR_CTRL 27 > +#define CLKID_I2C_M_D 28 > +#define CLKID_I2C_M_C 29 > +#define CLKID_I2C_M_B 30 > +#define CLKID_I2C_M_A 31 > +#define CLKID_ACODEC 32 > +#define CLKID_OTP 33 > +#define CLKID_SD_EMMC_A 34 > +#define CLKID_USB_PHY 35 > +#define CLKID_USB_CTRL 36 > +#define CLKID_SYS_DSPB 37 > +#define CLKID_SYS_DSPA 38 > +#define CLKID_DMA 39 > +#define CLKID_IRQ_CTRL 40 > +#define CLKID_NIC 41 > +#define CLKID_GIC 42 > +#define CLKID_UART_C 43 > +#define CLKID_UART_B 44 > +#define CLKID_UART_A 45 > +#define CLKID_SYS_PSRAM 46 > +#define CLKID_RSA 47 > +#define CLKID_CORESIGHT 48 > +#define CLKID_AM2AXI_VAD 49 > +#define CLKID_AUDIO_VAD 50 > +#define CLKID_AXI_DMC 51 > +#define CLKID_AXI_PSRAM 52 > +#define CLKID_RAMB 53 > +#define CLKID_RAMA 54 > +#define CLKID_AXI_SPIFC 55 > +#define CLKID_AXI_NIC 56 > +#define CLKID_AXI_DMA 57 > +#define CLKID_CPU_CTRL 58 > +#define CLKID_ROM 59 > +#define CLKID_PROC_I2C 60 > +#define CLKID_DSPA_SEL 61 > +#define CLKID_DSPB_SEL 62 > +#define CLKID_DSPA_EN 63 > +#define CLKID_DSPA_EN_NIC 64 > +#define CLKID_DSPB_EN 65 > +#define CLKID_DSPB_EN_NIC 66 > +#define CLKID_RTC_CLK 67 > +#define CLKID_CECA_32K 68 > +#define CLKID_CECB_32K 69 > +#define CLKID_24M 70 > +#define CLKID_12M 71 > +#define CLKID_FCLK_DIV2_DIVN 72 > +#define CLKID_GEN 73 > +#define CLKID_SARADC_SEL 74 > +#define CLKID_SARADC_CLK 75 > +#define CLKID_PWM_A 76 > +#define CLKID_PWM_B 77 > +#define CLKID_PWM_C 78 > +#define CLKID_PWM_D 79 > +#define CLKID_PWM_E 80 > +#define CLKID_PWM_F 81 > +#define CLKID_SPICC 82 > +#define CLKID_TS 83 > +#define CLKID_SPIFC 84 > +#define CLKID_USB_BUS 85 > +#define CLKID_SD_EMMC 86 > +#define CLKID_PSRAM 87 > +#define CLKID_DMC 88 > + > +#endif /* __A1_CLKC_H */