From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2561C348C6C for ; Fri, 3 Jul 2026 07:59:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783065546; cv=none; b=fDZexYXOpATK85zHGDE0MJNppmIAafHSPZBfVLEA+5+fn0OBikR577OcX+KCjXYBhNrREspc/ydgY5BeOArcmPauEsoo2V1Yii5fvI/94oK0WspxT/UZDd+I3rAptXaVsaKuMFg28XBRHmFamH6mpAaK0vnfL2PaCAfU6kFMeL0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783065546; c=relaxed/simple; bh=anyS8VtMUVw9saVmNUWxIEx6o2o9RH1ILwD3t8+boWQ=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=tTK1bYuSVJJjCWTMeUVDJXB+aI5wiYB2bQc/p66sABwx1AmeHwYPqzKBNysgJRr6WH8skeXPxm/5ruETotlH+vLml1sZ2EYVpaULV7PbVg/DyVE8QETVPuL/yt9JRME6eKjt5rkvwBolNapPDSs4R7qoWqky1HRG0awiDat1Uh0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=W+pGbZYD; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="W+pGbZYD" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-47640541585so168466f8f.1 for ; Fri, 03 Jul 2026 00:59:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1783065541; x=1783670341; darn=vger.kernel.org; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=Zqjm78soCzOZsah5k4plTO+J9DTAjqlcZkOG5zlqAcQ=; b=W+pGbZYDhpY0He+Ntw+VxXjBx1WkZXrHHKUHOeKBs77L2p4uwBj/xalHNQf01pYAo2 teKgI6DcYtEVNs3ulldN5KOM5AnlfD8FJLIsVpj2FNHrNTZLhM1VBxivlv0k4RsuJoxd 6kaeyQiKWHSVXY6a0+OYiVK7DcNpIMJC1OIEO2RqdG9q8Hhn/tUTSFoMbUMgI2F59Taa PqwhWlCVpHPnDAR1i8rpS263QmQztpF/ol7nQHqay9wumsxkQcF1RrVWDVRUfl4bdOP5 UV5rhjMCgiNVn0FfUoFyflLHqjajcF7DsEFaPrNZyFVzL9My5LAfVnzSlZsy1CYNlblu fZsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783065541; x=1783670341; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=Zqjm78soCzOZsah5k4plTO+J9DTAjqlcZkOG5zlqAcQ=; b=KekCWkKiDVsxfZOdLOGpMc/Mm1amS/j67+kAU26VAwJlhalVOHhKcBoW5YrhGX5+v2 umZvB14e22ZSOu1Ju7LDNOuOR2rOwQvfIffJJEsL4lydTiseTfh3utSfN9l4x4wOv4wY 7bqM2FbmIKMrwueRE6To1bbA3znGRXeH6GpeMbma/Hqxnz4o32G7EYxYUgEgwYw8fYIn tkiodEvrwYOaOBjqaLWv8Fogz21MpiQdqhvwwBxSESGTyIqqfijSc3C/52LImXXnDMkN CZq/nDCch351vZzxirjtEOofrwr1R6bpjCs3BXc/Ubd1bEurQjRyK25RGVYiDx2T9Rwt ihAQ== X-Forwarded-Encrypted: i=1; AHgh+Rr9AJcUhwTnRjzW3pziobSN0mfDHL+4BJrrEhjvK3m69MovMvOmk1KOcXVojus1RxY8pq1kM2R2kFvRu84=@vger.kernel.org X-Gm-Message-State: AOJu0YwNOQJ/4fIusPA/k3cyybbVSn6QFwHW4HYdjK5Ra1NHUhZqHTfF xt3lqqmbtOcX7TkmE5sfkDSc/GSiD4HgPI8I16ajrVEYZ1n1P+rxT+5QQyGUKgRjuuQ= X-Gm-Gg: AfdE7cmiRNeWKMxcx6HgJ0j7UzvFLo0tna1xBAUvcm/ciIYwg8kOu4cNR59I/6lmE+e hyLr3IktT910UAFtQexBkLlRlVScSzN8hUNlm7dvxEbdRzgguE1j2hpvNpujH6cIDJIsCoil8m/ TSUTNgYmP/feuEf6NUoevqqjf759cWFPAO+SfFmEITZm+90Zae43gPSbJPVfRYRlJ8jOMlWXj5N XKNr5ZinKb3UdIgC0Qe17eryEdVEsLG40teM62jnN73TzVBdUFNZnZJJ+utqtgHcWxTgAYbMQPW 4s2Lu5E5yKiRPddIL6LPHJnTNsmfXCfRrOpMa88+YaID/KirqQLJ+R2yL9VAm084yqhjfPPors2 vDWlxqCvIJwvm3S9uiCBuGm9OpOEk26BEt7FosfPNjZGAMqncbLReUpjpA+IP7W89JDAimsjXco WkXVUEx/gB6gFeAQWJvGBRgw== X-Received: by 2002:a05:6000:2310:b0:46f:e796:c3fc with SMTP id ffacd0b85a97d-47757c6d1e4mr14250190f8f.25.1783065541604; Fri, 03 Jul 2026 00:59:01 -0700 (PDT) Received: from localhost ([2a01:e0a:3c5:5fb1:fb6a:cb8b:b7f7:bb42]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-477dde19fd3sm16565369f8f.25.2026.07.03.00.59.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jul 2026 00:59:00 -0700 (PDT) From: Jerome Brunet To: Valerio Setti Cc: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Neil Armstrong , Kevin Hilman , Martin Blumenstingl , linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] ASoC: meson: aiu-formatter: remove pipeline reset from prepare In-Reply-To: <20260702-fix-24-bit-i2s-playback-v1-2-bcd3a43fe32a@baylibre.com> (Valerio Setti's message of "Thu, 02 Jul 2026 12:56:41 +0200") References: <20260702-fix-24-bit-i2s-playback-v1-0-bcd3a43fe32a@baylibre.com> <20260702-fix-24-bit-i2s-playback-v1-2-bcd3a43fe32a@baylibre.com> User-Agent: mu4e 1.12.9; emacs 30.1 Date: Fri, 03 Jul 2026 09:58:59 +0200 Message-ID: <1jfr20ijwc.fsf@starbuckisacylon.baylibre.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On jeu. 02 juil. 2026 at 12:56, Valerio Setti wrote: > 'aiu-formatter-i2s' already performs the very same reset in > 'aiu_fifo_i2s_trigger' for all relevant trigger scenarios. There is no > need to duplicate the operation in the formatter. > > Signed-off-by: Valerio Setti Reviewed-by: Jerome Brunet > --- > sound/soc/meson/aiu-formatter-i2s.c | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/sound/soc/meson/aiu-formatter-i2s.c b/sound/soc/meson/aiu-formatter-i2s.c > index b4604734fe88..cb554c2e7ce4 100644 > --- a/sound/soc/meson/aiu-formatter-i2s.c > +++ b/sound/soc/meson/aiu-formatter-i2s.c > @@ -13,7 +13,6 @@ > #define AIU_I2S_SOURCE_DESC_MODE_8CH BIT(0) > #define AIU_I2S_SOURCE_DESC_MODE_24BIT BIT(5) > #define AIU_I2S_SOURCE_DESC_MODE_32BIT BIT(9) > -#define AIU_RST_SOFT_I2S_FAST BIT(0) > > #define AIU_I2S_DAC_CFG_MSB_FIRST BIT(2) > > @@ -55,11 +54,11 @@ static int aiu_formatter_i2s_prepare(struct regmap *map, > { > /* Always operate in split (classic interleaved) mode */ > unsigned int desc = 0; > - unsigned int tmp; > > - /* Reset required to update the pipeline */ > - regmap_write(map, AIU_RST_SOFT, AIU_RST_SOFT_I2S_FAST); > - regmap_read(map, AIU_I2S_SYNC, &tmp); > + /* > + * Pipeline reset is already implemented in aiu_fifo_i2s_trigger() at > + * trigger time. > + */ > > switch (ts->physical_width) { > case 16: /* Nothing to do */ -- Jerome