From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 577A22D0C72 for ; Thu, 3 Jul 2025 08:35:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751531757; cv=none; b=NI9buoXEk11wYMD7sOwCFL0S/4QgsGQnSEU0rB9x3eCTFPgH3X1NU5nrOP2kz4gDw4zOUB4PU6UAF2Vtjd2BYHuPxHUW3O87HB+OQuEO+fnI3qCgSCrYgHzGyzx5idAcG4MyfTMG/Xok/Q8O+Od/FhxBERg2++Ia4hdo1mQoJR4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751531757; c=relaxed/simple; bh=opkUPpjM1YMmWM/mSYK4uQEZDWo6Bde587pwQjA2Cfg=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=WC183s7mRwHr4xUqQ/qItZqW7MIQSo7+PI7kJqxXuevYTeL0ojHuFvHKN5GNgRqT4qnSUD79Ps1n9yVZns0ImM0WAbuUjkP6m0LyoTyK/Dhql5Xchvl9CFmXrLfIs35NrOV1Ap4KOsGPCJ0HqQNfryJFIeBad6HXyaPoKab+Dek= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=QBRLDs/v; arc=none smtp.client-ip=209.85.221.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="QBRLDs/v" Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-3ab112dea41so2906801f8f.1 for ; Thu, 03 Jul 2025 01:35:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1751531754; x=1752136554; darn=vger.kernel.org; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=+Z/tFNKm/X+bKuxHPpGCjHGMiM6UDjlBSDIyMJdyoOM=; b=QBRLDs/v1CFBM5hyMtMclsc92ogEe4FRv9lFxI2oO0Jp08QRRSkYCf7OHBWXFraU3l v5+6I/ZwL03A17vsed2AI0cX0K6kUmmWy6+VZwUxm4L6JWRB+42sdlWLgo23NelZDB/C Odpxsz56y7rZ0qaNCO1y6HhP5301JjGDH1fbsTRftWdkeQJ6GlZhT4ZGsja6CWzF3SrB mnl0Nheds6mLm4ZelrcGBTwEJ3KdM+hDVJ/Q8DE4S+jHoGakdOpAprHCYqFrqQBoUwvL espK1HJV5soS0JrFJCLCognlWHg//Cb61RUa7B98vCzWZdloQxBbMYFWfnN35GOyiQXO 2s7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751531754; x=1752136554; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+Z/tFNKm/X+bKuxHPpGCjHGMiM6UDjlBSDIyMJdyoOM=; b=peAr1vV23GdeeGxzzHgn65X4nRseCJrTumGXKeT6LMHajdapeJfSZWL4hOQ2HRxGqM fByFoboRHgI8P/F4L/aV1nf3XW9A6tmg9kfiUT84oDWCV+wZzIJqNS6/dB4HCWeZ0kz8 GJnZvSosXYg8clKHjgzoyc5tB7+fCl4m9YLmqrNUN9v3FrwNOULpUFV3VPRrtR+5tKWk r4rQaDOQ3r5yx3QPKfwm1RRxqNI1YxIEPXxIGjTGlEFFQ/7xRtbddA3n08tGfOo+Y8ZJ NdPmGZ+fzDbcUGACk0w3/YC1qtfhm89M6m2hov/g5GmarLRYAt4tFy1qE10jfykaGcSl Z8dg== X-Forwarded-Encrypted: i=1; AJvYcCUcDA2IA6AzBulLf7nNCcFmcvS8tcEM9XJk5nJGYWy8CJEWHXBJCAMUwKeqJQe5S0JUnrb1ghPY7D69MZg=@vger.kernel.org X-Gm-Message-State: AOJu0YwZcUqEzgNkhbHk2xPbGgdrTi1/wa5xPpyhcqbmB1C8brRK05OO 00WiBBI64GXgJtq3dXmAzPctGaoWLiYY9HsTTa1RD4vA+N6s50BHU2Z9XHJhJ7P98HQ= X-Gm-Gg: ASbGncsD9sVBo3ZS3Aye7DvLT++WEIBNfUpXZeB7urAn+F5vylnU6bs+q+oyIzhWiJI IvXbEaQ0zkk7ErHQyfB6gm/y4nqPRVh7FAgBYIUt7Uzg80NtMmDvHL36zRmTwfUaoPO4RLrSnJK qn24UdDlP1/PUndt+cGUlnNdqhGMYb/CYZ4DtJobx+fLyVMi5ujSxxswS5UW/XJUQ+8vN5tbgtj UZbenSCQRwEDFmdWJ0kGY5/cMTg01pKUfc0zlkJcSBbN5BVHxP24GHgVBaQcw1EedFVaj49sff7 B3thMXRO8mE3ylGe7+gOGnli56OlIzSXo3xcPqbu43omQ0X8ru6NoTB1xSS18O+asuo/aiYS X-Google-Smtp-Source: AGHT+IE3U4A+14gN1VsA8pGM9HPiNTu4gifAOlHAGEBIiYxAf/3iGRWCVM2COik1DJdkjDU8qXICew== X-Received: by 2002:a05:6000:4a01:b0:3a5:8cdd:c174 with SMTP id ffacd0b85a97d-3b32d4d0ab9mr1866465f8f.26.1751531752716; Thu, 03 Jul 2025 01:35:52 -0700 (PDT) Received: from localhost ([2a01:e0a:3c5:5fb1:1b4c:1be9:25d0:5634]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-3a892e59884sm17658899f8f.80.2025.07.03.01.35.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Jul 2025 01:35:52 -0700 (PDT) From: Jerome Brunet To: Chuan Liu Cc: Neil Armstrong , Michael Turquette , Stephen Boyd , Kevin Hilman , Martin Blumenstingl , linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 16/26] clk: amlogic: add probe helper for mmio based controllers In-Reply-To: <68134d81-e15d-41e9-933d-95190af9b989@amlogic.com> (Chuan Liu's message of "Thu, 3 Jul 2025 11:29:07 +0800") References: <20250702-meson-clk-cleanup-24-v1-0-e163c9a1fc21@baylibre.com> <20250702-meson-clk-cleanup-24-v1-16-e163c9a1fc21@baylibre.com> <68134d81-e15d-41e9-933d-95190af9b989@amlogic.com> User-Agent: mu4e 1.12.9; emacs 30.1 Date: Thu, 03 Jul 2025 10:35:51 +0200 Message-ID: <1jh5ztd63c.fsf@starbuckisacylon.baylibre.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Thu 03 Jul 2025 at 11:29, Chuan Liu wrote: >> >> +static const struct regmap_config base_clkc_regmap_cfg = { >> + .reg_bits = 32, >> + .val_bits = 32, >> + .reg_stride = 4, >> +}; >> + > > > Since 'base_clkc_regmap_cfg' is only referenced within > 'meson_clkc_mmio_probe()', > we should move it as a local variable inside the function. This would be > more > logical and may optimize code size (During compiler optimization, only > critical > data needs to be preserved rather than the entire structure?) > > >> +int meson_clkc_mmio_probe(struct platform_device *pdev) >> +{ >> + const struct meson_clkc_data *data; >> + struct device *dev = &pdev->dev; >> + struct regmap_config regmap_cfg; Actually a partial init would do the job nicely. I'll refine this on v2 >> + struct resource *res; >> + void __iomem *base; >> + struct regmap *map; >> + >> + data = of_device_get_match_data(dev); >> + if (!data) >> + return -EINVAL; >> + >> + base = devm_platform_get_and_ioremap_resource(pdev, 0, &res); >> + if (IS_ERR(base)) >> + return PTR_ERR(base); >> + >> + memcpy(®map_cfg, &base_clkc_regmap_cfg, sizeof(regmap_cfg)); >> + regmap_cfg.max_register = resource_size(res) - 4; >> + >> + map = devm_regmap_init_mmio(dev, base, ®map_cfg); >> + if (IS_ERR(map)) >> + return PTR_ERR(map); >> + >> + return meson_clkc_init(dev, map); >> +} >> +EXPORT_SYMBOL_NS_GPL(meson_clkc_mmio_probe, "CLK_MESON"); >> + >> MODULE_DESCRIPTION("Amlogic Clock Controller Utilities"); >> MODULE_LICENSE("GPL"); >> MODULE_IMPORT_NS("CLK_MESON"); >> diff --git a/drivers/clk/meson/meson-clkc-utils.h b/drivers/clk/meson/meson-clkc-utils.h >> index 26cd47544302b28ca1a342e178956559a84b152a..b45f85f630d7190fb6509b088f05f17ca91fa1c8 100644 >> --- a/drivers/clk/meson/meson-clkc-utils.h >> +++ b/drivers/clk/meson/meson-clkc-utils.h >> @@ -25,5 +25,6 @@ struct meson_clkc_data { >> }; >> >> int meson_clkc_syscon_probe(struct platform_device *pdev); >> +int meson_clkc_mmio_probe(struct platform_device *pdev); >> >> #endif >> >> -- >> 2.47.2 >> >> >> _______________________________________________ >> linux-amlogic mailing list >> linux-amlogic@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/linux-amlogic -- Jerome