From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 328573921F5 for ; Wed, 14 Jan 2026 10:41:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.66 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768387270; cv=none; b=DH826ggs8py0T9wj+NFJHGb0x9HTO75LxKIk5fOsI03YOtPRghB98oTkgTzW5DORxMaQM3s5en3RwBVmUqgALJ5xvzAAO7VQSDQm2aByztvvR1X+dOrIRYFabHKUyaNEAG1Um3LlHbQJ/yd0f5MSDtfbaKlxyfmbmU+UcHdyfEg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768387270; c=relaxed/simple; bh=m3a1sMwjKym+V2GToCzh+9/lwn01kyYPCDD/yh27vrI=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=VDmtzxkbxau4R19ndYIA3Bq6eL3aKLsn7dCEyL6FdXowzxn/eiZhtkGptdtNaDxZOX6OG0pW2vFEDDiw8vjRAdAhmfWaInYKZ7S3YCQestYgfl3el17uMuozHIBivr4c1+4Oh6VZx1I9+M3lRUhA8teIjNYaMYePEc9y6iaNOeI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=bLQx6GbL; arc=none smtp.client-ip=209.85.128.66 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="bLQx6GbL" Received: by mail-wm1-f66.google.com with SMTP id 5b1f17b1804b1-4779adb38d3so57359825e9.2 for ; Wed, 14 Jan 2026 02:41:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1768387265; x=1768992065; darn=vger.kernel.org; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=+NcxQNU+z+mjpVWzVO5zIslJ+Ha+xCleufzRRdU3nw0=; b=bLQx6GbLuB+GdAwEeeBAMMqD+JdAVuUSapljAcSKNC4Q5TpBZSDVlsNYJaZ1i4Q/rF wkqHK4azUxQuIanOxEfvEGLwFQOpwmj+vRPYHd6ptvzUaEIX+XoRyoM6lfSKwYrv1msw lVXHEnYJ6DekDnkQVUZTkxCy4WxTk3UcUgumYmsgnNTqkAbcx6UolmIEh6A/k7fuHlVV 2azpPsZPuJNyOx0uWbBJDCt6DGsiYj1xW4C8mKyD0vCAZ2pTlLQOZfy74k85xScPkAfa XgOjk/IfwubCF7RFBj/BpPv5QxVdX3BAVCJfLyjfDqO280v465SUDUcAB9eIfNfwixfh 6IcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768387265; x=1768992065; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=+NcxQNU+z+mjpVWzVO5zIslJ+Ha+xCleufzRRdU3nw0=; b=Deqc83oVswsTAOpycnlZ0tFpCzM120zjWOypWgbzw2jW7y97/gz+qmxRdHtw/L/WLn XoJCXctnmn2uXGwLP29mkkXEnCFkCRVrUhU/3D4BekWTHEYGZTx7a1ee6HSwdNYhP/cI vLaFX9i3lfx0N6uJIyYYU7vhNs0mt1W5E/hGr1gL0zbDnyE9MhQh99WpKQ7v1Q7047lL JtfFmU6YZVyV+mgwqIl0QaqXh6HncZXA4iFsBDe7HFV6DFVSlbPLwmmLa+O3a2gAy6zX M9l2lQUP9iPJFC8/J6D2tFJtY7YrlJELrTb5G1Fz53l0N1QT2A5MSkbfcjYkAW2U1Q5k 87zg== X-Forwarded-Encrypted: i=1; AJvYcCWNr0dPYLr+3J2U7TQF0a642j45mgQUMryKoQ+yw1r2QUqricWEH17BrGVIO34dXNXsKWyOE4C0C+P9gkY=@vger.kernel.org X-Gm-Message-State: AOJu0YxTGF0PC7HyfAq0BRUy1FbrSZjwgEdpUfysWykWzi8H5vAdISq6 PkhufeKXLfhL9Oyz7qMwBWAeaQUcsr5veCuVzQKQUUorLBwTA+Rw1QfxIDbwd+Dy93Y= X-Gm-Gg: AY/fxX7TCOb1mBg0Np9aNNbuadk6WXmn/qatNAMminTqWg8Ddmg/kML5942kaNPmMfs RE6SMp8cFHjc0XhNlkk65UAJRq4RPSVenaTZuLzsY2Jyw/RttLB9HgdBViydjGpx1efu07V2D7S LVgvKfY+MWatKmiQ/LhOcX7b6HUhHLicjAiIerqnN2Sw/UU1Sb0jFv3Q+THPXuRI551gY/W/736 JWt5WGsYA4akM5VKZis5CxFeOQiorZYBroxPV4rOTOnzxSvMwwyPBSRG7XQe9KC2lbN4W3+tPjd noiz82rIr85NkYJbjltmPmAmPVHFvJwu0Dvd30/XqUVJodXaSPYAQvzmswLo10BArEKQmOuzLAP g72Btiu3IJke7mKMTZjPLPYqwlmCzLKlFvWqUAhJ+rNdCI1cVsYpiOvytEH7MczbN6cirGQZQIS YqzlAkKNewMw== X-Received: by 2002:a05:600c:5490:b0:47e:e20e:bba4 with SMTP id 5b1f17b1804b1-47ee3356e79mr22358195e9.18.1768387265370; Wed, 14 Jan 2026 02:41:05 -0800 (PST) Received: from localhost ([2a01:e0a:3c5:5fb1:f2cc:bd72:2de3:86cd]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-47ee578d37esm21654835e9.1.2026.01.14.02.41.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Jan 2026 02:41:04 -0800 (PST) From: Jerome Brunet To: Neil Armstrong Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Kevin Hilman , Martin Blumenstingl , Xianwei Zhao , Nick Xie , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] arm64: dts: amlogic: s4: assign mmc b clock to 24MHz In-Reply-To: (Neil Armstrong's message of "Wed, 14 Jan 2026 10:05:35 +0100") References: <20260114-amlogic-s4-mmc-fixup-v2-0-7e9ab5f12286@baylibre.com> <20260114-amlogic-s4-mmc-fixup-v2-1-7e9ab5f12286@baylibre.com> User-Agent: mu4e 1.12.9; emacs 30.1 Date: Wed, 14 Jan 2026 11:40:59 +0100 Message-ID: <1jikd4xyro.fsf@starbuckisacylon.baylibre.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On mer. 14 janv. 2026 at 10:05, Neil Armstrong wrote: > On 1/14/26 09:56, Jerome Brunet wrote: >> The amlogic MMC driver operate with the assumption that MMC clock >> is configured to provide 24MHz. It uses this path for low >> rates such as 400kHz. >> This assumption did hold true until but it now, but it is apparently >> not the case with s4. The clock has been reported to provide 1GHz >> instead. This is most likely due to how the bootloader is using the MMC >> clock on this platform. >> Regardless of why the MMC clock rate is 1GHz, if the MMC driver expects >> 24MHz, the clock should be properly assigned, so assign it. >> Reported-by: Nick Xie >> Closes: https://lore.kernel.org/linux-amlogic/20260113011931.40424-1-nick@khadas.com/ >> Fixes: 3ab9d54b5d84 ("arm64: dts: amlogic: enable some device nodes for S4") >> Tested-by: Nick Xie >> Signed-off-by: Jerome Brunet >> --- >> arch/arm64/boot/dts/amlogic/meson-s4.dtsi | 4 ++++ >> 1 file changed, 4 insertions(+) >> diff --git a/arch/arm64/boot/dts/amlogic/meson-s4.dtsi >> b/arch/arm64/boot/dts/amlogic/meson-s4.dtsi >> index 9d99ed2994df..62538fd9db6b 100644 >> --- a/arch/arm64/boot/dts/amlogic/meson-s4.dtsi >> +++ b/arch/arm64/boot/dts/amlogic/meson-s4.dtsi >> @@ -838,6 +838,10 @@ sd: mmc@fe08a000 { >> clock-names = "core", "clkin0", "clkin1"; >> resets = <&reset RESET_SD_EMMC_B>; >> status = "disabled"; >> + >> + assigned-clocks = <&clkc_periphs CLKID_SD_EMMC_B>; >> + assigned-clock-parents = <0>; > > In this case, assigned-clock-parents should be dropped. > Dunno why I thought that was always required. I'll fix it and the other instances > Neil > >> + assigned-clock-rates = <24000000>; >> }; >> emmc: mmc@fe08c000 { >> -- Jerome