From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83C57C38142 for ; Thu, 19 Jan 2023 11:20:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230126AbjASLUI (ORCPT ); Thu, 19 Jan 2023 06:20:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60290 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229518AbjASLT4 (ORCPT ); Thu, 19 Jan 2023 06:19:56 -0500 Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6CD0764DA1 for ; Thu, 19 Jan 2023 03:19:54 -0800 (PST) Received: by mail-wm1-x332.google.com with SMTP id e19-20020a05600c439300b003db1cac0c1fso1837387wmn.5 for ; Thu, 19 Jan 2023 03:19:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:from:to:cc:subject:date:message-id:reply-to; bh=2foPOEb90UyA/MJALqYP5FbUTQrze1RPaG+nVIqRt0I=; b=Ieu72sdcmYgGG3PlfHBUHxJl3gj5WnemeYAPms2q289TVEz15wrbeBvyW6Ieiz9sgU h6NIXPwaRQ16ix6KvIS02bHmZgstuFhggpao9Aa6KBtuJFC0kAaXc5pQN36Cax/QnUoK 2PUvMD74UXn0x24Q/bOIWHIM2IHyTpLNp8qrYv+8USV+E9vZ1cvDNw8M2vPhnFxYlB/E nQGXh9EzF5wVMNFlQWPdVWg4sKPcEWZy0+O9n64a2FNqFC+EFvSJGFnH2kPerxUQyw3C 5tUbad55722X1YpjyDPLvn6IUptP64Cdnc4moxTUJJ8qfmS+SZFyu02BgslurtJhOrs5 0VWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=2foPOEb90UyA/MJALqYP5FbUTQrze1RPaG+nVIqRt0I=; b=ibaiQqWyUm91p4t2tgRaqm9g5afuRyYAPahjmBD8RYvjh1pby+sH9+dBESI7cBcvf2 IBnjvWpSo25qR7avi2htzzJTu2TZ26DCOLGpksrlLsrlHzvBqQSR7Gm1GYrLsq2CEaCZ Du0UcuYOQam+bMTyC/BsC2+TOtMv4iaaFvVAxnLB/vTWDHe7oKbbBPzc9D0oXaPbSUfG aEmuQ+n4ds81eAbWAW57391G3bWYmZXgj/PcHBaFvBJSH6qYjMK4BweXaf0PrzjARaxh TBRVHFdSkWIvhR5arAcOfYfYiuixc+j55BPgVKqq+v0cZfKERebRbq/UxjqmIxo/5+6x 5OLg== X-Gm-Message-State: AFqh2krKfrwwlbAY8/t7M6AIHpQi9/4jxs2f2N7zR35d1byEb8pR7vGw vQ3S9Z4A9OIl2O/Vu+TDPrOF6w== X-Google-Smtp-Source: AMrXdXvNO3Z4PWh6/DvCNgXXqNwnt7jnRnqMnqd9gIR5iYvzRWp6qf4higUbmzz63oEaUcdAIP4haQ== X-Received: by 2002:a1c:750e:0:b0:3da:fcf6:7146 with SMTP id o14-20020a1c750e000000b003dafcf67146mr9912297wmc.14.1674127193017; Thu, 19 Jan 2023 03:19:53 -0800 (PST) Received: from localhost (laubervilliers-658-1-213-31.w90-63.abo.wanadoo.fr. [90.63.244.31]) by smtp.gmail.com with ESMTPSA id l27-20020a05600c2cdb00b003d99da8d30asm4909913wmc.46.2023.01.19.03.19.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Jan 2023 03:19:52 -0800 (PST) References: <20230116074214.2326-1-yu.tu@amlogic.com> User-agent: mu4e 1.8.10; emacs 28.2 From: Jerome Brunet To: Yu Tu , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Rob Herring , Neil Armstrong , Kevin Hilman , Michael Turquette , Stephen Boyd , Krzysztof Kozlowski , Martin Blumenstingl Cc: "kelvin . zhang" , "qi . duan" Subject: Re: [PATCH V6 0/3] Add S4 SoC PLL and Peripheral clock controller Date: Thu, 19 Jan 2023 12:18:30 +0100 In-reply-to: <20230116074214.2326-1-yu.tu@amlogic.com> Message-ID: <1jilh2ydns.fsf@starbuckisacylon.baylibre.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon 16 Jan 2023 at 15:42, Yu Tu wrote: > 1. Add S4 SoC PLL and Peripheral clock controller dt-bindings. > 2. Add PLL and Peripheral clock controller driver for S4 SOC. > > Yu Tu (3): > dt-bindings: clock: document Amlogic S4 SoC PLL & peripheral clock > controller > clk: meson: S4: add support for Amlogic S4 SoC PLL clock driver > clk: meson: s4: add support for Amlogic S4 SoC peripheral clock > controller You are adding 2 controller driver with this series. Making 2 driver patches on clk/ is good. Please do the same for the bindings > > V5 -> V6: Change send patch series, as well change format and clock flags. > V4 -> V5: change format and clock flags and adjust the patch series as suggested > by Jerome. > V3 -> V4: change format and clock flags. > V2 -> V3: Use two clock controller. > V1 -> V2: Change format as discussed in the email. > > Link:https://lore.kernel.org/all/20221123021346.18136-1-yu.tu@amlogic.com/ > > .../clock/amlogic,s4-peripherals-clkc.yaml | 104 + > .../bindings/clock/amlogic,s4-pll-clkc.yaml | 50 + > MAINTAINERS | 1 + > drivers/clk/meson/Kconfig | 25 + > drivers/clk/meson/Makefile | 2 + > drivers/clk/meson/s4-peripherals.c | 3874 +++++++++++++++++ > drivers/clk/meson/s4-peripherals.h | 218 + > drivers/clk/meson/s4-pll.c | 875 ++++ > drivers/clk/meson/s4-pll.h | 88 + > .../clock/amlogic,s4-peripherals-clkc.h | 131 + > .../dt-bindings/clock/amlogic,s4-pll-clkc.h | 30 + > 11 files changed, 5398 insertions(+) > create mode 100644 Documentation/devicetree/bindings/clock/amlogic,s4-peripherals-clkc.yaml > create mode 100644 Documentation/devicetree/bindings/clock/amlogic,s4-pll-clkc.yaml > create mode 100644 drivers/clk/meson/s4-peripherals.c > create mode 100644 drivers/clk/meson/s4-peripherals.h > create mode 100644 drivers/clk/meson/s4-pll.c > create mode 100644 drivers/clk/meson/s4-pll.h > create mode 100644 include/dt-bindings/clock/amlogic,s4-peripherals-clkc.h > create mode 100644 include/dt-bindings/clock/amlogic,s4-pll-clkc.h > > > base-commit: 1b929c02afd37871d5afb9d498426f83432e71c2