From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C05C532AADA for ; Mon, 5 Jan 2026 09:14:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767604478; cv=none; b=VOC7Sj5fcFW3vSjQaEOZkBeHroRAkhBsRv0H21L0KdvjwgZxYMqPfRdGXz5TeChDNmIou6tanhxz7/hDZg4DVoM0UtuhGU5xe9yPsDfWBPPmUURv9rcYSotmMWApm5yZkSnL/A3IfMPtj+0hRGXt74FmbF9s47I6N12M+9FDsTs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767604478; c=relaxed/simple; bh=QW8t2JNOdvI2uXm6GTQqMR2BYg3t2UgJyOvON6wsQF4=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=bfa1lA92qgI5HiPPsJBjAHcXjB1Db1Kvt7pcM0EsmHAcokvPIT+aiou8lvtOiWTp9krsbVebgpoSQRxXawaOWXWbJf8Yvnz/nC7Pvu0t2pvfso2VuNpetKxJpnBl+wLWR9uE7LOsHJIPspcgMfulX/I9JPytqTkSxXt8Kk20uHQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=VZYLsQzK; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="VZYLsQzK" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-4779a4fc95aso6667185e9.1 for ; Mon, 05 Jan 2026 01:14:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1767604474; x=1768209274; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:user-agent :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=miCvpSGVqVVCNMF4tIx1RWrVqnyi6qhzDTvcjYnjzjQ=; b=VZYLsQzKlwtV8sZxzeBGSWcaPHwI32eqSX5m3z0HRr2q9Zesf3fC0AfIn0armQTm0/ OUExTGNwloIss5vTKfN5z/xO5apTuUQDjrXnUY/yzq4NmLNxUkKhFBE2FQ97BTwZx9nn Sp4Rs/Vn8lPgBXcUX8yIUaXBbvWsicdyOo4W46ONheLgny//8TBaVd3TaIqqZQV3uoPD U6zgcbUk0lGISLFFOYBpntOT/ms694jK5Xy8A4MVQAllatRjwck7dQEHZe8hTM/LIaDo W/530rlzZUV6U/R9spb0JXNmN8HGoydQR+5u4aM6HvHeHSrriRRMN13R9kKpS+8tMpa6 FdcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767604474; x=1768209274; h=content-transfer-encoding:mime-version:message-id:date:user-agent :references:in-reply-to:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=miCvpSGVqVVCNMF4tIx1RWrVqnyi6qhzDTvcjYnjzjQ=; b=KbHG5n9BM07UUTMdtJHD++mSI8XHWNhcSc5M74tovIDmxUip3sh4lIyFRu8uPd9zC9 N5LepfSXbAY9/vTzC/ibmsD81I5qyu2ay1Q4NdPkdUk74kxiSN3TBlNEnLa6KLOOWSvx gdtsUzmRRb8SnGZfanBar8jr74IEsasoiYqeKiW8yUM/HbRUIPKGxjGw8i6J5njwg7S8 yXP1G0aLGVCbQGwAJ6MgMd94Ku0LX79MNINYv8kALXYbd5OzJlllzw0vpp49pxFsU4vp iifjQbMOiR2YE8DQcaxIOdawDk90YohTmpry1BjrN8AnfZ0H//Lamzy4PoAnxau7u+CC hduA== X-Forwarded-Encrypted: i=1; AJvYcCVOEedxPrCGHmqzMsQPP7jlUdHYDrhWo2aY9DY8KVfcTixpybXc3vfwBjSHu8K35KafrrFGLkHEDC0koEE=@vger.kernel.org X-Gm-Message-State: AOJu0YzXaw6aLlXiHiHQ8gWQzYSHXHQrcMIUDnzKIcPI+C7wnF5JgC5E hop++zC+w63KMKdKc2lgFt63SUsKCZPpIBABJcC2FxVu27jW07f7A2+bqC84jr/dVXQ= X-Gm-Gg: AY/fxX4X7d0u1CvrFImHsXSGslDio8rOvaDKOLz73cMgY9a6JdkR09vLOtRpDSN20Dm T/z9n8eQUU0U6RngjgqTx5pq0fz6yCypQnKrgPf+glfBJrOclVE35EepwKuvc4RtkZL3X0THfxW WZTcp2q8XzZq42JKWf1GiGtlFbec6iQ5HawLeR8n7cdSb6E2G9erVNa1jYxsfihnMmh8l18jEwO ZRfYeHVenD8q0y4kLiElvc7g8BO8YOsrcIXL8YLaqsiFpUsB45K7aY5CIiFQW/c+yJ+fUXZ92NZ tWHg3aWGVRVNndTk/yDfAX3NGxizqPMcnriMyfHO4xJDmOoWsxU9SMOQxGLTQ3nX/RRTf3TZR2e R8BO12JrRfBm3e7CfJ5chQWR2GMfy4eUwNKm2VSj+33JPfMr7H2xxX/BfhY9WMV6y/TJPr7hUb5 lU7zok1TZW X-Google-Smtp-Source: AGHT+IHg/Mv8ok8g3lfkv+f6Gs1iCHZthZ9+dvCaKIuCn41ycCh3KmnkNqkRkT2jAbCijygn0KRwvA== X-Received: by 2002:a05:600c:4704:b0:46f:a2ba:581f with SMTP id 5b1f17b1804b1-47d6ba8900dmr100501615e9.16.1767604474097; Mon, 05 Jan 2026 01:14:34 -0800 (PST) Received: from localhost ([2a01:e0a:3c5:5fb1:b336:bcf:8603:f6e1]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-47d6d143f6asm147207955e9.6.2026.01.05.01.14.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Jan 2026 01:14:33 -0800 (PST) From: Jerome Brunet To: Chuan Liu Cc: Chuan Liu via B4 Relay , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Neil Armstrong , Xianwei Zhao , Kevin Hilman , Martin Blumenstingl , linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v4 5/8] clk: amlogic: Add A5 clock peripherals controller driver In-Reply-To: <425ebeb4-8001-4493-882b-dfee87ed82c8@amlogic.com> (Chuan Liu's message of "Tue, 23 Dec 2025 20:27:39 +0800") References: <20251028-a5-clk-v4-0-e62ca0aae243@amlogic.com> <20251028-a5-clk-v4-5-e62ca0aae243@amlogic.com> <1jpl857e2w.fsf@starbuckisacylon.baylibre.com> <425ebeb4-8001-4493-882b-dfee87ed82c8@amlogic.com> User-Agent: mu4e 1.12.9; emacs 30.1 Date: Mon, 05 Jan 2026 10:14:31 +0100 Message-ID: <1jldice808.fsf@starbuckisacylon.baylibre.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On mar. 23 d=C3=A9c. 2025 at 20:27, Chuan Liu wrote: >>> + >>> +#define A5_COMP_SEL_WITH_TAB(_name, _reg, _shift, _mask, _pdata, _tabl= e) \ >> No, adjust your main macro. >>=20 > > Do you mean to unify this into a single macro here? Like this: > > #define A5_COMP_SEL(_name, _reg, _shift, _mask, _pdata, _table) \ > MESON_COMP_SEL(a5_, _name, _reg, _shift, _mask, _pdata, _table, 0, 0) > Yes, possibly --=20 Jerome