From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E393E7B5E1 for ; Wed, 4 Oct 2023 09:59:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232978AbjJDJ7B (ORCPT ); Wed, 4 Oct 2023 05:59:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48076 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232862AbjJDJ67 (ORCPT ); Wed, 4 Oct 2023 05:58:59 -0400 Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com [IPv6:2a00:1450:4864:20::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AF8DAA7 for ; Wed, 4 Oct 2023 02:58:55 -0700 (PDT) Received: by mail-lf1-x133.google.com with SMTP id 2adb3069b0e04-50567477b29so2252422e87.3 for ; Wed, 04 Oct 2023 02:58:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1696413534; x=1697018334; darn=vger.kernel.org; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:from:to:cc:subject:date:message-id:reply-to; bh=2zQurfJPbiuUjWnuhOpNrLMV2pgMXd/ebBa042cwmYc=; b=ssznBkeL/RtBv2O86Jzp7gM4CHOPBqfAjN34MlY19kgtSgGWZjBXllFFsgGQDBOCA2 F3olrFY6DYdYUho5Q+ce6CRl9WqSToVLcN1Rc4jacv84tTE4PrRCl93ZXxOlaXSqlFfl AZUlRJJV/L8+uHAdfp/9BPGXjwlaEltpw6Z2lek500lrSEdWfOsaqf7D5vIWCsYreZ5z 5HF0vZ87+g7wVXRbvGfd8YzzZ172+bJDVlZ6yBsEOonPDFbgwRNHHQ71NIKKfniJBfdt 4tJBUf8PqObkc8KF/5pNByTUs1TBQrRIgREiisD5wCzFf4g2hsNqdQ7up+G3Jmqowmnb zWcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696413534; x=1697018334; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=2zQurfJPbiuUjWnuhOpNrLMV2pgMXd/ebBa042cwmYc=; b=BInMkn51BocTh4c8QXwqTdf6NRNvdQtg6GIeoOQjSscK/sNPXV+hb24BjhMdV+B+6G 7UKrC+Mr2c7IOmCtPtJkpMomFhxTujpdxvdTG0eUlOGOGgyGSjzbuRolnvFrN0V+MInA 7y7QxzCj4YTtUk3/LCxhd4VtLnTFOhaq7iYTTSo666bFi3tgSmt+MzH6sW0hqU4bZoTz UT5FHT9glCUeUoTWcmVxj4w6BoqpH9G5A+M09lerIsI+JlMV4hHe88c2CreeaM6wWrjz GRQnq7Q7LeUo7ktndhAJ0SPdZI+ym4Vq90kBP03CDMAofcMJI82/+xIEkWzEjwdyHATu 0eoQ== X-Gm-Message-State: AOJu0YxcTDSLlfX4PayGulLuxh/TOJNIrbCA8651gNdGSUNj3vtSwJxe GTnanIiV/Ym9AvttjFFKqPfCFw== X-Google-Smtp-Source: AGHT+IEVyhw3oWGM3Jb/CM0G2T6xFOUfrj2mUvQvjyxBjBNYvCMW2izu2JSFSPd2ut8kSsupybhWPg== X-Received: by 2002:a05:6512:1052:b0:503:fee:5849 with SMTP id c18-20020a056512105200b005030fee5849mr1827173lfb.53.1696413533806; Wed, 04 Oct 2023 02:58:53 -0700 (PDT) Received: from localhost ([2a01:e0a:3c5:5fb1:d9fc:647c:aca8:fc21]) by smtp.gmail.com with ESMTPSA id x2-20020a1c7c02000000b003fe23b10fdfsm1086938wmc.36.2023.10.04.02.58.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Oct 2023 02:58:53 -0700 (PDT) References: <20231002141020.2403652-1-jbrunet@baylibre.com> <20231002141020.2403652-3-jbrunet@baylibre.com> <2248b34e-d755-4142-986c-0ead80796e13@linaro.org> User-agent: mu4e 1.8.13; emacs 29.1 From: Jerome Brunet To: Neil Armstrong , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Kevin Hilman , Da Xue , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org Subject: Re: [PATCH 2/2] arm64: dts: amlogic: add libretech cottonwood support Date: Wed, 04 Oct 2023 11:49:00 +0200 In-reply-to: <2248b34e-d755-4142-986c-0ead80796e13@linaro.org> Message-ID: <1jleciyahv.fsf@starbuckisacylon.baylibre.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 04 Oct 2023 at 11:20, Neil Armstrong wrote: > On 02/10/2023 16:10, Jerome Brunet wrote: >> Add support for the Libretech cottonwood board family. >> These 2 boards are based on the same PCB, with an RPi B form factor. >> The "Alta" board uses an a311d while the "Solitude" variant uses an >> s905d3. >> Co-developed-by: Da Xue >> Signed-off-by: Da Xue >> Signed-off-by: Jerome Brunet >> --- >> arch/arm64/boot/dts/amlogic/Makefile | 2 + >> .../amlogic/meson-g12b-a311d-libretech-cc.dts | 133 ++++ >> .../amlogic/meson-libretech-cottonwood.dtsi | 610 ++++++++++++++++++ >> .../amlogic/meson-sm1-s905d3-libretech-cc.dts | 89 +++ >> 4 files changed, 834 insertions(+) >> create mode 100644 arch/arm64/boot/dts/amlogic/meson-g12b-a311d-libretech-cc.dts >> create mode 100644 arch/arm64/boot/dts/amlogic/meson-libretech-cottonwood.dtsi >> create mode 100644 arch/arm64/boot/dts/amlogic/meson-sm1-s905d3-libretech-cc.dts >> > > > >> + >> + leds-pwm { >> + compatible = "pwm-leds"; >> + >> + led-green { >> + color = ; >> + function = LED_FUNCTION_STATUS; >> + linux,default-trigger = "default-on"; >> + panic-indicator; >> + max-brightness = <255>; >> + pwms = <&pwm_cd 1 1250 0>; >> + active-low; >> + }; >> + >> + led-blue { >> + color = ; >> + function = LED_FUNCTION_ACTIVITY; >> + linux,default-trigger = "activity"; > > "activity" isn't documented, perhaps heartbeat instead ? > The trigger does exist though. The other way is to extend the DT doc. I don't really care one way or the other I'll defer to Da on this one >> + max-brightness = <255>; >> + pwms = <&pwm_ab 1 1250 0>; >> + active-low; >> + }; > > leds subnodes should be named as led(-[0-9a-f]+) > > see Documentation/devicetree/bindings/leds/leds-pwm.yaml That I do care. The schematics refer to the leds by name. There is no number assigned, much less hex. Making one up makes no sense. User should be able to quickly (and easily) link what they see in the schematics with DT. So I'd prefer to submit a change for the regex rather than changing this > >> + }; >> + >> + leds-gpio { >> + compatible = "gpio-leds"; >> + >> + led-orange { >> + color = ; >> + function = LED_FUNCTION_STANDBY; >> + gpios = <&gpio GPIOX_6 GPIO_ACTIVE_LOW>; >> + }; > > Ditto, but you can simply use "led" since it's the only one. > > See Documentation/devicetree/bindings/leds/leds-gpio.yaml > > Neil > > >