From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f172.google.com (mail-lj1-f172.google.com [209.85.208.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A8151862B for ; Fri, 15 Mar 2024 10:20:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710498059; cv=none; b=mLMnN2EuwgzzO8Z/2QccJt9tJs3G8+9Jnk00eDZvoUYuZcGWjMtDKwdcR8HDVGGRtV88E9rTx6ORoWhZN5Cdly2Wcqo6TxF5go+sGvse1w1S6EcL8exU7Hjnoep9oo7q7CFLn0NyJtu1jLsJH+aMflUDL8BIG/88XF6bY+1WnyU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710498059; c=relaxed/simple; bh=JSCNMW8qWshcPVnF89xrbpx4/BHY0kCqY+YQoPryMmE=; h=References:From:To:Cc:Subject:Date:In-reply-to:Message-ID: MIME-Version:Content-Type; b=XcCtFxmk3lgOF60T3HzKEeEwaAu4lsZm1Mgpv7hbrO44gCVjW0PbC12xLLnegfjAGuz51LggeVAYEnKgBvTgZx1KC/8br4Yr0HSo5lMyfuAKMsXpk4Y73Az66NHvfNqA393xoLJvhbVlFVXyg7k9ViAC5P7k3/2QLpP+lBKdthM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=sVk2tWd8; arc=none smtp.client-ip=209.85.208.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="sVk2tWd8" Received: by mail-lj1-f172.google.com with SMTP id 38308e7fff4ca-2d46dd5f222so20402791fa.1 for ; Fri, 15 Mar 2024 03:20:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1710498054; x=1711102854; darn=vger.kernel.org; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:from:to:cc:subject:date:message-id:reply-to; bh=6gMhyQcCq8fucjInJ87jHa5Zs8QHwH2ZIASN5Qcn1XU=; b=sVk2tWd8CFKPdshbb9eXUUET6ZxocEIboqiLXoiqK3hg721u/2gNRYRSMVLaAGcwJX Oo6qm5UrSecL0sM5Xm9FwSsum2PVin70I8X2N/GMT4dGYvdHTaA69jv5n6dD99DacA7W EFL8UNGrHt2wcgjlR4vp/M6Goki5GzwwxGoeEXf3sFZdhF/Bv3gVaIfco4vOYFEb6kxc VKXpBa1w2q4oYRFCOpmcRXzJIcSXs6Ptz/+usei3On4qFEQwz5glSw9RDuguoqoei4GD o4CoCeTiM2q9tfz+CKEBK9WMpNQPMasWCBBAF0+085Z/m0GiOpUam0MPZ7VLHf+qPd9b Xuaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710498054; x=1711102854; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=6gMhyQcCq8fucjInJ87jHa5Zs8QHwH2ZIASN5Qcn1XU=; b=RZqTldShEUpuPPScNT3W3Vw2+0TjXhKgxWPCvPGADIqJ1a1eh9HmlMe+blMAwjxSk4 pxYn9l0Wpde1rjOiJ9QE9ZfMNKr2Z+yOxQBY5CoxEDz0d0FhNV0+KATZccMRf7/y4HD6 VwNcJblXt9/T7jdyQo9qaEdagH4lNNs1QkldXgO1UOt2K9eP41BwpLxALbfia0gCYED0 Trsdp7EzjolJIEwBjIozk30f71jxwMeuOU1q2tDeE6kora3wKNe6waAmBzcCz4LTjNcc Tzz6ImMz4fYKp0DO2wfTN4NCTZtq3RuvEWk9EpekjoI1/AZeHgsS7C1MVuohxexK9Q4j C9Yg== X-Forwarded-Encrypted: i=1; AJvYcCVG8jmYteWwBpIbEKeV/0JPGawxCCsvHOqdxpaiUKpFEMoBZsyBUQbgAyD77kKuWZcmSBqdljR1J5/yd2KHViqybO8cpbh9c55YYFbC X-Gm-Message-State: AOJu0YwgsG7+vLNLEm2Y7ynbgKTJvBiH/IpH8n+wG9byG6WIrSbT2lD8 woXuBdP6qToOuOh3WovP+2Otfle3uXFTKXq3SG/1hbk2jqs/yhmbWD5wNsZiplM= X-Google-Smtp-Source: AGHT+IE93RWjsQIaXcrXP7QebJrBXb65k9rloMkqM4nhLZfNJA/HvogTh3saXyVEmcMBtfGaiLq/Mg== X-Received: by 2002:ac2:4348:0:b0:513:42e:ddf0 with SMTP id o8-20020ac24348000000b00513042eddf0mr2648632lfl.36.1710498054118; Fri, 15 Mar 2024 03:20:54 -0700 (PDT) Received: from localhost ([2a01:e0a:3c5:5fb1:8151:4d0a:14d8:1124]) by smtp.gmail.com with ESMTPSA id n7-20020a05600c3b8700b00413ea3db648sm8058358wms.26.2024.03.15.03.20.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Mar 2024 03:20:53 -0700 (PDT) References: <20240314232201.2102178-1-jan.dakinevich@salutedevices.com> <20240314232201.2102178-22-jan.dakinevich@salutedevices.com> User-agent: mu4e 1.10.8; emacs 29.2 From: Jerome Brunet To: Jan Dakinevich Cc: Neil Armstrong , Jerome Brunet , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , Kevin Hilman , Martin Blumenstingl , Liam Girdwood , Mark Brown , Linus Walleij , Jaroslav Kysela , Takashi Iwai , linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, alsa-devel@alsa-project.org, linux-sound@vger.kernel.org, linux-gpio@vger.kernel.org, kernel@salutedevices.com Subject: Re: [PATCH 21/25] ASoC: dt-bindings: meson: axg-tdm-iface: claim support of A1 SoC family Date: Fri, 15 Mar 2024 11:13:48 +0100 In-reply-to: <20240314232201.2102178-22-jan.dakinevich@salutedevices.com> Message-ID: <1jmsqzhk3e.fsf@starbuckisacylon.baylibre.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Fri 15 Mar 2024 at 02:21, Jan Dakinevich wrote: > Add "amlogic,a1-tdm-iface" compatible string alias to > "amlogic,axg-tdm-iface". > > Signed-off-by: Jan Dakinevich > --- > .../devicetree/bindings/sound/amlogic,axg-tdm-iface.yaml | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/sound/amlogic,axg-tdm-iface.yaml b/Documentation/devicetree/bindings/sound/amlogic,axg-tdm-iface.yaml > index 45955d8a26d1..7c1af85b52b4 100644 > --- a/Documentation/devicetree/bindings/sound/amlogic,axg-tdm-iface.yaml > +++ b/Documentation/devicetree/bindings/sound/amlogic,axg-tdm-iface.yaml > @@ -14,7 +14,11 @@ allOf: > > properties: > compatible: > - const: amlogic,axg-tdm-iface > + oneOf: > + - const: amlogic,axg-tdm-iface > + - items: > + - const: amlogic,a1-tdm-iface > + - const: amlogic,axg-tdm-iface Same as the card driver. I could have named it "amlogic,tdm-iface" This is purely a SW component, which help agregate clocks and tdm-formatters. It is analog to a "gpio-leds" or a "pwm-clock" driver. We would add a compatible for every SoC for these, would we ? I don't think it makes a lot of sense to add this. It is not going to hurt but this is just adding useless compatible to the doc that will never be used > > "#sound-dai-cells": > const: 0 -- Jerome