From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98FA4CDB47E for ; Fri, 13 Oct 2023 07:46:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229957AbjJMHqp (ORCPT ); Fri, 13 Oct 2023 03:46:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37330 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229968AbjJMHqb (ORCPT ); Fri, 13 Oct 2023 03:46:31 -0400 Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8C72FD8 for ; Fri, 13 Oct 2023 00:46:28 -0700 (PDT) Received: by mail-lf1-x12f.google.com with SMTP id 2adb3069b0e04-505a62d24b9so2290998e87.2 for ; Fri, 13 Oct 2023 00:46:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1697183187; x=1697787987; darn=vger.kernel.org; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:from:to:cc:subject:date:message-id:reply-to; bh=wP8hZWh4qXyybXYLkSLcCZu/0fSSL+752WobzxTNboE=; b=2PvP0qX1Kb/XjDabWI/PzKNPTRta7BnboXvRCqD9rHVAAgruwu4lsxR7lOFyvR2ez1 JE4wfU3K8lotvUF2dG88RTSTt6B7rivBrW39Fq49PqL9xUSD4ycIZKR8Qf13bmkVqWQR kxFGMGMnxH0ug9B+JLi/JXqcDYTJyhTvZ0Tzd0kneivrFCUjc+t7gKj6NP+CcWgLWBWA ZVrqX+cIQC49b3zgjKB8VfsDgr9YHsju9ODo5bCy0QP68GJ4eGCtaJWsHHSjoCjr46XV egfobmFMV1y3ngEnwQY+75aYdvBxPA3JHsLca8PHCBOcJe9R+VraEaOErKLPzdBWwF3/ anYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697183187; x=1697787987; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=wP8hZWh4qXyybXYLkSLcCZu/0fSSL+752WobzxTNboE=; b=uvWAy+lTlXyiE+1M9gmpiWEPFctqHCoMQTTnA4S+BfDjOSe2IffPvLUg5PL3gHBvpC XcRU9S1S3wMgaFlW98RWN/DfOrpnkm9dwEkp2jNeG/ukur0meEjkEPyWRX45qvvo5WZC ovzyhc5DtjRXrKj+B3vKWoQj0fvieIgb1F+E+JRYjgSt04htwEsMiVD/46/oI5AYBSdO yBfCLKGlT0ugdvSFvE7XIr86eGCNYCH4xcgB2ZE9EJuJgfBlMMIelX1rbuegofQ/YLoE BnD1WOlYMqfBdZTi0+gcjJSOqMgfRnP7HRajnLSLh8XPeEqyrj1feR7ZzW0krGJ5k27C xnYQ== X-Gm-Message-State: AOJu0Ywdh4C7pKD++a+oMfNxPwj3WVvQJGXVQq/AR6vIQEPdHnhTtA4W BxypP9bb+L293iEfGvxyKj8YmA== X-Google-Smtp-Source: AGHT+IEkyEN8zAQ5/dhZe4B9ajTP0EDEK/rSt7LjwGLHX2RHEZPT+iFlTiLC7YassaX2zhaMHUp92A== X-Received: by 2002:a19:5f04:0:b0:4fb:94c6:fd63 with SMTP id t4-20020a195f04000000b004fb94c6fd63mr16394959lfb.17.1697183186650; Fri, 13 Oct 2023 00:46:26 -0700 (PDT) Received: from localhost ([2a01:e0a:3c5:5fb1:b50c:c5d5:8b1b:e06d]) by smtp.gmail.com with ESMTPSA id r6-20020a5d4946000000b0032da022855fsm252248wrs.111.2023.10.13.00.46.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Oct 2023 00:46:26 -0700 (PDT) References: <20231010062917.3624223-1-xianwei.zhao@amlogic.com> <20231010062917.3624223-5-xianwei.zhao@amlogic.com> <5e0bd4bba88701dd1a7a3e89d18412f0.sboyd@kernel.org> User-agent: mu4e 1.8.13; emacs 29.1 From: Jerome Brunet To: Stephen Boyd , Xianwei Zhao , devicetree@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Neil Armstrong , Michael Turquette , Rob Herring , Krzysztof Kozlowski , Kevin Hilman , Martin Blumenstingl , Chuan Liu Subject: Re: [PATCH V2 4/4] clk: meson: c3: add c3 clock peripherals controller driver Date: Fri, 13 Oct 2023 09:38:14 +0200 In-reply-to: <5e0bd4bba88701dd1a7a3e89d18412f0.sboyd@kernel.org> Message-ID: <1jmswnvub2.fsf@starbuckisacylon.baylibre.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu 12 Oct 2023 at 16:51, Stephen Boyd wrote: > Quoting Xianwei Zhao (2023-10-09 23:29:17) >> diff --git a/drivers/clk/meson/Kconfig b/drivers/clk/meson/Kconfig >> index 76be4bbd2afb..c8d59d28c8ff 100644 >> --- a/drivers/clk/meson/Kconfig >> +++ b/drivers/clk/meson/Kconfig >> @@ -140,6 +140,19 @@ config COMMON_CLK_C3_PLL >> Say Y if you want the board to work, because PLLs are the parent of most >> peripherals. >> >> +config COMMON_CLK_C3_PERIPHERALS >> + tristate "Amlogic C3 peripherals clock controller" >> + default y > > Why are these default y? They should depend on something like ARM64 and > even then I don't see why we want to enable them by default if we're > building the ARM64 kernel. Should indeed depend on ARM64. Those are the main clock controllers. Like for other AML SoC families, they are necessary to boot the device which is why they use 'default y' Is it a problem ? The whole meson directory depends on ARCH_MESON, so the drivers will go away if Amlogic support is removed on ARM64.