From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD3D2C433DF for ; Thu, 27 Aug 2020 13:34:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B5C9122CAE for ; Thu, 27 Aug 2020 13:34:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="llWyNpxJ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728074AbgH0NeP (ORCPT ); Thu, 27 Aug 2020 09:34:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49064 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727793AbgH0NcK (ORCPT ); Thu, 27 Aug 2020 09:32:10 -0400 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6C789C061264 for ; Thu, 27 Aug 2020 06:32:10 -0700 (PDT) Received: by mail-wm1-x342.google.com with SMTP id b79so4530459wmb.4 for ; Thu, 27 Aug 2020 06:32:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=RzjTTXuW8DoQzMoQkpQltYkMS2hvfG2Wfy3KypxE85c=; b=llWyNpxJ3XYx4msjmJiZYlY6gVQe7XWBxESPQWE5O4+p1/7ffuz3Hh+8PKvIOKijtA xPjWCpULHdChCIFlNhwXM0bYx4QhMtmMkWALfpAteoa++wRIjBx4elYwR365z7mcimmn QzEJsSO9u2Zwd6DQ/83vF0GIYszdYx0fCcmDa/v87iBYf/cggfoNA+iD8VHiv7Qg9CG5 d4gi9feMHBUGAhGUMqRb78xOKL/6fZtMkY3OBwTH/+LwxSByvYejWSaXvx/8Omr9lLH9 6C1ipG5Z68JQKmc7vA0fDA8Y07pG9V1XyucEBTsVIWzEqikWY8pKDYIHa4vzfy+4fysd mZCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=RzjTTXuW8DoQzMoQkpQltYkMS2hvfG2Wfy3KypxE85c=; b=GUPvcJ0mJI47QUhseai74QF9pxRuYC/2mQGSXZPnD5olVax5L9m+Z6seUEK66qetzV ETPizLRNJ0hxLBtaJvmHpFO43NHj4sgrNF5eVAhpzfR10fmz7fYOnf5O4g1dHP4ykBiy G+DdrEI4c/01RB6W1F5mo+2O6DJZlNx3K8DQCe74izK4D7gFuh487CDnq3ZxVkIt7XGi Kbt36gJ6ayRTbotAUBq9d/51fstc8ucWVGQai+IEpYSy6S3YVGCDUwb9mE2D8FMdlsAl +9m5JZHMmrHOjBYGurCvK6MiYnEmo79OrmhN/8HkGjzktseUWtry7Eh3nm7VQp1BxPj1 3UJQ== X-Gm-Message-State: AOAM5304XfzH6Nw44Mpyn3NIOWcZtgimRic4RnkbPUVTBkxmo0gAdLxe uaiYxUqv3jTOfp3zERByRpHaiQ== X-Google-Smtp-Source: ABdhPJw34SA8WJgrEgzMp2TR1ApIy6v1Wx2UvzK6DpDa87F1baFk/BT77mLLH0QK1paRl37b2MDcRQ== X-Received: by 2002:a1c:b4c1:: with SMTP id d184mr12466841wmf.26.1598535129044; Thu, 27 Aug 2020 06:32:09 -0700 (PDT) Received: from localhost (laubervilliers-658-1-213-31.w90-63.abo.wanadoo.fr. [90.63.244.31]) by smtp.gmail.com with ESMTPSA id 31sm6239269wrp.87.2020.08.27.06.32.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Aug 2020 06:32:08 -0700 (PDT) References: <20200731120603.2243261-1-jbrunet@baylibre.com> User-agent: mu4e 1.3.3; emacs 26.3 From: Jerome Brunet To: Marek Szyprowski , Mark Brown , Liam Girdwood , Pierre-Louis Bossart , Stephan Gerhold , Srinivas Kandagatla , Kuninori Morimoto Cc: alsa-devel@alsa-project.org, Kevin Hilman , linux-kernel@vger.kernel.org, zhangn1985@outlook.com, linux-amlogic@lists.infradead.org Subject: Re: [PATCH] ASoC: meson: cards: deal dpcm flag change In-reply-to: Date: Thu, 27 Aug 2020 15:32:07 +0200 Message-ID: <1jmu2g6wq0.fsf@starbuckisacylon.baylibre.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu 27 Aug 2020 at 14:43, Marek Szyprowski wrote: > Hi Jerome, > > On 31.07.2020 14:06, Jerome Brunet wrote: >> Commit b73287f0b074 ("ASoC: soc-pcm: dpcm: fix playback/capture checks") >> changed the meaning of dpcm_playback/dpcm_capture and now requires the >> CPU DAI BE to aligned with those flags. >> >> This broke all Amlogic cards with uni-directional backends (All gx and >> most axg cards). >> >> While I'm still confused as to how this change is an improvement, those >> cards can't remain broken forever. Hopefully, next time an API change is >> done like that, all the users will be updated as part of the change, and >> not left to fend for themselves. >> >> Fixes: b73287f0b074 ("ASoC: soc-pcm: dpcm: fix playback/capture checks") >> Signed-off-by: Jerome Brunet > > This patch landed finally in v5.9-rc1. I've noticed it causes a > following warning on Hardkernel's Odroid N2 board > (arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtb): Looks like the after match of the flag change again ... > > meson-drm ff900000.vpu: [drm] fb0: mesondrmfb frame buffer device > ------------[ cut here ]------------ > WARNING: CPU: 3 PID: 66 at sound/soc/soc-core.c:817 Marek, is it possible that you have CONFIG_LOCKDEP enabled in your configuration ? snd_soc_find_dai() is called by snd_soc_dai_link_set_capabilities(). Indeed, the client_mutex will not be help by any of the user of snd_soc_dai_link_set_capabilities() when called. So I believe simple card and qcom will be impacted as well. > snd_soc_find_dai+0xe4/0xf0 > Modules linked in: dw_hdmi_i2s_audio dw_hdmi_cec meson_gxl realtek > dwmac_generic crct10dif_ce snd_soc_meson_axg_sound_card > snd_soc_meson_card_utils rc_odroid pwm_meson meson_ir > snd_soc_meson_g12a_toacodec snd_soc_meson_axg_tdmout rtc_meson_vrtc > snd_soc_meson_g12a_tohdmitx snd_soc_meson_codec_glue mdio_mux_meson_g12a > snd_soc_meson_axg_tdmin dwmac_meson8b stmmac_platform > reset_meson_audio_arb snd_soc_meson_axg_frddr axg_audio > snd_soc_meson_axg_toddr sclk_div clk_phase meson_rng stmmac rng_core > meson_dw_hdmi snd_soc_meson_axg_fifo meson_drm meson_canvas mdio_xpcs > dw_hdmi snd_soc_meson_t9015 display_connector nvmem_meson_efuse > snd_soc_meson_axg_tdm_interface snd_soc_meson_axg_tdm_formatter > snd_soc_simple_amplifier > CPU: 3 PID: 66 Comm: kworker/3:1 Not tainted 5.9.0-rc1 #1527 > Hardware name: Hardkernel ODROID-N2 (DT) > Workqueue: events deferred_probe_work_func > pstate: 60000005 (nZCv daif -PAN -UAO BTYPE=--) > pc : snd_soc_find_dai+0xe4/0xf0 > lr : snd_soc_find_dai+0xe0/0xf0 > ... > Call trace: > snd_soc_find_dai+0xe4/0xf0 > snd_soc_dai_link_set_capabilities+0x68/0x160 > axg_card_add_link+0x188/0x5c4 [snd_soc_meson_axg_sound_card] > meson_card_probe+0x1e0/0x960 [snd_soc_meson_card_utils] > platform_drv_probe+0x50/0xa8 > really_probe+0x110/0x400 > driver_probe_device+0x54/0xb8 > __device_attach_driver+0x90/0xc0 > bus_for_each_drv+0x70/0xc8 > __device_attach+0xec/0x150 > device_initial_probe+0x10/0x18 > bus_probe_device+0x94/0xa0 > deferred_probe_work_func+0x70/0xa8 > process_one_work+0x2a8/0x718 > worker_thread+0x48/0x460 > kthread+0x134/0x160 > ret_from_fork+0x10/0x1c > irq event stamp: 269690 > hardirqs last enabled at (269689): [] > _raw_spin_unlock_irqrestore+0x7c/0x98 > hardirqs last disabled at (269690): [] > do_debug_exception+0x140/0x26c > softirqs last enabled at (269318): [] > efi_header_end+0x654/0x6d4 > softirqs last disabled at (269313): [] > irq_exit+0x16c/0x178 > ---[ end trace 56a3ea4fa00c37c8 ]--- > ... > axg-sound-card sound: ASoC: no DMI vendor name! > > The warning is repeated 10 times. That's the probe defferal mechanism causing the repeat > > The bisect between v5.8-rc1 and v5.9-rc1 points to the commit > c8f7dbdbaa15 ("Merge remote-tracking branch 'asoc/for-5.8' into > asoc-linus"), which introduced a branch with this patch. > > The commit with this patch is applied on the earlier kernel release > (da3f23fde9d7 "ASoC: meson: cards: deal dpcm flag change" on top of > v5.7-rc1) worked fine, so it looks that there is an interference with > something merged later. > > If I revert this patch on top of v5.9-rc1 or current linux-next, the > warning is gone. ... but any aml platform with uni-directional backend (not the N2, lucky you) would be broken. > Let me know how I can help debugging this issue. If you have CONFIG_LOCKDEP enabled, try disabling see how it goes and report. It is not a fix but at least you'll be unblocked. > > Best regards