From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3EAC2342503 for ; Wed, 18 Feb 2026 18:13:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771438400; cv=none; b=KuM9o47E4OEmaZxjNzTovqgRvfKKUMOqB+qfpLNg+25B2O3dH0zZlDIfYGtHC/1UuwLCIIKXqmbjobn3AEWdQaB4NHq5gAv1m/0Uep7ZNXO9He0rOkQ4p4GqiP1ocKF40fFm0TCu/ZeiKnrdubmujb7HxVb2GrcVuY4Zepqait0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771438400; c=relaxed/simple; bh=zDjBvHqPxX/UNO4JPLX6sFcO2RcmeEiXEdVvkfXFKEk=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=ufjo0dSEMERZ0M/Cl2N1J0xNDiPozAWBHLq6tcSYdEITuX+2DwcD9f/+FGIxI+puJVyxk8TpyMd5XN5qlb+Yo47H3msqKHm98tkVAp2bAxC5DCKQepVOZNJNOUVq7vtT/74SBQVdwoiFwLk6RUdDCZZlTVGB++OOoc7adZ2Nu3g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=sYMocTki; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="sYMocTki" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-48375f10628so949555e9.1 for ; Wed, 18 Feb 2026 10:13:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1771438398; x=1772043198; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:user-agent :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=vIekHAkyURnbY7ZGcdPvi5VEj7cPbPYtWFDuUCFEzTw=; b=sYMocTkiR7XecJWB9AoMW1aW0GXtNmuDYv6MXsVVHGJU2ulnPtueEYUoBxD92JAvto SZCO04eYTqDry4gKSAZy2uvXnmfIQyTNf9gOpESE27gqKtzQSRBZLZUVtSJ6s1DlYZ4m PNMD4hviMvQaN/Xx7tAzfCrPbRtE542aF605ISjd1MURe6PAk5FscAH1Bha3clMf5951 Jv3tL23ML/fxJWI9yeiqtXo/KeFZITQCoeumCJPbOeISl0OmervVQGwL+/ZlI5x8jqMA 2Mtwx++PztFjUB/o90nG3wA4G6b8SXOpdtkx3ucJiljfFOHqMa9mOhuJnM/+MCr6N5YB 07PA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771438398; x=1772043198; h=content-transfer-encoding:mime-version:message-id:date:user-agent :references:in-reply-to:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vIekHAkyURnbY7ZGcdPvi5VEj7cPbPYtWFDuUCFEzTw=; b=TpB8ib3NCiRUDWfxyBUbPzOCu7HJUDmpUDqwqzwNhbfoUSybZvW5D4aC0Nv7qvtozo N/vpZvqA5a/kZb3nxP159ensPXFcV8ONivqhyawNKYxpoeg70YkrY+Q6BVSDJKClU051 i2FK2Fp477LmDE2xpDYCjvTMES15/9NWufWv+bEBV6U7sAj7GUCCx1Sk2j6B6iAvfh2R IQKJMaiYvlZjKbZdObe/E83KNal7ylz20YFKeyEeqzY4nKQAZRVR1VdKt7e+sijMm9lx FRb855GxVrYF4ysWP6RtJjcBn6RnYs91CgMZvjflPBs423ITkL3PBBKWBlGg7ESm3gIb pWHg== X-Forwarded-Encrypted: i=1; AJvYcCV7x5elr0YfTGsLl48bPtesMDGpL+nS/NrtWhqQpOofppRCgoAJDyMUbL4akDTZUL9uyjzYBzrx7Ej4wl8=@vger.kernel.org X-Gm-Message-State: AOJu0YzetXf8bEVuKO5llymp8GrGcI0tTBAmmmDlsF8SQriOH0ea8fi9 Rjb5/EQ+CWEn7BVHbxXxZF7ARzp75tfl56fvUuU4lJ373q/baOUhVaN6CZcRFuXH1Xo= X-Gm-Gg: AZuq6aIchL6apGXAFwUZZkm4zwbMNxh72BmyDNetvTaTaTq1R6Obwc/ezwfwH2NpN5o 8Kc+DeqGwRJjVjW6haBa3pKeGtpK7e1+2Tzs7IgSZmh0XW/e0kwOH5pKsQne/g/UyZNG5UJARv+ 2j8R+xkwkpUlhweVs24iUOfrhOUvz25c9TEg9JJG19GJAru2JKKUoLjfsdM1ImzS/BaaMUJEXei UMn8J37wiczDZTad1XpzoNKC8cdf92lAu2yqY/V5RNEqZmM8V7K+ohRrR01Q0WJ7LhMUKqMBU24 s7Ppr+hbjv8lNeMZ7CeI+I3Vs+j98RMfM8swxG34GylCifB0sq/loLMLpXzlAKtcNjj14VCCuB/ uwtvuIBaxFdJaup5ZbEhD7ZoUYr1JgC8JColcSvFTdxndA63zgQL/BvnpHLmS+gedct9yMahDms H9AMZcw/wat7uk75tLh3boYw== X-Received: by 2002:a05:600c:6215:b0:480:6852:8d94 with SMTP id 5b1f17b1804b1-48398ae8e6cmr48823635e9.27.1771438397601; Wed, 18 Feb 2026 10:13:17 -0800 (PST) Received: from localhost ([2a01:e0a:3c5:5fb1:cf71:8cf8:56bb:5790]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-4837b68e5adsm416187875e9.9.2026.02.18.10.13.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Feb 2026 10:13:17 -0800 (PST) From: Jerome Brunet To: Ronald Claveau Cc: linux-amlogic@lists.infradead.org, Neil Armstrong , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jian Hu , Xianwei Zhao , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/7] dt-bindings: clk: meson: Add Amlogic T7 fix pll support In-Reply-To: <20260218105709.36253-1-linux-kernel-dev@aliel.fr> (Ronald Claveau's message of "Wed, 18 Feb 2026 11:57:07 +0100") References: <20260218101709.35450-1-linux-kernel-dev@aliel.fr> <20260218105709.36253-1-linux-kernel-dev@aliel.fr> User-Agent: mu4e 1.12.9; emacs 30.1 Date: Wed, 18 Feb 2026 19:13:15 +0100 Message-ID: <1jpl616htw.fsf@starbuckisacylon.baylibre.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On mer. 18 f=C3=A9vr. 2026 at 11:57, Ronald Claveau wrote: > Add PLL for the clock controller of the Amlogic T7 SoC family. Assuming the 3 first patch are actually needed (I don't think they are) I think patch 2 and 3 should be squashed together > > Signed-off-by: Ronald Claveau > --- > .../devicetree/bindings/clock/amlogic,t7-pll-clkc.yaml | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/clock/amlogic,t7-pll-clkc.= yaml b/Documentation/devicetree/bindings/clock/amlogic,t7-pll-clkc.yaml > index 49c61f65deff..6a1598e6c359 100644 > --- a/Documentation/devicetree/bindings/clock/amlogic,t7-pll-clkc.yaml > +++ b/Documentation/devicetree/bindings/clock/amlogic,t7-pll-clkc.yaml > @@ -23,6 +23,7 @@ properties: > - amlogic,t7-mpll > - amlogic,t7-hdmi-pll > - amlogic,t7-mclk-pll > + - amlogic,t7-fpll >=20=20 > reg: > maxItems: 1 > @@ -42,6 +43,7 @@ properties: > - const: in0 > - const: in1 > - const: in2 > + - const: xtal Fishy. Maybe it will get more clear with a more detailed commit description > minItems: 1 >=20=20 > required: > @@ -72,11 +74,12 @@ allOf: > contains: > enum: > - amlogic,t7-gp0-pll > - - amlogic,t7-gp1--pll > + - amlogic,t7-gp1-pll Indeed that's not good ! but you need specific patch for this, and Fixes tag. You can send this separately. > - amlogic,t7-hifi-pll > - amlogic,t7-pcie-pll > - amlogic,t7-mpll > - amlogic,t7-hdmi-pll > + - amlogic,t7-fpll >=20=20 > then: > properties: --=20 Jerome