From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F9B5C433E0 for ; Mon, 4 Jan 2021 14:08:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F0A2D207BC for ; Mon, 4 Jan 2021 14:08:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727149AbhADOI5 (ORCPT ); Mon, 4 Jan 2021 09:08:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56512 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726029AbhADOI4 (ORCPT ); Mon, 4 Jan 2021 09:08:56 -0500 Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [IPv6:2a00:1450:4864:20::62f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7A7D1C061574 for ; Mon, 4 Jan 2021 06:08:16 -0800 (PST) Received: by mail-ej1-x62f.google.com with SMTP id n26so36919112eju.6 for ; Mon, 04 Jan 2021 06:08:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=references:user-agent:from:to:cc:subject:in-reply-to:message-id :date:mime-version; bh=ONDjz5ciY9vROqc+40QcPHXcNj7vnSuJSUB6nVWh938=; b=rI95mT2WrrOPFGLnvIYmdnh/hiOFPpiKvknNVQO+3kAVlmXH+XKbRr40QgJQnL9/MO ZkxOa3TrY3NzVEdiCZfz9T/yAtDg+svkf3cfqMQQDXKCm+5DIr/JXETAWsVxUsIO453U N8ka6bNI1n0Vj/B9t4kWWwRkwxSq0pH9ynmu21FPTJmfyocuxv9EqEy2NbH/FO7Sckct YpbDPJk4VEGv7TCi0gR5l76CjSHsv6+pqiu3l/aOic1bff2ZJrGpG6kUd6RKliHgzzih WhxxHIklIa+TwE4S70fX1FCtnhHquP0YcdWImUbgIAC78iUG2VqYJiFeXmCah0hSlCln b80A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:message-id:date:mime-version; bh=ONDjz5ciY9vROqc+40QcPHXcNj7vnSuJSUB6nVWh938=; b=D4ufv51lKtu/gUZ6B3xmqBTGPUIg5FmnbZKZ7Ktx/t7qBCq/dfXkX2SgtNCjWx6CZr QjlkwVSQIEMVI4rcnV+ZyCzq+zUNjGVDz/Yct0OsPkASlrcvCWZdkcK4icMyCH/WEB5X Q89D9XO8snmV5vTYmOwU6k0I17pRsh48ee+0C7T5PT31BHMQelTTs+F/z30UHgvRCv9P hThH/Ikhm+E/6KRU6fkcaLbheouMP+HAh28ENfiAIO4ZGpfZ562gwFRZ+o/FP2DcxglK gmkplgMUDomfV3OXgVG6ggFwwZtlX8hBQdrbhmTWLcBS2q1BRIc0GoZh0CFak1GttogK AhKA== X-Gm-Message-State: AOAM531tNT8XkLU8/7jkl4hSZVbvjwU8bbRpQjSecW3D/SZiaBzUTPev WVoTIyX6CpAb1KiMUpZuJt/A0A== X-Google-Smtp-Source: ABdhPJwWleW0MXH3U76HBozLO17/P7prx/2nKrQvU/7WOFT18qrcg+F/uNDoWgAaedeAbgYIS7KMAQ== X-Received: by 2002:a17:906:ae14:: with SMTP id le20mr68611224ejb.451.1609769295055; Mon, 04 Jan 2021 06:08:15 -0800 (PST) Received: from localhost (82-65-169-74.subs.proxad.net. [82.65.169.74]) by smtp.gmail.com with ESMTPSA id u2sm23681997ejb.65.2021.01.04.06.08.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Jan 2021 06:08:14 -0800 (PST) References: <20201221173531.215169-1-jbrunet@baylibre.com> <20201221173531.215169-4-jbrunet@baylibre.com> <20201229222949.GC31406@jackp-linux.qualcomm.com> User-agent: mu4e 1.4.10; emacs 27.1 From: Jerome Brunet To: Jack Pham , Greg Kroah-Hartman Cc: Felipe Balbi , Ruslan Bilovol , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/4] usb: gadget: u_audio: remove struct uac_req In-reply-to: <20201229222949.GC31406@jackp-linux.qualcomm.com> Message-ID: <1jr1n0x0aa.fsf@starbuckisacylon.baylibre.com> Date: Mon, 04 Jan 2021 15:08:13 +0100 MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 29 Dec 2020 at 23:30, Jack Pham wrote: > Hi Greg and Jerome, > > On Mon, Dec 28, 2020 at 04:01:46PM +0100, Greg Kroah-Hartman wrote: >> On Mon, Dec 21, 2020 at 06:35:30PM +0100, Jerome Brunet wrote: >> > 'struct uac_req' purpose is to link 'struct usb_request' to the >> > corresponding 'struct uac_rtd_params'. However member req is never >> > used. Using the context of the usb request, we can keep track of the >> > corresponding 'struct uac_rtd_params' just as well, without allocating >> > extra memory. >> > >> > Signed-off-by: Jerome Brunet >> > --- >> > drivers/usb/gadget/function/u_audio.c | 58 ++++++++++++--------------- >> > 1 file changed, 26 insertions(+), 32 deletions(-) >> >> This patch doesn't apply, so I can't apply patches 3 or 4 of this series >> :( >> >> Can you rebase against my usb-testing branch and resend? > > From the cover letter: > > On Mon, Dec 21, 2020 at 06:35:27PM +0100, Jerome Brunet wrote: >> The series depends on this fix [0] by Jack Pham to apply cleanly >> >> [0]: https://lore.kernel.org/linux-usb/20201029175949.6052-1-jackp@codeaurora.org/ > > My patch hadn't been picked up by Felipe, so it's not in your tree > either, Greg. Should I just resend it to you first? Or shall I invite > Jerome to just include it in v2 of this series? Indeed. I rebased on usb-testing and the series applies cleanly with Jack's changes, as decribed in the cover-letter. If it is easier, I'm happy to include Jack's change in the v2, along with the fixed PATCH 2 fixed. Greg, would it be OK with you ? > > Thanks, > Jack