From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CF0AC1EEE6 for ; Fri, 10 Jul 2026 17:02:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783702942; cv=none; b=cgWGPZbykz0jwYuWjSbxAwlMWK/m1sYt38f2R4kAdNDw1GbPrOMmOtZirm+u0zTud0uUyqTyNnWD9l7iqahaudRfo+8LBIz1EeFl6pf+XLe7kqfIElLcjlIg4QtYo/04LfcdCoN8qHH+BZ4n6bXtOE/diYwrsdZIph1N6dw5B88= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783702942; c=relaxed/simple; bh=zI0YbIPQiZhlu7BQqMKf6cO4GFcM5ewk2NvTfVbLEpA=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=XaFvCMzC3QgAgxiRK7eaayomIdrWEKIeRpYGjt1AK7eko1UfreFehMvY26pjF5fTdtJKmRjkvCyUXYhLT+bH7WM28WcY8H2OHPc/YImmlT6WpkhSjODa/P/0XsXNQEc7cMnYidD3ih28G0Y9k3+b+OsS03p0GgEuHfohqwdxie8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=I8/8zTX+; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="I8/8zTX+" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-493b7612475so9855465e9.3 for ; Fri, 10 Jul 2026 10:02:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1783702938; x=1784307738; darn=vger.kernel.org; h=content-type:mime-version:message-id:date:user-agent:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to:content-type; bh=O3PEv/85mgKmQeDAaIOSKuCLAVJoXdX7UdliBoP0G5w=; b=I8/8zTX+M6JOeY/v+TOk+OHw4g3G0mlqFors9ilQgf9gy2QqmZV3EXSXoPhC7dT3q8 LuCjaBveSKGpCMKPYV4AkrW3t4k2yqjOZnG10jwXCO0HCroXNPaLmHxZue6oBA39BhpP mw27yvyLQg35sr7mCmWU96xRkRm9jSfc2UlmEoedyc8dwNL+Ya7/0agXuIoGHtrlCN29 it28jchz78PVFYn9Ql6duwcyziMnjFAc8QzmhDyq6TMilVRCxlEbNQaiZxcLe707C4Rn PO2r8oAEy3/sBx9q+Hr0a4sjhNTOFzPyRS7PHdh4XF64Ow0Qb6w2J74jP6A6TgySTvyI qRfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783702938; x=1784307738; h=content-type:mime-version:message-id:date:user-agent:references :in-reply-to:subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to:content-type; bh=O3PEv/85mgKmQeDAaIOSKuCLAVJoXdX7UdliBoP0G5w=; b=FZO9gFUP8Aay+IKICxE6j2w27N8cAikG1Z7EEna+ijJvFrWVtr7ZcuCk5/jEsJIfOd u+16Ztds7Tb9ZwfUONRc2o6hoevtUdgHH9W0WviSP6QBHyvG0rkkvpTBM/f7D71x6m1E Qc+KBwMqbKQc0DzHswfjaJWcOlgsQ91zZP+wy7q7EzxDKMqeefKDJHxJXk7vl7qlk6Sn WrgKfd3exOSDcfJcYGYTT1oq1h1Glt7g9k+KAjZLz45Td08tv1YN0gFsHo4hjQEq5Ak4 B0i32Y6Nl5b+mo8ofQ0Sykk2dVRsw487IHw+SKXtQLf3pKOsZhdG2DWR+vYMYD9B53j3 0EBg== X-Forwarded-Encrypted: i=1; AHgh+RromispRXcQRSO9ACVKBvVPXcuKu5gCqCwKOSsOO7+iSLGZfaXBB2sleRLL+vZyHg/ktnMndlFouOQnq4o=@vger.kernel.org X-Gm-Message-State: AOJu0YwQ29XyDbqXbtHwHDQJO5haMTv5MCwPDUDqaofJVn7PgOKE2AiC nxXsO8BGmKZKK1cmAliSKEJ8h/N9ZrGgtfxOHtcl9n7PX5MwHYnL7k4zkcWkHF1BiO4= X-Gm-Gg: AfdE7cmYAtAvbD9wht3+zMbWGBdsFoxrL8TU+lhYxErNB65DycbSb3wwet+6sJxGFTT v6scvLBgITq6ARsWa1ioAzlF6MBDsE03XRF4eyPQKH9KLM2oYQziUIqn1hwO953s+NRyNi1QN5a 7k4U9v3FPPs3GG+SLLBUu70nh4t2f2v4sL/Y9FVP20G/6sQN10lmB02CdUP4v/8xkJsw+uHwJeI N0yZUa1++ozzzM3xNberM3zB5dZarAUtL0EaOXeqtMGkRjExQtHDoESEuD1z2pFOSCv3a3V6rT2 kMQM/UMn7dqRj5se7LIJQvduQeviiiGLy+hNfU6KPj+fbpjULK+HBmizEHp9EHdsEy/PFmx1pa9 eFVK9bFwIz5OOpfCS3ziNueGenF4wBsYBmBgwq7HQQ7JOEXWIkIL7g2L1asEjqY/lfN71LY9qj3 oysss2xwr57CY= X-Received: by 2002:a05:600c:a0d:b0:493:c389:d434 with SMTP id 5b1f17b1804b1-493e684a968mr135326315e9.15.1783702938158; Fri, 10 Jul 2026 10:02:18 -0700 (PDT) Received: from localhost ([2a01:e0a:3c5:5fb1:5e43:31e8:5645:d4e0]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-493eb73ae14sm148311345e9.11.2026.07.10.10.02.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jul 2026 10:02:17 -0700 (PDT) From: Jerome Brunet To: Lee Jones Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Liam Girdwood , Mark Brown , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Andre Przywara , Conor Dooley Subject: Re: [PATCH v2 0/3] regulator: Add X-Powers AXP318W PMIC support In-Reply-To: <20260710-axp318-regulator-v2-0-ee5f1c56b49f@baylibre.com> (Jerome Brunet's message of "Fri, 10 Jul 2026 18:19:24 +0200") References: <20260710-axp318-regulator-v2-0-ee5f1c56b49f@baylibre.com> User-Agent: mu4e 1.12.9; emacs 30.1 Date: Fri, 10 Jul 2026 19:02:15 +0200 Message-ID: <1jse5qg4mg.fsf@starbuckisacylon.baylibre.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On ven. 10 juil. 2026 at 18:19, Jerome Brunet wrote: > This patch series adds support for the X-Powers AXP318W PMIC, which is > used recently on new boards with Allwinner SoCs (the A733). > > The PMIC features 9 DCDC buck converters and 28 LDOs, plus the usual ADC, > interrupts, and power key components. > A datasheet can be found linked in this Wiki table: > https://linux-sunxi.org/AXP_PMICs > > Patch 1 adds the compatible string to the binding document, and adds > the additional input supply properties. > Patch 2 is the MFD part, describing the regmap and all the interrupts. > So far we support the regulator and power key devices, the ADC and > other pieces will follow later. > Patch 3 adds the voltage regulator rails, this part is crucial to enable > any board using this PMIC, as we depend on those rails even for basic > devices. > > There was an unclosed topic regarding the handling of LDOs output > voltage being limited to input voltage being provided by the supply. > Chen-Yu noted the min_dropout_uV would be a good fit for that but > the actual minimal dropout value was unknown. I've arbitrarily picked > 1uV because it is the minimum the framework supports. Realistically a low > dropout regulator is bound to have some dropout. This choice > is very likely optimistic but does the trick for now. > > If anyone has problems because the dropout is actually higher > * it is arguably an HW design error > * it is a good time to let us know what the actual dropout is :P > I've focused on the regulator and the comments from v1 while taking over, assuming the rest was fine. I should not have. Please ignore this version. I'll re-spin it. > Changes in v2: > * Droped _NUM_VOLTAGES macros > * Use min_dropout_uV to limit LDO voltage to supplies > * Add bypass mode for EDLO4/5 > * Prevent crossing 1.54V threshold for DCDC6/7/8/9 > * Link to v1: https://lore.kernel.org/r/20251021112013.2710903-1-andre.przywara@arm.com > > --- > Andre Przywara (3): > dt-bindings: mfd: x-powers,axp152: Document AXP318W > mfd: axp20x: Add support for AXP318W PMIC > regulator: axp20x: add support for the AXP318W > > .../devicetree/bindings/mfd/x-powers,axp152.yaml | 28 +- > drivers/mfd/axp20x-i2c.c | 2 + > drivers/mfd/axp20x.c | 84 ++++++ > drivers/regulator/axp20x-regulator.c | 298 ++++++++++++++++++++- > include/linux/mfd/axp20x.h | 129 +++++++++ > 5 files changed, 532 insertions(+), 9 deletions(-) > --- > base-commit: dc59e4fea9d83f03bad6bddf3fa2e52491777482 > change-id: 20260710-axp318-regulator-43545ce3261f > > Best regards, -- Jerome