From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CAC2ECAAD5 for ; Tue, 6 Sep 2022 12:26:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239790AbiIFM0Y (ORCPT ); Tue, 6 Sep 2022 08:26:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44890 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240074AbiIFMZ7 (ORCPT ); Tue, 6 Sep 2022 08:25:59 -0400 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2F8B47C32E for ; Tue, 6 Sep 2022 05:22:18 -0700 (PDT) Received: by mail-wr1-x42c.google.com with SMTP id b5so15193590wrr.5 for ; Tue, 06 Sep 2022 05:22:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:from:to:cc:subject:date; bh=etRB1TES3HElT9FZpWWrbjBF4Hgq+Rpw7WzQMwgRKNE=; b=kVixT+G6sAyrpaX+Jd8i/qmqWAcqP2A3HuzTN1EChZncqgmuKzSTWSFrblBcz5EAiM X2IPpyBmI5kXEr8xKlGZOTxMWGyzwC+hfNtVSNpBYqNniW26uQbY8zwFEFkMKLWrEsCu TZMJ7w0BXNIDIa453ocHAw1KTaoAcyvxFwZvE6Dnzr0o+kBE0C9mN8pZzOfGAm3vmfHZ 4uMDGOnoS9liSq0upmAI6Of8riDPaOq3l1rN3o/nj2CBSSx79jH49JzB7XAVSvcAeJjx CseJy7IlPQ8siNDKZ6CasGBV4kcRhH+iosul04RbdS5Y0PEsEDagKQabqCQ13Sqe938P XoAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:x-gm-message-state:from:to:cc:subject:date; bh=etRB1TES3HElT9FZpWWrbjBF4Hgq+Rpw7WzQMwgRKNE=; b=keyDaYqQyUqDDzUXRrP0ifFDSXfIqPPAnAruUftJlZwEF4cMLyPt5fUDIcKzs3VG3F Jd+DT56o24dkRD//9tD7SCpkuKI/5v4OaPLd1Yu5bqlXokWG5sRrM92dIbu4bNFOPSXu uQfS1x5o90uWjnHV0hiSjaXryiJVSvvhpJngmXPWuTrxIDsikHN5TpkWIlLcyLJw/FaS kUwHe4sTMBoQQPoENtlrPViLsrWusWlCo7ZLFXMzIYXb9NNmmczSQ+7bY/I1yBQDTnTX HbFqS0HP1BYhQTFoJ3d//mbFJgvLY9wYFRe3QsKJh+zv2m6i+jAsJcErUJA0tEcFTiut v9CQ== X-Gm-Message-State: ACgBeo1Tk+1ovmEhy8l/QCM0vGfGeeivQn+KMT+PX3DCx+rJ/CjiUznu Ukanv3qGurefYwXPasrklLQQUw== X-Google-Smtp-Source: AA6agR7cXoWdXaVb+PdspVN/tctRjn4oDvh3CI43TFmWbSs0DrYVCD8dkd/BVjD6tQpyPJhgsAmjjA== X-Received: by 2002:a5d:5143:0:b0:226:de76:be7b with SMTP id u3-20020a5d5143000000b00226de76be7bmr22345327wrt.308.1662466935841; Tue, 06 Sep 2022 05:22:15 -0700 (PDT) Received: from localhost (laubervilliers-658-1-213-31.w90-63.abo.wanadoo.fr. [90.63.244.31]) by smtp.gmail.com with ESMTPSA id l6-20020a05600c4f0600b003a3170a7af9sm15588545wmq.4.2022.09.06.05.22.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Sep 2022 05:22:15 -0700 (PDT) References: <20220801092150.4449-1-pboos@baylibre.com> User-agent: mu4e 1.8.7; emacs 28.1 From: Jerome Brunet To: Philippe Boos , Wim Van Sebroeck , Guenter Roeck , Neil Armstrong Cc: Kevin Hilman , Martin Blumenstingl , "open list:WATCHDOG DEVICE DRIVERS" , "moderated list:ARM/Amlogic Meson SoC support" , "open list:ARM/Amlogic Meson SoC support" , open list Subject: Re: [PATCH v2] watchdog: meson: keep running if already active Date: Tue, 06 Sep 2022 14:21:26 +0200 In-reply-to: <20220801092150.4449-1-pboos@baylibre.com> Message-ID: <1jsfl4wv4a.fsf@starbuckisacylon.baylibre.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon 01 Aug 2022 at 11:21, Philippe Boos wrote: > If the watchdog is already running (e.g.: started by bootloader) then > the kernel driver should keep the watchdog active but the amlogic driver > turns it off. > > Let the driver fix the clock rate if already active because we do not > know the previous timebase value. To avoid unintentional resetting we > temporarily set it to its maximum value. > > Then keep the enable bit if is was previously active. > > Signed-off-by: Philippe Boos Reviewed-by: Jerome Brunet