From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 536F918EFD4 for ; Fri, 18 Oct 2024 08:39:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729240773; cv=none; b=rpjgiM95YeLsSVM0WIeqQ1CpSXDy5RVwwlCtsQv+PzAjgJ63RiIdoNSdeeHRQVyqLxCbp5kLwMTSBQf9E708JfCVaqWzrgc+jja86NIaeCa0LQeFsJt2TVyFlVVUVNUtjIh9GIATqFj7hf9DDL1tjiAAZKSqk/JFJ+9sGdRBJeA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729240773; c=relaxed/simple; bh=mc6L5X0DUWLJW/OkuS9ePuMADpz3zlh4zv/WCAV31FM=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=bawivEbgBPlbTlm83zwnkhDyzPxCyF7vxesiFuCf1e5h0lDaUpIu8aVQabgh/SbcMuufLTWF6ayVFcud/zDsmWCYWiFbyNKn1yJENS6VQTKH6EbYRzYwjhT/BfanJL4/DfLtRad1w4rvYQTbNFKHX4+EiLMRbjrPLWp3tiHDXM4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=RJh21MkO; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="RJh21MkO" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-4315eeb2601so13601215e9.2 for ; Fri, 18 Oct 2024 01:39:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1729240770; x=1729845570; darn=vger.kernel.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=HrncWdVx0bleY/RhYi61o0nRl8Zpr6NCNC/up3U4baE=; b=RJh21MkOuPaNjAw+3zN8rsI9EKXWte9YZ5uck6aCoPB4it2ioUXE+mSSbSrBHNGVZP auaqKWone7EmTMnx3GuVWjsrqWuShVVBerE40bbKvGGuwIO0IpKaXh9XNK+HDTQy4hNR h5yJF1e3otUZ5WSRY4JTwlfjE2kmRExDc29UzPk4iZkFyRlZ+9ajDIVAP6JcWcUJ3gxk IQ3WNpr4So9joz4WtS8GO5f85H//zuCY981qQYlNDnUAI1Q8Tlb/oUxAAMAyLJq7a70K 3zOElhQ07n2EVCstbWBXRe5xzyScR98RMrxo7ydd2UBidVy76nlEjIUbIodViiyG+/ka XJ/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729240770; x=1729845570; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HrncWdVx0bleY/RhYi61o0nRl8Zpr6NCNC/up3U4baE=; b=n+WNRDhLTjfFXpS/4IP2GCj7GNobra5XxGVEvrr/gD9NnW3OcISjRE4gu30hJaVPzt 2ZojQztdg0xdQZclmMeKD9lRIhJZojfVcTWLATzHvL9s9peC1NTNkTIeoMcW2L2kf0+q 0wlB33WqB7rvT2nkDD6XE4vow54GkhFOyBO9lqkZ1gFhNlykPPpb5981QW0s98djgx+6 A5QeA8VDirSAxbgtliLoFiQor1Emrasox6m1obDugb9TR92PONmEIj52kwTm34aTZaM0 qFgpuP3MK45wuSfWIviaIV/sYk38uwwN2Don+h8VdteIlKvPekgUprxEqDTBw5xlhVrE K/mg== X-Forwarded-Encrypted: i=1; AJvYcCWbq2bXL6utuaNnzCH0ll+SaSm9BpSrCqQcmUyhfKpOlt0+cQg7AXoCtfbdlZtCb7te7/lyVaBK/H/sEjo=@vger.kernel.org X-Gm-Message-State: AOJu0YzdcVVfrgbvsbjHnm8n00TWvmbCwQONiAxFBBG8tZvHO6EuLoqf AnsWl2WgNWTayU6uFVmI0GN18+5k6J7rgjJaf6Kr0X7THE2dNpKwNugk21OaUVYODLR+T/FGUSU TJ9o= X-Google-Smtp-Source: AGHT+IEtT0VrGwMXWD3f3PNN6+mMk8Niqje0hsKtwQA0iMPfyIkaGazeJqRT2ugGAgBVN1yXC2tZog== X-Received: by 2002:a05:600c:4e8b:b0:431:5c3d:1700 with SMTP id 5b1f17b1804b1-43161642386mr15793305e9.21.1729240769641; Fri, 18 Oct 2024 01:39:29 -0700 (PDT) Received: from localhost ([2a01:e0a:3c5:5fb1:6e2b:4562:2d66:575e]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43160e4fd55sm17360595e9.45.2024.10.18.01.39.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Oct 2024 01:39:29 -0700 (PDT) From: Jerome Brunet To: Krzysztof Kozlowski Cc: xianwei.zhao@amlogic.com, Linus Walleij , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Neil Armstrong , Kevin Hilman , Martin Blumenstingl , Bartosz Golaszewski , linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/3] dt-bindings: pinctrl: Add support for Amlogic A4 SoCs In-Reply-To: <4a79f996-9d82-48b2-8a93-d7917413ed8c@kernel.org> (Krzysztof Kozlowski's message of "Fri, 18 Oct 2024 10:28:51 +0200") References: <20241018-a4_pinctrl-v3-0-e76fd1cf01d7@amlogic.com> <20241018-a4_pinctrl-v3-1-e76fd1cf01d7@amlogic.com> <4a79f996-9d82-48b2-8a93-d7917413ed8c@kernel.org> Date: Fri, 18 Oct 2024 10:39:28 +0200 Message-ID: <1jttd9rein.fsf@starbuckisacylon.baylibre.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Fri 18 Oct 2024 at 10:28, Krzysztof Kozlowski wrote: > On 18/10/2024 10:10, Xianwei Zhao via B4 Relay wrote: >> From: Xianwei Zhao >> >> Add the new compatible name for Amlogic A4 pin controller, and add >> a new dt-binding header file which document the detail pin names. the change does not do what is described here. At least the description needs updating. So if the pin definition is now in the driver, does it mean that pins have to be referenced in DT directly using the made up numbers that are created in pinctrl-amlogic-a4.c at the beginning of patch #2 ? If that's case, it does not look very easy a read. >> >> Signed-off-by: Xianwei Zhao > > Acked-by: Krzysztof Kozlowski > > Best regards, > Krzysztof -- Jerome