From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5AE633321C2 for ; Fri, 19 Jun 2026 07:40:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781854821; cv=none; b=seEhRTPJqp/myMksuCuSO4tFeOwzhFIhYtUpr5rVRFDalQgpCKOBVX+dXd6sE1UdqeJuqB12Gq0ziOSnhWeDg3L4rg4yriubqj1NjM2YyL5gqA3/KRzNDuPA2zMMiEQIlK7SPlMCk2BV499ZH9x86yEAVNUZc75C1Sow553daB0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781854821; c=relaxed/simple; bh=c7x/XpbPG2XGf2qegF/oPNBop5Y2r8FRIEy56lES51s=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=k46VYIQjvBEu5rlG/Q4u2PW/Y6kGGSPVgYPzXmGC0vKBl0RYYX63FiuKRzoEM4mifwaYPxCdVzifti4SdvqTsE1GjWRhhnFAfpGjIDwT9fWVRM+Ts6VS2EGJ4lSyjaLVSuh6y1TbBDrBZhXkcVKx2Onj2FS/GyxMYm3IGZrBi94= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=DKbSzz21; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="DKbSzz21" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-490b8ac62baso27580835e9.0 for ; Fri, 19 Jun 2026 00:40:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1781854818; x=1782459618; darn=vger.kernel.org; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=Q4qbPpfXKjwWf+Dt6pjhae0Fsogba7Qsk/94yaXvhXg=; b=DKbSzz21mf+YRZYjAVYXGu7m8hF203gYsitXs5ovBe/koNOUCEsKABDglTSiWOxG95 1XJZwM+h+nxNujVI017vPg8BLmPyLpL9iSK0bqQJX90NShcZ8SFV6zcjkxfVTH9pCNvC 07qcr0f0q2uS+E8bx6CuUhyFCAowoWrJ0UxEjaP3Y6crJ6Qzfdbvt3vUWR50fUudzWmT Fc+KdSS4XYPTMcvrCV2sVb7nFAd0jUaDIS4i6ywx08Dz8k7OhvmpIPgPnSfQTyMPrynW GG55yERqkAex+vpRA2F+UP/VAmT9XZfZSS2Qfiy9pvrpoTQGUNuLaNz5EKVgQ4T2uiQj J5vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781854818; x=1782459618; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=Q4qbPpfXKjwWf+Dt6pjhae0Fsogba7Qsk/94yaXvhXg=; b=SkEnpI/Hg3bYcuGbdfrb4BXgDcYNKKvpxqDIoS+mm49UpCLNV2SwDOpFFSsBQq0QBy VHv1vEOBW2ISmaMeimLxwQJce9b/imhMm1PgJa1GuRLXhrYMMCVCw9d8jxtZNE6RHXpS EwVfajqHUlOVYAlLexxIEk1kOAT7cpMuAHKYaFvWclm5UWhx3S+9qGWE/ftKJFdprMTE xP9X44iJtsajYsKe1m9CzjWEdDYuVHhQoDP0oH1m7bPIyfgldZrl7a+p+AKMr3hRqp/w 4KqV/HtrPtppPZEb8Y+chEpFiJvBEddjqT9zZFdCNYa5xqNliFOOGNA5BCe19tBpuc6c aiIw== X-Forwarded-Encrypted: i=1; AFNElJ+pkVzmqDugYX6tA/JjLTOr1KpP2dprifvnppEuKtbHQghgIfrrGpeup7XnDDVQQH+jGna+eaaDa9b092c=@vger.kernel.org X-Gm-Message-State: AOJu0YxEBMdveP6dMxsheKiG9pRg/tWPkc2zMfYZjwq39d2O/uMWlCTH 0smurrdXh2H/MIl/PU2RS6rEKt5CDhoefC0jS6E03fuafWtcj156imSJ8DkXT0GfQzQ= X-Gm-Gg: AfdE7cnqhNi44d1SA7a35Cblpg52hlJ0iK1rIAGVN5/1fkltn4SppRsouzKamH49SxV PI76EtotO8//2lujsjKtP/ZA3Ud0Zk9+RpombAuUtAamjcByadhUALamUUfCv6MiSj+qzvixPkJ 2hXKDKJ85WrmE87rLERew/Qp3bZ37hbSn9h9wZAMXEGqxp7DYJeYsTHL5O9aNaHE3Oik4YjcfDf TgEcmT5rQksunbJqaoyLr3VVijzZnzqGg4oau7xJGBmUf5cwmNJtxZnAdAP4cjXvl48y+PoixCc Ld01RCadAyXP5QRAMGnLy3BXvy+xHko08j+5aE0Y+qFYFDzezaU7FftPXdC4A0jP7WUS80i+/jS pVkm8sGgGdUVh+nqheamsqWQu6XegUOwaUWsCkn2HrYx98J73bq8R3+VlyBGEW6xER6EuDqNPKb Y0nY4J3c5cWi7JcC5ODMy1pg== X-Received: by 2002:a05:600d:4448:20b0:489:32b:ac0b with SMTP id 5b1f17b1804b1-49240a09f71mr22313395e9.6.1781854817768; Fri, 19 Jun 2026 00:40:17 -0700 (PDT) Received: from localhost ([2a01:e0a:3c5:5fb1:95ed:eac1:5731:4e21]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-4650bc422c0sm5324812f8f.26.2026.06.19.00.40.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Jun 2026 00:40:17 -0700 (PDT) From: Jerome Brunet To: Jian Hu via B4 Relay Cc: Neil Armstrong , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Xianwei Zhao , Kevin Hilman , Martin Blumenstingl , jian.hu@amlogic.com, linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Conor Dooley Subject: Re: [PATCH v4 0/2] clk: amlogic: Add A9 AO clock controller In-Reply-To: <20260618-a9_aoclk-v4-0-569d0425e50c@amlogic.com> (Jian Hu via's message of "Thu, 18 Jun 2026 17:49:10 +0800") References: <20260618-a9_aoclk-v4-0-569d0425e50c@amlogic.com> User-Agent: mu4e 1.12.9; emacs 30.1 Date: Fri, 19 Jun 2026 09:40:15 +0200 Message-ID: <1jwlvvasgw.fsf@starbuckisacylon.baylibre.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On jeu. 18 juin 2026 at 17:49, Jian Hu via B4 Relay wrote: > This series adds Amlogic A9 AO clock support, including dt-binding and AO clock driver. > > Signed-off-by: Jian Hu A part from the 2 minor problems found by sashiko, This looks good. > --- > Changes in v4: > - Drop CLK_IS_CRITICAL for ao_xtal_in clock. > - Drop CLK_HW_INIT* and revert to explicit clock declarations. > - Link to v3: https://lore.kernel.org/r/20260610-a9_aoclk-v3-0-b7592d6c31e2@amlogic.com > > Changes in v3: > - Move COMPILE_TEST after 'depends on ARM64' reported by sashiko-bot. > - Rename i2c3 to i3c reported by sashiko-bot. > - Reword the comment describing ao_xtal_in's flags. > - Use struct clk_init_data to describe ao_xtal_in's hw.init. > - Link to v2: https://lore.kernel.org/r/20260603-a9_aoclk-v2-0-f47ea616ee78@amlogic.com > > Changes in v2: > - Split the A9 clock driver and send the AO clock separately. > - Rename aobus to soc. > - Use CLK_HW_INIT_FW_NAME to describe clk_init_data. > - Use CLK_HW_INIT_PARENTS_DATA to describe clk_init_data. > - Use a9_ao prefix for MESON_COMP_SEL. > - Correct duandiv name. > - Fix pwm b reg. > - Link to v1: https://lore.kernel.org/all/20260511-b4-a9_clk-v1-0-41cb4071b7c9@amlogic.com/ > > --- > Jian Hu (2): > dt-bindings: clock: Add Amlogic A9 AO clock controller > clk: amlogic: Add A9 AO clock controller driver > > .../bindings/clock/amlogic,a9-aoclkc.yaml | 76 ++++ > drivers/clk/meson/Kconfig | 13 + > drivers/clk/meson/Makefile | 1 + > drivers/clk/meson/a9-aoclk.c | 488 +++++++++++++++++++++ > include/dt-bindings/clock/amlogic,a9-aoclkc.h | 76 ++++ > 5 files changed, 654 insertions(+) > --- > base-commit: ca89c88bcf69daca829044c638a8163d5ce47af0 > change-id: 20260603-a9_aoclk-bbf531badc63 > > Best regards, -- Jerome