From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 62BFA1922EE for ; Wed, 21 May 2025 16:42:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747845756; cv=none; b=f+LXw6tCREESAX4ewPtBL6qceh37CMRXH+cSpgpywl4ApeToULrYMDqD05q5kKuLFDGJPFldQy8spPnyvT5AWYAmDiCRYjeR34f1WJ/9c5AxdwiNcpjQapGCchK/9oYV183WLNuvZyR6hmeDNryb0/Rdu0ycQSsiuFNCFZSuYOo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747845756; c=relaxed/simple; bh=Pr2iXeGarO2eWOWIEMNqbxZ1u9Fg64PXjfplyLT7Rjg=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=dJsf5R6QAu/AswxnOmJWsBiEW26zvDIJqGKvCT9O9pI1rqGu/F+3ZroESqS21INNJHEozPzMa8OCXXCysAh869VfRf70hr5TZTDTjUVElabVNukrjyH+NuALR5R6DxEnu1AIYdMxguSgOFrVoQf/NgDycxezuF32VNIkST9YBWs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=QUjIDCZz; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="QUjIDCZz" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-442e9c00bf4so51824045e9.3 for ; Wed, 21 May 2025 09:42:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1747845752; x=1748450552; darn=vger.kernel.org; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=p+rpUaNjQK4QRzCb0yqL+gVJP+k0UxVN5eahq6kD2BQ=; b=QUjIDCZzypEAp3braYoAzUW1MvQCKpD34MLEGgUt50cLFKOIktdfM3WDh1bbmkYyGp hiYPHaJJEXtJ9K+CAVJCR/nfgSK6XiHCZbnEeZDdmvmG8Msgd0XYdVk/zQqFmJ246uzQ 6HVGY58dMzZfC82LxJhdn0dJ52FCR3BJYCJHenifQv2OS9QgNHxUsVmNSkzvvAzHhxbh JZbqQEBQsW1KJMyBdALrcdPZFRw2f8+QS5I+2fOYg+UXygXsSfVMS3IRmTTLwRyEhkHY U1/y7/LseFbpPeR77F9MFULueysSJtexz8uiE/9L3m+IwbLdnV0txfUo7t8PPFIeRp4b Yeow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747845752; x=1748450552; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=p+rpUaNjQK4QRzCb0yqL+gVJP+k0UxVN5eahq6kD2BQ=; b=L9gBaOqRhRazIEr1cCaXlz12c9BNdbP/6SSs8v/0JoWQ05Dw1vVY+n1KzcIYWZhjJr Wfkgt+8cpsujhhEFhF3j/2iDd4PXRBF9H/PR8CpVcTbKn79eeLvNxpZxuj2W0LViBHi9 sUjSQikUXAvWoDLm7PhmeMJvGVzOtsLb41LuJkzV0A3I2KvSod3HDMuopsCp9ngRCRLL jb12iBu0ee2TKSAEeo4PvNwwSPl+ILrSCM5B2AREpAH5czggnafOkAEcGKqVJKabf9+z E+rdomn/5LZAgY+ekLA0KzUDC3qNYJBqjaf0n1HwZH+vCrpxvGJPyuTXCojlHEfOM1vw 7vBw== X-Forwarded-Encrypted: i=1; AJvYcCVxsLoTZM8OgmGaeXR1vPN8oJyWB+G+9yz1+hfhoMnk/QvMHsbHNETjJ4kqW2iObejc7Z892MDZg0hwfkU=@vger.kernel.org X-Gm-Message-State: AOJu0YxdBRXD+xgqv0xxpX/JFT2j+1vqNj3yevLrDfQTMFA5FAWdafCg LRG0LwCbP2O3xL1IZfCchmm3zAMcyIJ4HpjS6xGDHk4YHPeutJnrAGqXqHzaNjyFQYM= X-Gm-Gg: ASbGncuMujnnf14lKrqXgFBBzBQmZ6tZFox7KyTAWUQxceANqNJirAy2tVN399L8LwV 4Bwgw8qux8KTiq96U0a6Lb3DH1Q9ui+hQoUcglo7wWM9LL21onS5n7rUAv/Tmy9MyqFLqJE11xy WhLxulqh8g9JC7vuip7RyxOFUo19nuQeDOD/ry9gj/FzVKtv/OWF5/mr2PTitEZq8N4SumH6atl yJ8CAWeqKFGIeWQ/mofKIfn4U+oFet0HqU3svdh9Jds7+/EhimNiHOvbW2gPJodwbdrpf42jMOY Mi8XH/TpvBxvFG04vzZL/83a/iUwHpxJ4n9F/Y0LfitPoYRkLQ== X-Google-Smtp-Source: AGHT+IEeXDpnI4NwMcbKV1XjqWsxVe0v1X9IAk4NWkX0pUgdvpaaFVRgCRCctQA58qHtRm5Ki9qQtw== X-Received: by 2002:a05:600c:1992:b0:43d:45a:8fca with SMTP id 5b1f17b1804b1-442ff039684mr199120715e9.30.1747845752620; Wed, 21 May 2025 09:42:32 -0700 (PDT) Received: from localhost ([2a01:e0a:3c5:5fb1:9e2b:b056:8709:130]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-442ebda7d2csm167543525e9.3.2025.05.21.09.42.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 May 2025 09:42:32 -0700 (PDT) From: Jerome Brunet To: Frank Li Cc: Jon Mason , Dave Jiang , Allen Hubbe , Manivannan Sadhasivam , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Kishon Vijay Abraham I , Bjorn Helgaas , ntb@lists.linux.dev, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/4] PCI: endpoint: pci-epf-vntb: align mw naming with config names In-Reply-To: (Frank Li's message of "Wed, 21 May 2025 12:28:44 -0400") References: <20250505-pci-vntb-bar-mapping-v1-0-0e0d12b2fa71@baylibre.com> <20250505-pci-vntb-bar-mapping-v1-2-0e0d12b2fa71@baylibre.com> <1jecwjn2pp.fsf@starbuckisacylon.baylibre.com> User-Agent: mu4e 1.12.9; emacs 30.1 Date: Wed, 21 May 2025 18:42:30 +0200 Message-ID: <1jwma9lxu1.fsf@starbuckisacylon.baylibre.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Wed 21 May 2025 at 12:28, Frank Li wrote: > On Tue, May 20, 2025 at 09:47:14AM +0200, Jerome Brunet wrote: >> On Mon 19 May 2025 at 17:21, Frank Li wrote: >> >> > On Mon, May 05, 2025 at 07:41:48PM +0200, Jerome Brunet wrote: >> > >> > PCI tree require keep consistent at subject >> > git log --oneline drivers/pci/endpoint/functions/pci-epf-vntb.c >> > >> > require first char is UP case. >> >> Noted >> >> > >> > Align memory window naming with configfs names. >> > >> >> The config file related to the memory windows start the numbering of >> > >> > memory windows (MW) >> > then you can use MW later. >> >> Sure >> >> > >> >> the MW from 1. The other NTB function does the same, yet the enumeration >> >> defining the BARs of the vNTB function starts numbering the MW from 0. >> >> >> >> Both numbering are fine I suppose but mixing the two is a bit confusing. >> >> The configfs file being the interface with userspace, lets keep that stable >> >> and consistently start the numbering of the MW from 1. >> >> >> >> Signed-off-by: Jerome Brunet >> >> --- >> >> drivers/pci/endpoint/functions/pci-epf-vntb.c | 11 ++++++----- >> >> 1 file changed, 6 insertions(+), 5 deletions(-) >> >> >> >> diff --git a/drivers/pci/endpoint/functions/pci-epf-vntb.c b/drivers/pci/endpoint/functions/pci-epf-vntb.c >> >> index 35fa0a21fc91100a5539bff775e7ebc25e1fb9c1..f9f4a8bb65f364962dbf1e9011ab0e4479c61034 100644 >> >> --- a/drivers/pci/endpoint/functions/pci-epf-vntb.c >> >> +++ b/drivers/pci/endpoint/functions/pci-epf-vntb.c >> >> @@ -70,9 +70,10 @@ static struct workqueue_struct *kpcintb_workqueue; >> >> enum epf_ntb_bar { >> >> BAR_CONFIG, >> >> BAR_DB, >> >> - BAR_MW0, >> >> BAR_MW1, >> >> BAR_MW2, >> >> + BAR_MW3, >> >> + BAR_MW4, >> > >> > where use BAR_MW3 and BAR_MW4? >> >> This is aligned with the file available in configfs and what is possible >> in theory with the function, same as the NTB function and NTB host driver. >> >> Stopping at MW1 because it is only one used in the driver would be weird >> and the number later introduced would be wrong. > > Yes, but BAR_MW3 and BAR_MW4 should be added only when both was used in code > actaully. If you want to be strict about that then BAR_MW4 should go to the next change, it is needed in the enum. BAR_MW3 shall stay here because the purpose of this change is to shift the MW naming by one. MW2 which was present becomes MW3. > > Frank >> >> >> > >> > Frank >> >> }; >> >> >> >> /* >> >> @@ -576,7 +577,7 @@ static int epf_ntb_mw_bar_init(struct epf_ntb *ntb) >> >> >> >> for (i = 0; i < ntb->num_mws; i++) { >> >> size = ntb->mws_size[i]; >> >> - barno = ntb->epf_ntb_bar[BAR_MW0 + i]; >> >> + barno = ntb->epf_ntb_bar[BAR_MW1 + i]; >> >> >> >> ntb->epf->bar[barno].barno = barno; >> >> ntb->epf->bar[barno].size = size; >> >> @@ -629,7 +630,7 @@ static void epf_ntb_mw_bar_clear(struct epf_ntb *ntb, int num_mws) >> >> int i; >> >> >> >> for (i = 0; i < num_mws; i++) { >> >> - barno = ntb->epf_ntb_bar[BAR_MW0 + i]; >> >> + barno = ntb->epf_ntb_bar[BAR_MW1 + i]; >> >> pci_epc_clear_bar(ntb->epf->epc, >> >> ntb->epf->func_no, >> >> ntb->epf->vfunc_no, >> >> @@ -676,7 +677,7 @@ static int epf_ntb_init_epc_bar(struct epf_ntb *ntb) >> >> epc_features = pci_epc_get_features(ntb->epf->epc, ntb->epf->func_no, ntb->epf->vfunc_no); >> >> >> >> /* These are required BARs which are mandatory for NTB functionality */ >> >> - for (bar = BAR_CONFIG; bar <= BAR_MW0; bar++, barno++) { >> >> + for (bar = BAR_CONFIG; bar <= BAR_MW1; bar++, barno++) { >> >> barno = pci_epc_get_next_free_bar(epc_features, barno); >> >> if (barno < 0) { >> >> dev_err(dev, "Fail to get NTB function BAR\n"); >> >> @@ -1048,7 +1049,7 @@ static int vntb_epf_mw_set_trans(struct ntb_dev *ndev, int pidx, int idx, >> >> struct device *dev; >> >> >> >> dev = &ntb->ntb.dev; >> >> - barno = ntb->epf_ntb_bar[BAR_MW0 + idx]; >> >> + barno = ntb->epf_ntb_bar[BAR_MW1 + idx]; >> >> epf_bar = &ntb->epf->bar[barno]; >> >> epf_bar->phys_addr = addr; >> >> epf_bar->barno = barno; >> >> >> >> -- >> >> 2.47.2 >> >> >> >> -- >> Jerome -- Jerome