From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA5B7C7EE2F for ; Mon, 12 Jun 2023 20:05:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234982AbjFLUF1 (ORCPT ); Mon, 12 Jun 2023 16:05:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40976 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234891AbjFLUEm (ORCPT ); Mon, 12 Jun 2023 16:04:42 -0400 Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 62AF5186 for ; Mon, 12 Jun 2023 13:04:40 -0700 (PDT) Received: by mail-wr1-x435.google.com with SMTP id ffacd0b85a97d-30fc6b513afso766824f8f.1 for ; Mon, 12 Jun 2023 13:04:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20221208.gappssmtp.com; s=20221208; t=1686600279; x=1689192279; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:from:to:cc:subject:date:message-id:reply-to; bh=YzNsZC6f0ahxcqJoEVkr3mmh3LhtJkgOMa+jSW4jW4w=; b=Bf7pNtCF/I7e3eWMOv6SyG52CdpbOvoHwSlm74rGPTi0sdpPC5Xm2EU1eb2u2exmi5 VQYrRpwns3q4FMFWvCysI1lQC78YYuPi41xQ5jbvO78hzMN/IC6uoBDK/9RHY5chnSPP v4Y76tVi+eYetxsQmh8lVUkyls4uhh3oH7n2FCjYv3DVqHjz6HmByWfLgI1xSma3GsvV n6CEGg/H2X4y5vHSMKug5EY8rkNH/8EajTI/1t6BhbAUucSiY54Ce3wnRGXHe9N0/1vy kVGvZX2QYB2KPKR7cOLweqyKOg61L9MJrPm1cfK5iiUBZteYlHJEkM0wkQ8sHVFlepS1 Jo4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686600279; x=1689192279; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=YzNsZC6f0ahxcqJoEVkr3mmh3LhtJkgOMa+jSW4jW4w=; b=fAavlqgkG9TOtytefjO8FjfGXZeiEmp1kXzSnOc0vQXSMEttvRaniJXLj96YSvljVq 5RdfQ0ZKfdbx+cTZopwbzofia8VBnp5VduRHfGqK7H5UGAQwdr+yoCW0qBHTHnBUtsDq SFyZRhLSnlCDaHI6zQsazH/GPr+0AbqyhT/EO3BHX9nOzC80NgrVhGZmwLa6qN6QSeAl oCbDVH3Blr0omO/o72QEek0x83JIlR9Qhgd47JH8h5kBGAvqqEROnaEOL64AS7CdMPWM L9xzhkSMyB99pprRlyCePENnpJXwwYXcNzJI5CEXokW2CmYvLJUK7ptmtNWaawxDLFI9 r4Bg== X-Gm-Message-State: AC+VfDymnKIZvxGSFgxdQ5x+rXZdoVSBuu6nFXE9DM2ahM+Tt3oSpf+p hopbwOACiYDDbNyXjoRpcXRSLQ== X-Google-Smtp-Source: ACHHUZ4u9yNXmp6fhE5G8NnIfX3V5/d6Zvn8rSRouBJFVjUSo4oN1ZFCeTUbWQfFUxGOVTVzl54GQg== X-Received: by 2002:adf:f410:0:b0:30f:bc8f:6d49 with SMTP id g16-20020adff410000000b0030fbc8f6d49mr4131648wro.13.1686600278783; Mon, 12 Jun 2023 13:04:38 -0700 (PDT) Received: from localhost (82-65-169-74.subs.proxad.net. [82.65.169.74]) by smtp.gmail.com with ESMTPSA id i17-20020a5d6311000000b0030fae360f14sm8035712wru.68.2023.06.12.13.04.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Jun 2023 13:04:37 -0700 (PDT) References: <20230612182332.371003-1-sboyd@kernel.org> User-agent: mu4e 1.8.13; emacs 28.2 From: Jerome Brunet To: Michael Turquette , Stephen Boyd Cc: linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, patches@lists.linux.dev, Jian Hu , Dmitry Rokosov , Martin Blumenstingl Subject: Re: [PATCH] clk: meson: a1: Staticize rtc clk Date: Mon, 12 Jun 2023 22:03:11 +0200 In-reply-to: <20230612182332.371003-1-sboyd@kernel.org> Message-ID: <1jzg54fnvw.fsf@starbuckisacylon.baylibre.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon 12 Jun 2023 at 11:23, Stephen Boyd wrote: > Sparse rightly complains that this symbol is supposed to be static. > > Cc: Jian Hu > Cc: Dmitry Rokosov > Cc: Martin Blumenstingl > Cc: Jerome Brunet > Fixes: 84af914404db ("clk: meson: a1: add Amlogic A1 Peripherals clock controller driver") > Signed-off-by: Stephen Boyd Reviewed-by: Jerome Brunet Sorry this got through. > --- > drivers/clk/meson/a1-peripherals.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clk/meson/a1-peripherals.c b/drivers/clk/meson/a1-peripherals.c > index b320134fefeb..75dfae210fe5 100644 > --- a/drivers/clk/meson/a1-peripherals.c > +++ b/drivers/clk/meson/a1-peripherals.c > @@ -218,7 +218,7 @@ static struct clk_regmap rtc_32k_sel = { > }, > }; > > -struct clk_regmap rtc = { > +static struct clk_regmap rtc = { > .data = &(struct clk_regmap_gate_data){ > .offset = RTC_BY_OSCIN_CTRL0, > .bit_idx = 30,