mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Detlev Casanova <detlev.casanova@collabora.com>
To: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Heiko Stuebner <heiko@sntech.de>,
	Johan Jonker <jbx6244@gmail.com>, Alex Bee <knaerzche@gmail.com>,
	Christian Hewitt <christianshewitt@gmail.com>,
	Robin Murphy <robin.murphy@arm.com>,
	Nicolas Frattaroli <frattaroli.nicolas@gmail.com>,
	Nicolas Frattaroli <nicolas.frattaroli@collabora.com>,
	Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
	Diederik de Haas <diederik@cknow-tech.com>
Cc: kernel@collabora.com, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/7] arm64: dts: rockchip: Rename rk356x HDMI audio card
Date: Mon, 31 Aug 2026 16:07:37 -0400	[thread overview]
Message-ID: <1l5cQ5HdTvCBGiUCVh40og@collabora.com> (raw)
In-Reply-To: <DL3B1XH7K4WC.1ZXA6ANI8Q1A0@cknow-tech.com>

On Monday, 31 August 2026 13:29:00 EDT Diederik de Haas wrote:
> On Mon Aug 31, 2026 at 4:20 PM CEST, Detlev Casanova wrote:
> > Rename the card from "HDMI" to "RK356x HDMI" so it identifies the SoC
> > in user-visible ALSA fields and no longer collides with the identical
> > "HDMI" string used by other Rockchip SoCs.
> > 
> > Fixes: 697ee8546e241 ("arm64: dts: rockchip: Add HDMI audio nodes to
> > rk356x") Signed-off-by: Detlev Casanova <detlev.casanova@collabora.com>
> > ---
> > 
> >  arch/arm64/boot/dts/rockchip/rk356x-base.dtsi | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/arch/arm64/boot/dts/rockchip/rk356x-base.dtsi
> > b/arch/arm64/boot/dts/rockchip/rk356x-base.dtsi index
> > a5832895bd39..98785c812fc4 100644
> > --- a/arch/arm64/boot/dts/rockchip/rk356x-base.dtsi
> > +++ b/arch/arm64/boot/dts/rockchip/rk356x-base.dtsi
> > @@ -150,7 +150,7 @@ scmi_clk: protocol@14 {
> > 
> >  	hdmi_sound: hdmi-sound {
> >  	
> >  		compatible = "simple-audio-card";
> > 
> > -		simple-audio-card,name = "HDMI";
> > +		simple-audio-card,name = "RK356x HDMI";
> 
> Move the name property to rk3566.dtsi and rk3568.dtsi and use their actual
> SoC name, thus RK3566 and RK3568?

I hesitated on this one but I agree with you, it's better to have more 
granularity. Will update in v2.

Detlev.

> Cheers,
>   Diederik
> 
> >  		simple-audio-card,format = "i2s";
> >  		simple-audio-card,mclk-fs = <256>;
> >  		status = "disabled";





  reply	other threads:[~2026-08-31 20:14 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-31 14:20 [PATCH 0/7] arm64: dts: rockchip: give HDMI sound cards SoC-specific names Detlev Casanova
2026-08-31 14:20 ` [PATCH 1/7] arm64: dts: rockchip: Rename rk3066a HDMI audio card Detlev Casanova
2026-08-31 14:20 ` [PATCH 2/7] arm64: dts: rockchip: Rename rk3288 " Detlev Casanova
2026-08-31 14:20 ` [PATCH 3/7] arm64: dts: rockchip: Rename rk3328 " Detlev Casanova
2026-08-31 14:20 ` [PATCH 4/7] arm64: dts: rockchip: Rename rk3399 " Detlev Casanova
2026-08-31 14:20 ` [PATCH 5/7] arm64: dts: rockchip: Rename rk356x " Detlev Casanova
2026-08-31 17:29   ` Diederik de Haas
2026-08-31 20:07     ` Detlev Casanova [this message]
2026-08-31 14:20 ` [PATCH 6/7] arm64: dts: rockchip: Rename rk3576 " Detlev Casanova
2026-08-31 14:20 ` [PATCH 7/7] arm64: dts: rockchip: Rename rk3588 HDMI audio cards Detlev Casanova

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1l5cQ5HdTvCBGiUCVh40og@collabora.com \
    --to=detlev.casanova@collabora.com \
    --cc=christianshewitt@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=diederik@cknow-tech.com \
    --cc=frattaroli.nicolas@gmail.com \
    --cc=heiko@sntech.de \
    --cc=jbx6244@gmail.com \
    --cc=kernel@collabora.com \
    --cc=knaerzche@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=nicolas.frattaroli@collabora.com \
    --cc=robh@kernel.org \
    --cc=robin.murphy@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®