From: Peter Samuelson <peter@cadcamlab.org>
To: Chip Salzenberg <chip@valinux.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] 2.2.18pre21: DRM update
Date: Tue, 21 Nov 2000 00:32:09 -0600 [thread overview]
Message-ID: <20001121003209.D2918@wire.cadcamlab.org> (raw)
In-Reply-To: <20001117201603.A3439@valinux.com>
In-Reply-To: <20001117201603.A3439@valinux.com>; from chip@valinux.com on Fri, Nov 17, 2000 at 08:16:03PM -0800
[Chip Salzenberg]
> --- drivers/char/Makefile.prev
> +++ drivers/char/Makefile Fri Nov 17 13:30:04 2000
> @@ -12,5 +12,5 @@
> SUB_DIRS :=
> MOD_SUB_DIRS := $(SUB_DIRS)
> -ALL_SUB_DIRS := $(SUB_DIRS) rio ftape joystick drm agp
> +ALL_SUB_DIRS := $(SUB_DIRS) rio ftape joystick
>
> #
> @@ -395,4 +395,16 @@
> endif
>
> +ifeq ($(CONFIG_DRM),y)
> +O_OBJS += drm/drm.o
> +ALL_SUB_DIRS += drm
> +MOD_SUB_DIRS += drm
The bits about ALL_SUB_DIRS are trivially wrong. You should define it
unconditionally -- that way the user doesn't have to 'make dep' after
every 'make *config'.
Not a very important point, granted.
> #ifndef __HAVE_ARCH_CMPXCHG
> /* Include this here so that driver can be
> used with older kernels. */
> +#if defined(__alpha__)
This section ought to be in include/asm-{alpha,i386}/system.h like in
2.4 (and like sparc64 in 2.2). Then again, perhaps in 2.2 it is best
to let sleeping dogs lie.
Peter
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2000-11-21 7:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-11-18 4:16 Chip Salzenberg
2000-11-18 17:10 ` Alan Cox
2000-11-21 6:32 ` Peter Samuelson [this message]
2000-11-24 22:51 Ed Tomlinson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20001121003209.D2918@wire.cadcamlab.org \
--to=peter@cadcamlab.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=chip@valinux.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®