From: Andi Kleen <ak@suse.de>
To: Jeff Garzik <jgarzik@mandrakesoft.com>
Cc: "Adam J. Richter" <adam@yggdrasil.com>, linux-kernel@vger.kernel.org
Subject: Re: Patch(?): pci_device_id tables for linux-2.4.0-test11/drivers/block
Date: Wed, 22 Nov 2000 23:18:54 +0100 [thread overview]
Message-ID: <20001122231854.A29401@gruyere.muc.suse.de> (raw)
In-Reply-To: <200011222201.OAA29131@baldur.yggdrasil.com> <3A1C454E.FC4787CE@mandrakesoft.com>
In-Reply-To: <3A1C454E.FC4787CE@mandrakesoft.com>; from jgarzik@mandrakesoft.com on Wed, Nov 22, 2000 at 05:14:38PM -0500
On Wed, Nov 22, 2000 at 05:14:38PM -0500, Jeff Garzik wrote:
> *This* is the over-engineering attitude I was talking about. The only
> reason why you are preferring named initializers is because
> pci_device_id MIGHT be changed. And if it is changed, it makes the
> changeover just tad easier. For that, you ugly up the code and make it
> more difficult to maintain.
The other reason is that it makes self documenting code -- no need to look
up the structure definition to make sense out of the code.
-Andi (who thinks easily readable code is good)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2000-11-22 22:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-11-22 22:01 Adam J. Richter
2000-11-22 22:14 ` Jeff Garzik
2000-11-22 22:18 ` Andi Kleen [this message]
2000-11-22 22:34 ` Jeff Garzik
2000-11-22 22:36 ` Keith Owens
2000-11-23 0:50 ` Russell King
2000-11-23 2:18 Adam J. Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20001122231854.A29401@gruyere.muc.suse.de \
--to=ak@suse.de \
--cc=adam@yggdrasil.com \
--cc=jgarzik@mandrakesoft.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®