mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "David S. Miller" <davem@redhat.com>
To: ben@zeus.com
Cc: ak@suse.de, linux-kernel@vger.kernel.org
Subject: Re: TCP push missing with writev()
Date: Thu, 30 Nov 2000 16:08:30 -0800	[thread overview]
Message-ID: <200012010008.QAA07573@pizda.ninka.net> (raw)
In-Reply-To: <Pine.LNX.4.30.0011302342590.1741-100000@bagpipe.bogo.bogus> (message from Ben Mansell on Fri, 1 Dec 2000 00:15:45 +0000 (GMT))
In-Reply-To: <Pine.LNX.4.30.0011302342590.1741-100000@bagpipe.bogo.bogus>

   Date: Fri, 1 Dec 2000 00:15:45 +0000 (GMT)
   From: Ben Mansell <ben@zeus.com>

   Paranoia check: can this bug occur with writev() and other
   combinations of sizes, or is it only when there is a 0-length
   buffer in there?

Only the 0-length buffer at the end of the iovec can trigger this
problem.  The PSH bit check during writes is basically:

	if (we are emptying the current iovec entry &&
            no more iovecs to process)
		set PSH bit

Zero length iovec entries do not even make it to this test
since the zero length makes the loop this test is within
never execute.

Later,
David S. Miller
davem@redhat.com
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

      reply	other threads:[~2000-12-01  0:54 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2000-11-30 17:35 Ben Mansell
2000-11-30 18:14 ` Andi Kleen
2000-11-30 18:54   ` Ben Mansell
2000-11-30 20:15 ` David S. Miller
2000-11-30 22:57   ` Ben Mansell
2000-11-30 23:01     ` David S. Miller
2000-12-01  0:15       ` Ben Mansell
2000-12-01  0:08         ` David S. Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200012010008.QAA07573@pizda.ninka.net \
    --to=davem@redhat.com \
    --cc=ak@suse.de \
    --cc=ben@zeus.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®