mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andi Kleen <ak@suse.de>
To: Matthew Jacob <mjacob@feral.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
	baettig@scs.ch, linux-kernel@vger.kernel.org
Subject: Re: io_request_lock question (2.2)
Date: Sat, 9 Dec 2000 01:14:57 +0100	[thread overview]
Message-ID: <20001209011457.A30226@gruyere.muc.suse.de> (raw)
In-Reply-To: <E144XLU-0004eG-00@the-village.bc.nu> <Pine.BSF.4.21.0012081603110.72881-100000@beppo.feral.com>
In-Reply-To: <Pine.BSF.4.21.0012081603110.72881-100000@beppo.feral.com>; from mjacob@feral.com on Fri, Dec 08, 2000 at 04:03:58PM -0800

On Fri, Dec 08, 2000 at 04:03:58PM -0800, Matthew Jacob wrote:
> 
> 
> On Fri, 8 Dec 2000, Alan Cox wrote:
> 
> > > Yes, and I believe that this is what's broken about the SCSI midlayer. The the
> > > io_request_lock cannot be completely released in a SCSI HBA because the flags
> > 
> > You can drop it with spin_unlock_irq and that is fine. I do that with no
> > problems in the I2O scsi driver for example
> 
> I am (like, I think I *finally* got locking sorta right in my QLogic driver),
> but doesn't this still leave ints blocked for this CPU at least?

spin_unlock_irq() does a __sti()
spin_unlock() doesn't. 

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

  parent reply	other threads:[~2000-12-09  0:45 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2000-12-08  0:17 Reto Baettig
2000-12-08  0:24 ` Alan Cox
2000-12-08  1:27   ` Reto Baettig
2000-12-08 13:44     ` Alan Cox
2000-12-08 18:22       ` Matthew Jacob
2000-12-08 23:54         ` Alan Cox
2000-12-09  0:03           ` Matthew Jacob
2000-12-09  0:10             ` Reto Baettig
2000-12-09  0:18               ` Matthew Jacob
2000-12-09  0:14             ` Andi Kleen [this message]
2000-12-09  0:19               ` Matthew Jacob
2000-12-09  1:06                 ` Andi Kleen
2000-12-09  0:25             ` Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20001209011457.A30226@gruyere.muc.suse.de \
    --to=ak@suse.de \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=baettig@scs.ch \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mjacob@feral.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®