From: "David S. Miller" <davem@redhat.com>
To: laforge@gnumonks.org
Cc: ionut@cs.columbia.edu, mhaque@haque.net, linux-kernel@vger.kernel.org
Subject: Re: Netfilter is broken (was Re: ip_defrag is broken (was: Re: test12 lockups -- need feedback))
Date: Thu, 14 Dec 2000 16:11:10 -0800 [thread overview]
Message-ID: <200012150011.QAA12767@pizda.ninka.net> (raw)
In-Reply-To: <20001215012000.B6775@coruscant.gnumonks.org> (message from Harald Welte on Fri, 15 Dec 2000 01:20:00 +0100)
In-Reply-To: <Pine.LNX.4.30.0012141204210.27848-100000@age.cs.columbia.edu> <200012141955.LAA08814@pizda.ninka.net> <20001215012000.B6775@coruscant.gnumonks.org>
Date: Fri, 15 Dec 2000 01:20:00 +0100
From: Harald Welte <laforge@gnumonks.org>
Or is there something wrong with:
- packet arrives in net/ipv4/ip_input.c:ip_rcv()
- netfilter hook NF_IP_PRE_ROUTING is called
- net/ipv4/netfilter/ip_conntrack_core.c:ip_conntrack_in() is called
- net/ipv4/netfilter/ip_conntrack_core.c:ip_ct_gather_frags() is called
- net/ipv4/ip_input.c:ip_defrag() is called
Isn't the skb->dev member supposed to still point to the receiving
device?
No, once you submit the packet to the defrag layer, that SKB
instance is owned by the defrag layer.
One way to do what netfilter wants to do, but legally, is to
simply skb_clone() the SKB before passing it into the
defragmentation code.
I'm still deciding whether this is the best fix.
Later,
David S. Miller
davem@redhat.com
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2000-12-15 0:59 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-12-13 23:22 test12 lockups -- need feedback Mohammad A. Haque
2000-12-14 0:22 ` Mikael Djurfeldt
2000-12-14 0:29 ` Mikael Djurfeldt
2000-12-14 1:28 ` dep
2000-12-14 2:58 ` Mohammad A. Haque
2000-12-14 3:48 ` Mohammad A. Haque
2000-12-14 12:21 ` Ingo Oeser
2000-12-14 11:42 ` Mohammad A. Haque
2000-12-15 15:20 ` Ingo Oeser
2000-12-14 12:10 ` dep
2000-12-14 12:15 ` Mohammad A. Haque
2000-12-14 13:16 ` dep
2000-12-14 14:41 ` Bob_Tracy
2000-12-14 18:38 ` ip_defrag is broken (was: Re: test12 lockups -- need feedback) Ion Badulescu
2000-12-14 19:27 ` David S. Miller
2000-12-14 19:52 ` Ion Badulescu
2000-12-14 19:43 ` David S. Miller
2000-12-14 20:07 ` Ion Badulescu
2000-12-14 19:55 ` Netfilter is broken (was Re: ip_defrag is broken (was: Re: test12 lockups -- need feedback)) David S. Miller
2000-12-15 0:11 ` David S. Miller [this message]
2000-12-15 0:48 ` Andi Kleen
2000-12-15 1:25 ` Harald Welte
2000-12-15 0:20 ` Harald Welte
2000-12-14 20:35 ` ip_defrag is broken (was: Re: test12 lockups -- need feedback) Mohammad A. Haque
2000-12-14 20:23 ` David S. Miller
2000-12-14 21:25 ` Mohammad A. Haque
2000-12-14 22:50 ` Mohammad A. Haque
2000-12-14 23:58 ` Mohammad A. Haque
2000-12-15 8:52 ` Jasper Spaans
2000-12-15 9:22 ` Tom Leete
2000-12-15 2:25 ` Tom Leete
2000-12-15 13:12 ` Rusty Russell
2000-12-14 20:49 ` Bob_Tracy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200012150011.QAA12767@pizda.ninka.net \
--to=davem@redhat.com \
--cc=ionut@cs.columbia.edu \
--cc=laforge@gnumonks.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhaque@haque.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®